Fix display:contents ::scroll-marker inertness issue [chromium/src : main]
0 views
Skip to first unread message
Rune Lillesveen (Gerrit)
Jun 12, 2026, 10:10:03 AMJun 12
to Rune Lillesveen, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Morten Stenshorne
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Morten Stenshorne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Morten Stenshorne (Gerrit)
Jun 12, 2026, 2:05:56 PMJun 12
to Rune Lillesveen, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen
Morten Stenshorne voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jun 12, 2026, 2:10:13 PMJun 12
to Rune Lillesveen, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60592.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
Jun 15, 2026, 5:01:58 AM (12 days ago) Jun 15
to Rune Lillesveen, Blink W3C Test Autoroller, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Rune Lillesveen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 15, 2026, 6:26:00 AM (12 days ago) Jun 15
to Rune Lillesveen, Blink W3C Test Autoroller, Morten Stenshorne, chromium...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Fix display:contents ::scroll-marker inertness issue
A ::scroll-marker inherits inertness from the ::scroll-marker-group.
This was done in PseudoElement::AdjustedLayoutStyle(), but for
display:contents, the inertness inheritance was just skipped.
Make a separate AdjustedLayoutStyle() for ScrollMarkerPseudoElement and
apply those changes on top of display:contents adjustments from
PseudoElement.
Bug: 522843224
Change-Id: Ib71e81f82310ae5133bf7ef3d2e1a956087cd3b3
Reviewed-by: Morten Stenshorne <mste...@chromium.org>
Commit-Queue: Rune Lillesveen <fut...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1646696}
Files:
- M third_party/blink/renderer/core/dom/pseudo_element.cc
- M third_party/blink/renderer/core/dom/scroll_marker_pseudo_element.cc
- M third_party/blink/renderer/core/dom/scroll_marker_pseudo_element.h
- A third_party/blink/web_tests/external/wpt/css/css-overflow/scroll-markers/scroll-marker-inert-003.html
Change size: M
Delta: 4 files changed, 81 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Morten Stenshorne
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jun 15, 2026, 8:09:55 AM (12 days ago) Jun 15
to Chromium LUCI CQ, Rune Lillesveen, Morten Stenshorne, chromium...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/60592
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages