media: Remove raw-pointer version of VideoFrame::WrapExternalData [chromium/src : main]

0 views
Skip to first unread message

Eugene Zemtsov (Gerrit)

unread,
Jun 17, 2025, 7:41:17 PMJun 17
to Eugene Zemtsov, Danil Somsikov, Jordan Bayles, Dale Curtis, Sunny Sachanandani, Min Chen, Fabian Sommer, Colin Blundell, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, oshima...@chromium.org, penghu...@chromium.org, video-networking...@google.com
Attention needed from Colin Blundell, Dale Curtis, Danil Somsikov, Fabian Sommer, Jordan Bayles, Min Chen and Sunny Sachanandani

Eugene Zemtsov voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Dale Curtis
  • Danil Somsikov
  • Fabian Sommer
  • Jordan Bayles
  • Min Chen
  • Sunny Sachanandani
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic8c2a0241d85727c6322e184b3662bb1213bf5d8
Gerrit-Change-Number: 6652669
Gerrit-PatchSet: 9
Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
Gerrit-Reviewer: Jordan Bayles <jop...@chromium.org>
Gerrit-Reviewer: Min Chen <mi...@chromium.org>
Gerrit-Reviewer: Sunny Sachanandani <sun...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Min Chen <mi...@chromium.org>
Gerrit-Attention: Danil Somsikov <d...@chromium.org>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Attention: Fabian Sommer <fabian...@chromium.org>
Gerrit-Attention: Jordan Bayles <jop...@chromium.org>
Gerrit-Attention: Sunny Sachanandani <sun...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Jun 2025 23:41:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Jun 18, 2025, 3:16:15 AMJun 18
to Eugene Zemtsov, Colin Blundell, Danil Somsikov, Jordan Bayles, Dale Curtis, Sunny Sachanandani, Min Chen, Fabian Sommer, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, oshima...@chromium.org, penghu...@chromium.org, video-networking...@google.com
Attention needed from Dale Curtis, Danil Somsikov, Eugene Zemtsov, Fabian Sommer, Jordan Bayles, Min Chen and Sunny Sachanandani

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Colin Blundell . resolved

//components lgtm, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
  • Danil Somsikov
  • Eugene Zemtsov
  • Fabian Sommer
  • Jordan Bayles
  • Min Chen
  • Sunny Sachanandani
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic8c2a0241d85727c6322e184b3662bb1213bf5d8
    Gerrit-Change-Number: 6652669
    Gerrit-PatchSet: 10
    Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Reviewer: Jordan Bayles <jop...@chromium.org>
    Gerrit-Reviewer: Min Chen <mi...@chromium.org>
    Gerrit-Reviewer: Sunny Sachanandani <sun...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Min Chen <mi...@chromium.org>
    Gerrit-Attention: Danil Somsikov <d...@chromium.org>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Attention: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Attention: Jordan Bayles <jop...@chromium.org>
    Gerrit-Attention: Sunny Sachanandani <sun...@chromium.org>
    Gerrit-Comment-Date: Wed, 18 Jun 2025 07:15:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Fabian Sommer (Gerrit)

    unread,
    Jun 18, 2025, 5:22:13 AMJun 18
    to Eugene Zemtsov, Colin Blundell, Danil Somsikov, Jordan Bayles, Dale Curtis, Sunny Sachanandani, Min Chen, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, oshima...@chromium.org, penghu...@chromium.org, video-networking...@google.com
    Attention needed from Dale Curtis, Danil Somsikov, Eugene Zemtsov, Jordan Bayles, Min Chen and Sunny Sachanandani

    Fabian Sommer voted and added 1 comment

    Votes added by Fabian Sommer

    Code-Review+1

    1 comment

    Patchset-level comments
    Fabian Sommer . resolved

    pepper LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dale Curtis
    • Danil Somsikov
    • Eugene Zemtsov
    Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Attention: Jordan Bayles <jop...@chromium.org>
    Gerrit-Attention: Sunny Sachanandani <sun...@chromium.org>
    Gerrit-Comment-Date: Wed, 18 Jun 2025 09:21:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Dale Curtis (Gerrit)

    unread,
    Jun 18, 2025, 12:27:40 PMJun 18
    to Eugene Zemtsov, Fabian Sommer, Colin Blundell, Danil Somsikov, Jordan Bayles, Sunny Sachanandani, Min Chen, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, oshima...@chromium.org, penghu...@chromium.org, video-networking...@google.com
    Attention needed from Danil Somsikov, Eugene Zemtsov, Jordan Bayles, Min Chen and Sunny Sachanandani

    Dale Curtis voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Attention: Jordan Bayles <jop...@chromium.org>
    Gerrit-Attention: Sunny Sachanandani <sun...@chromium.org>
    Gerrit-Comment-Date: Wed, 18 Jun 2025 16:27:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Eugene Zemtsov (Gerrit)

    unread,
    Jun 18, 2025, 1:55:51 PMJun 18
    to Eugene Zemtsov, Dale Curtis, Fabian Sommer, Colin Blundell, Danil Somsikov, Jordan Bayles, Min Chen, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, oshima...@chromium.org, penghu...@chromium.org, video-networking...@google.com
    Attention needed from Danil Somsikov, Eugene Zemtsov, Jordan Bayles and Min Chen

    Eugene Zemtsov removed Sunny Sachanandani from this change

    Deleted Reviewers:
    • Sunny Sachanandani
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Danil Somsikov
    • Eugene Zemtsov
    • Jordan Bayles
    • Min Chen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: deleteReviewer
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic8c2a0241d85727c6322e184b3662bb1213bf5d8
    Gerrit-Change-Number: 6652669
    Gerrit-PatchSet: 10
    Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Reviewer: Jordan Bayles <jop...@chromium.org>
    Gerrit-Reviewer: Min Chen <mi...@chromium.org>
    satisfied_requirement
    open
    diffy

    Eugene Zemtsov (Gerrit)

    unread,
    Jun 18, 2025, 1:57:11 PMJun 18
    to Eugene Zemtsov, Danil Somsikov, Dale Curtis, Fabian Sommer, Colin Blundell, Jordan Bayles, Min Chen, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, oshima...@chromium.org, penghu...@chromium.org, video-networking...@google.com
    Attention needed from Eugene Zemtsov, Jordan Bayles and Min Chen

    Eugene Zemtsov removed Danil Somsikov from this change

    Deleted Reviewers:
    • Danil Somsikov
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eugene Zemtsov
    • Jordan Bayles
    • Min Chen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: deleteReviewer
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic8c2a0241d85727c6322e184b3662bb1213bf5d8
    Gerrit-Change-Number: 6652669
    Gerrit-PatchSet: 10
    Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Reviewer: Jordan Bayles <jop...@chromium.org>
    Gerrit-Reviewer: Min Chen <mi...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Min Chen <mi...@chromium.org>
    satisfied_requirement
    open
    diffy

    Andrey Kosyakov (Gerrit)

    unread,
    Jun 18, 2025, 3:36:29 PMJun 18
    to Eugene Zemtsov, Dale Curtis, Fabian Sommer, Colin Blundell, Jordan Bayles, Min Chen, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, oshima...@chromium.org, penghu...@chromium.org, video-networking...@google.com
    Attention needed from Eugene Zemtsov, Jordan Bayles and Min Chen

    Andrey Kosyakov voted and added 1 comment

    Votes added by Andrey Kosyakov

    Code-Review+1

    1 comment

    Patchset-level comments
    Andrey Kosyakov . resolved

    devtools/ rslgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eugene Zemtsov
    • Jordan Bayles
    • Min Chen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic8c2a0241d85727c6322e184b3662bb1213bf5d8
    Gerrit-Change-Number: 6652669
    Gerrit-PatchSet: 10
    Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Reviewer: Jordan Bayles <jop...@chromium.org>
    Gerrit-Reviewer: Min Chen <mi...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Min Chen <mi...@chromium.org>
    Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Attention: Jordan Bayles <jop...@chromium.org>
    Gerrit-Comment-Date: Wed, 18 Jun 2025 19:36:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    James Cook (Gerrit)

    unread,
    Jun 18, 2025, 3:45:16 PMJun 18
    to Eugene Zemtsov, Andrey Kosyakov, Dale Curtis, Fabian Sommer, Colin Blundell, Jordan Bayles, Min Chen, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, oshima...@chromium.org, penghu...@chromium.org, video-networking...@google.com
    Attention needed from Eugene Zemtsov, Jordan Bayles and Min Chen

    James Cook voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eugene Zemtsov
    • Jordan Bayles
    • Min Chen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic8c2a0241d85727c6322e184b3662bb1213bf5d8
    Gerrit-Change-Number: 6652669
    Gerrit-PatchSet: 10
    Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Jordan Bayles <jop...@chromium.org>
    Gerrit-Reviewer: Min Chen <mi...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Min Chen <mi...@chromium.org>
    Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Attention: Jordan Bayles <jop...@chromium.org>
    Gerrit-Comment-Date: Wed, 18 Jun 2025 19:45:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Eugene Zemtsov (Gerrit)

    unread,
    Jun 18, 2025, 3:47:18 PMJun 18
    to Eugene Zemtsov, James Cook, Andrey Kosyakov, Dale Curtis, Fabian Sommer, Colin Blundell, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, oshima...@chromium.org, penghu...@chromium.org, video-networking...@google.com

    Eugene Zemtsov voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic8c2a0241d85727c6322e184b3662bb1213bf5d8
    Gerrit-Change-Number: 6652669
    Gerrit-PatchSet: 10
    Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Comment-Date: Wed, 18 Jun 2025 19:47:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Min Chen (Gerrit)

    unread,
    Jun 18, 2025, 3:47:22 PMJun 18
    to Eugene Zemtsov, James Cook, Andrey Kosyakov, Dale Curtis, Fabian Sommer, Colin Blundell, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, oshima...@chromium.org, penghu...@chromium.org, video-networking...@google.com

    Min Chen voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic8c2a0241d85727c6322e184b3662bb1213bf5d8
    Gerrit-Change-Number: 6652669
    Gerrit-PatchSet: 10
    Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Min Chen <mi...@chromium.org>
    Gerrit-Comment-Date: Wed, 18 Jun 2025 19:47:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 18, 2025, 3:50:21 PMJun 18
    to Eugene Zemtsov, Min Chen, James Cook, Andrey Kosyakov, Dale Curtis, Fabian Sommer, Colin Blundell, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, oshima...@chromium.org, penghu...@chromium.org, video-networking...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    media: Remove raw-pointer version of VideoFrame::WrapExternalData

    Removing

    static scoped_refptr<VideoFrame> VideoFrame::WrapExternalData(
          VideoPixelFormat format,
          const gfx::Size& coded_size,
          const gfx::Rect& visible_rect,
          const gfx::Size& natural_size,
          const uint8_t* data,
          size_t data_size,
          base::TimeDelta timestamp);

    and only leaving

    static scoped_refptr<VideoFrame> VideoFrame::WrapExternalData(
          VideoPixelFormat format,
          const gfx::Size& coded_size,
          const gfx::Rect& visible_rect,
          const gfx::Size& natural_size,
          base::span<const uint8_t> data,
          base::TimeDelta timestamp);
    Bug: 338570700
    Change-Id: Ic8c2a0241d85727c6322e184b3662bb1213bf5d8
    Reviewed-by: James Cook <jame...@chromium.org>
    Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
    Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
    Reviewed-by: Min Chen <mi...@chromium.org>
    Reviewed-by: Dale Curtis <dalec...@chromium.org>
    Reviewed-by: Fabian Sommer <fabian...@chromium.org>
    Reviewed-by: Colin Blundell <blun...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1475799}
    Files:
    • M chromeos/ash/services/recording/recording_service.cc
    • M components/capture_mode/camera_video_frame_handler.cc
    • M components/chromeos_camera/jpeg_encode_accelerator_unittest.cc
    • M components/chromeos_camera/mojo_jpeg_encode_accelerator_service.cc
    • M components/chromeos_camera/mojo_mjpeg_decode_accelerator_service.cc
    • M components/mirroring/service/video_capture_client.cc
    • M components/viz/service/display/renderer_pixeltest.cc
    • M components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl_unittest.cc
    • M components/viz/service/frame_sinks/video_capture/shared_memory_video_frame_pool.cc
    • M content/browser/devtools/devtools_video_consumer.cc
    • M content/browser/media/capture/fake_video_capture_stack.cc
    • M content/renderer/pepper/pepper_video_capture_host.cc
    • M content/renderer/pepper/pepper_video_encoder_host.cc
    • M media/base/video_frame.cc
    • M media/base/video_frame.h
    • M media/base/video_frame_converter.cc
    • M media/base/video_frame_unittest.cc
    • M media/cast/encoding/external_video_encoder.cc
    • M media/gpu/windows/mf_video_processor_accelerator_unittest.cc
    • M media/mojo/clients/mojo_video_encode_accelerator_unittest.cc
    • M media/mojo/test/mojo_video_encode_accelerator_integration_test.cc
    • M media/renderers/paint_canvas_video_renderer_unittest.cc
    • M media/renderers/video_resource_updater_unittest.cc
    • M media/video/video_encode_accelerator_adapter.cc
    • M third_party/blink/renderer/platform/peerconnection/rtc_video_encoder.cc
    Change size: M
    Delta: 25 files changed, 90 insertions(+), 157 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Dale Curtis, +1 by Andrey Kosyakov, +1 by Fabian Sommer, +1 by Colin Blundell, +1 by Min Chen, +1 by James Cook
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic8c2a0241d85727c6322e184b3662bb1213bf5d8
    Gerrit-Change-Number: 6652669
    Gerrit-PatchSet: 11
    Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Min Chen <mi...@chromium.org>
    open
    diffy
    satisfied_requirement

    Chuong Ho (Gerrit)

    unread,
    Jun 20, 2025, 4:37:40 AMJun 20
    to Eugene Zemtsov, Chromium LUCI CQ, Min Chen, James Cook, Andrey Kosyakov, Dale Curtis, Fabian Sommer, Colin Blundell, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, oshima...@chromium.org, penghu...@chromium.org, video-networking...@google.com

    Chuong Ho has created a revert of this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: revert
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages