Add ShapeReferenceBox and start plumbing it to shape interpolation types [chromium/src : main]
0 views
Skip to first unread message
Fredrik Söderquist (Gerrit)
Jul 3, 2026, 5:52:49 AM (3 days ago) Jul 3
to Robert Flack, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Robert Flack
Fredrik Söderquist added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Fredrik Söderquist . resolved
For the general direction (still moving a bit), there's an all-in-one CL at https://chromium-review.googlesource.com/c/chromium/src/+/8035442
Related details
Attention is currently required from:
- Robert Flack
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Ellis (Gerrit)
8:40 AM (6 hours ago) 8:40 AM
to Fredrik Söderquist, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Fredrik Söderquist
Kevin Ellis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kevin Ellis
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
9:18 AM (5 hours ago) 9:18 AM
to Kevin Ellis, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org
Fredrik Söderquist voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:07 AM (4 hours ago) 10:07 AM
to Fredrik Söderquist, Kevin Ellis, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add ShapeReferenceBox and start plumbing it to shape interpolation types
Add a ShapeReferenceBox type that is a "lowest common denominator" of
all the ad-hoc types currently in use to carry the reference box for a
property. A future CL will make the type less lax.
Plumb this new type to CSSBasicShapeInterpolationType,
CSSPathInterpolationType, basic_shape_interpolation_functions and
CSSShapeInterpolationType.
This is a first step towards reducing duplication among the different
basic shape interpolation types. More plumbing of ShapeReferenceBox will
follow.
Bug: 530077400
Change-Id: I1724dcf2994bcc3a776bcbd5e4e0bbd281ab5d4b
Reviewed-by: Kevin Ellis <kev...@chromium.org>
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Cr-Commit-Position: refs/heads/main@{#1657163}
Files:
- M third_party/blink/renderer/core/animation/BUILD.gn
- M third_party/blink/renderer/core/animation/basic_shape_interpolation_functions.cc
- M third_party/blink/renderer/core/animation/basic_shape_interpolation_functions.h
- M third_party/blink/renderer/core/animation/css_basic_shape_interpolation_type.cc
- M third_party/blink/renderer/core/animation/css_path_interpolation_type.cc
- M third_party/blink/renderer/core/animation/css_shape_interpolation_type.cc
- M third_party/blink/renderer/core/animation/css_shape_interpolation_type.h
- M third_party/blink/renderer/core/animation/shape_interpolation_functions.cc
- A third_party/blink/renderer/core/animation/shape_property_functions.h
Change size: L
Delta: 9 files changed, 128 insertions(+), 156 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kevin Ellis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages