Revert "LoAF: Use document character position for inline scripts" [chromium/src : main]
0 views
Skip to first unread message
Rubber Stamper (Gerrit)
Apr 24, 2024, 11:53:13 AMApr 24
to Kevin McNee, AyeAye, Kouhei Ueno, Michal Mocny, Noam Rosenthal, Chromium LUCI CQ, Alexis Menard, Kentaro Hara, chromium...@chromium.org, Olga Gerchikov, Code Review Nudger, Blink W3C Test Autoroller, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org
Attention needed from Kouhei Ueno, Michal Mocny and Noam Rosenthal
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Kouhei Ueno
- Michal Mocny
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin McNee (Gerrit)
Apr 24, 2024, 11:54:24 AMApr 24
to Kevin McNee, Rubber Stamper, AyeAye, Kouhei Ueno, Michal Mocny, Noam Rosenthal, Chromium LUCI CQ, Alexis Menard, Kentaro Hara, chromium...@chromium.org, Olga Gerchikov, Code Review Nudger, Blink W3C Test Autoroller, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org
Attention needed from Kouhei Ueno, Michal Mocny and Noam Rosenthal
Kevin McNee voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Kouhei Ueno
- Michal Mocny
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin McNee (Gerrit)
Apr 24, 2024, 11:55:35 AMApr 24
to Kevin McNee, Rubber Stamper, AyeAye, Kouhei Ueno, Michal Mocny, Noam Rosenthal, Chromium LUCI CQ, Alexis Menard, Kentaro Hara, chromium...@chromium.org, Olga Gerchikov, Code Review Nudger, Blink W3C Test Autoroller, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org
Attention needed from Kouhei Ueno, Michal Mocny and Noam Rosenthal
Kevin McNee voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Blink W3C Test Autoroller (Gerrit)
Apr 24, 2024, 11:56:31 AMApr 24
to Kevin McNee, Kevin McNee, Rubber Stamper, AyeAye, Kouhei Ueno, Michal Mocny, Noam Rosenthal, Chromium LUCI CQ, Alexis Menard, Kentaro Hara, chromium...@chromium.org, Olga Gerchikov, Code Review Nudger, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org
Attention needed from Kouhei Ueno, Michal Mocny and Noam Rosenthal
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/45882.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Chromium LUCI CQ (Gerrit)
Apr 24, 2024, 1:12:07 PMApr 24
to Kevin McNee, Kevin McNee, Rubber Stamper, AyeAye, Kouhei Ueno, Michal Mocny, Noam Rosenthal, Alexis Menard, Kentaro Hara, chromium...@chromium.org, Olga Gerchikov, Code Review Nudger, Blink W3C Test Autoroller, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "LoAF: Use document character position for inline scripts"
This reverts commit af30ee5c327deebfdcfa8830e3ebcb501f9afdf1.
Reason for revert: The WPTs added by this CL are all flaky. e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/119940/overview
Original change's description:
> LoAF: Use document character position for inline scripts
>
> This applies to classic/module script blocks and event content
> attributes.
>
> Bug: 328209286
> Change-Id: Id11e0a9324c529925b11b950d73ed4491410f96d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425010
> Reviewed-by: Michal Mocny <mmo...@chromium.org>
> Reviewed-by: Kouhei Ueno <kou...@chromium.org>
> Commit-Queue: Noam Rosenthal <nrose...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1291353}
Bug: 328209286
Change-Id: Ie42a62fb30a998fa3c8792dcc8bad770b86ff05c
Commit-Queue: Kevin McNee <mc...@chromium.org>
Owners-Override: Kevin McNee <mc...@google.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291953}
Files:
- M third_party/blink/renderer/bindings/core/v8/js_event_handler_for_content_attribute.h
- M third_party/blink/renderer/core/frame/animation_frame_timing_monitor.cc
- M third_party/blink/renderer/core/html/parser/html_document_parser.cc
- M third_party/blink/renderer/core/probe/core_probes.pidl
- M third_party/blink/renderer/core/script/classic_script.cc
- M third_party/blink/renderer/core/script/module_script.cc
- M third_party/blink/renderer/platform/wtf/text/text_position.cc
- M third_party/blink/renderer/platform/wtf/text/text_position.h
- D third_party/blink/web_tests/external/wpt/long-animation-frame/tentative/loaf-source-location-inline-classic-script.html
- D third_party/blink/web_tests/external/wpt/long-animation-frame/tentative/loaf-source-location-inline-event-listener.html
- D third_party/blink/web_tests/external/wpt/long-animation-frame/tentative/loaf-source-location-inline-module-script.html
- M third_party/blink/web_tests/external/wpt/long-animation-frame/tentative/resources/utils.js
Change size: M
Delta: 12 files changed, 17 insertions(+), 113 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 24, 2024, 1:51:48 PMApr 24
to Chromium LUCI CQ, Kevin McNee, Kevin McNee, Rubber Stamper, AyeAye, Kouhei Ueno, Michal Mocny, Noam Rosenthal, Alexis Menard, Kentaro Hara, chromium...@chromium.org, Olga Gerchikov, Code Review Nudger, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/45882
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages