Rename Time::kTimeTToMicrosecondsOffset to kMicrosecondsFromWindowsToUnixEpoch [chromium/src : main]

0 views
Skip to first unread message

Helmut Januschka (Gerrit)

unread,
Jul 5, 2026, 5:19:11 PM (19 hours ago) Jul 5
to Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, blink-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, feature-v...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, storage...@chromium.org, vasilii+watchlis...@chromium.org, wfh+...@chromium.org
Attention needed from Gabriel Charette

Helmut Januschka added 1 comment

Open in Gerrit

Related details

Attention is currently required from:
  • Gabriel Charette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5d9edbbc461d8c0ee9cb991e4239d9a1674e343f
Gerrit-Change-Number: 8040566
Gerrit-PatchSet: 1
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Gabriel Charette <g...@chromium.org>
Gerrit-Comment-Date: Sun, 05 Jul 2026 21:18:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Gabriel Charette (Gerrit)

unread,
9:35 AM (2 hours ago) 9:35 AM
to Helmut Januschka, Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, blink-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, feature-v...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, storage...@chromium.org, vasilii+watchlis...@chromium.org, wfh+...@chromium.org
Attention needed from Helmut Januschka

Gabriel Charette voted

Code-Review+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5d9edbbc461d8c0ee9cb991e4239d9a1674e343f
Gerrit-Change-Number: 8040566
Gerrit-PatchSet: 1
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 13:35:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
10:32 AM (1 hour ago) 10:32 AM
to Helmut Januschka, Gabriel Charette, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, blink-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, feature-v...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, storage...@chromium.org, vasilii+watchlis...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Rename Time::kTimeTToMicrosecondsOffset to kMicrosecondsFromWindowsToUnixEpoch
Bug: 355423207
Change-Id: I5d9edbbc461d8c0ee9cb991e4239d9a1674e343f
Reviewed-by: Gabriel Charette <g...@chromium.org>
Commit-Queue: Gabriel Charette <g...@chromium.org>
Owners-Override: Gabriel Charette <g...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1657178}
Files:
  • M ash/webui/print_management/resources/print_job_entry.ts
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/time/time.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/time/time.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/time/time_conversion_posix.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/time/time_now_posix.cc
  • M base/time/time.cc
  • M base/time/time.h
  • M base/time/time_conversion_posix.cc
  • M base/time/time_exploded_icu.cc
  • M base/time/time_now_posix.cc
  • M base/time/time_unittest.cc
  • M chrome/browser/resources/browsing_topics/browsing_topics_internals.ts
  • M chrome/browser/resources/contextual_tasks/internals/app.ts
  • M chrome/browser/resources/location_internals/diagnose_info_view.ts
  • M chrome/browser/resources/on_device_internals/event_log.ts
  • M chrome/browser/resources/suggest_internals/request.ts
  • M chrome/test/data/webui/location_internals/location_internals_test.ts
  • M components/optimization_guide/optimization_guide_internals/resources/optimization_guide_internals.ts
  • M components/password_manager/core/browser/password_store/login_database.cc
  • M content/browser/resources/indexed_db/mojo_utils.ts
  • M content/browser/resources/quota/quota_internals.ts
  • M content/browser/resources/traces_internals/trace_report.ts
  • M content/browser/resources/webxr_internals/time_util.ts
  • M third_party/blink/web_tests/wpt_internal/geolocation-api/resources/geolocation-mock.js
  • M tools/gdb/gdb_chrome.py
Change size: M
Delta: 25 files changed, 62 insertions(+), 48 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Gabriel Charette
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5d9edbbc461d8c0ee9cb991e4239d9a1674e343f
Gerrit-Change-Number: 8040566
Gerrit-PatchSet: 2
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages