Add blob URL partitioning self-fetch test and refactor helper functions [chromium/src : main]
0 views
Skip to first unread message
Andrew Williams (Gerrit)
Oct 9, 2025, 5:40:22 PMOct 9
to Ari Chivukula, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Ari Chivukula
Andrew Williams added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Andrew Williams . resolved
Hi Ari, PTAL. I plan to land this in conjunction with a corresponding spec change. Thanks!
Related details
Attention is currently required from:
- Ari Chivukula
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
Oct 10, 2025, 8:56:36 AMOct 10
to Andrew Williams, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Andrew Williams
Ari Chivukula voted and added 2 comments![]( "Open in Gerrit")
Votes added by Ari Chivukula
| Code-Review | +1 |
2 comments
Patchset-level comments
Ari Chivukula . resolved
it's a little hard to follow the test pathways but I think this makes sense? It would be nice if things were named/commented a bit more but that's a prior issue
File third_party/blink/web_tests/external/wpt/FileAPI/BlobURL/cross-partition-self-fetch.https.html
Line 34, Patchset 3 (Latest):
const text = await response.text();Ari Chivukula . unresolved
is this meant to be used or is the idea that it would throw if not possible?
Related details
Attention is currently required from:
- Andrew Williams
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
4:44 PM (6 hours ago) 4:44 PM
to Andrew Williams, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Andrew Williams
Ari Chivukula voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ari Chivukula
| Code-Review | +1 |
1 comment
File third_party/blink/web_tests/external/wpt/FileAPI/BlobURL/cross-partition-self-fetch.https.html
is this meant to be used or is the idea that it would throw if not possible?
Ari Chivukula
Done
Related details
Attention is currently required from:
- Andrew Williams
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Williams (Gerrit)
6:38 PM (4 hours ago) 6:38 PM
to Koji Ishii, Ari Chivukula, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Koji Ishii
Andrew Williams added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Ari Chivukula . resolved
it's a little hard to follow the test pathways but I think this makes sense? It would be nice if things were named/commented a bit more but that's a prior issue
Andrew Williams
yeah :/ I'll aim to add some documentation for these existing tests
File-level comment, Patchset 4 (Latest):
Andrew Williams . resolved
Thanks Ari!
Koji, PTAL at third_party/blink/web_tests/VirtualTestSuites
Related details
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages