webnn: update tolerance definitions for QDQ subgraph tests [chromium/src : main]

0 views
Skip to first unread message

Feng Dai (Gerrit)

unread,
Jun 17, 2025, 1:08:36 AMJun 17
to Reilly Grant, ningxin hu, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Reilly Grant and ningxin hu

Feng Dai added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Feng Dai . resolved

PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Reilly Grant
  • ningxin hu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
Gerrit-Change-Number: 6623500
Gerrit-PatchSet: 7
Gerrit-Owner: Feng Dai <feng...@intel.com>
Gerrit-Reviewer: Feng Dai <feng...@intel.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-CC: Junwei Fu <junw...@intel.com>
Gerrit-CC: Wei4 Wang <wei4...@intel.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: ningxin hu <ningx...@intel.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 05:07:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

ningxin hu (Gerrit)

unread,
Jun 17, 2025, 9:17:02 AMJun 17
to Feng Dai, Reilly Grant, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Feng Dai and Reilly Grant

ningxin hu added 1 comment

Commit Message
Line 8, Patchset 7 (Latest):
ningxin hu . unresolved

Could you please share a longer description of this change? Including why this change is made, description of previous
behavior and newly introduced differences etc., See guideline: https://chromium.googlesource.com/chromium/src/+/main/docs/contributing.md#uploading-a-change-for-review

Open in Gerrit

Related details

Attention is currently required from:
  • Feng Dai
  • Reilly Grant
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
Gerrit-Change-Number: 6623500
Gerrit-PatchSet: 7
Gerrit-Owner: Feng Dai <feng...@intel.com>
Gerrit-Reviewer: Feng Dai <feng...@intel.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-CC: Junwei Fu <junw...@intel.com>
Gerrit-CC: Wei4 Wang <wei4...@intel.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Feng Dai <feng...@intel.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 13:16:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Reilly Grant (Gerrit)

unread,
Jun 17, 2025, 7:53:40 PMJun 17
to Feng Dai, Reilly Grant, ningxin hu, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Feng Dai

Reilly Grant added 1 comment

Commit Message
ningxin hu . unresolved

Could you please share a longer description of this change? Including why this change is made, description of previous
behavior and newly introduced differences etc., See guideline: https://chromium.googlesource.com/chromium/src/+/main/docs/contributing.md#uploading-a-change-for-review

Reilly Grant

+1, very confused why a change which claims to be fixing tolerances for the QDQ subgraph tests is updating the tolerances for a bunch of other tests, but not the QDQ subgraph one.

Open in Gerrit

Related details

Attention is currently required from:
  • Feng Dai
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
Gerrit-Change-Number: 6623500
Gerrit-PatchSet: 7
Gerrit-Owner: Feng Dai <feng...@intel.com>
Gerrit-Reviewer: Feng Dai <feng...@intel.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-CC: Junwei Fu <junw...@intel.com>
Gerrit-CC: Wei4 Wang <wei4...@intel.com>
Gerrit-Attention: Feng Dai <feng...@intel.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 23:53:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ningxin hu <ningx...@intel.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Dwayne Robinson (Gerrit)

unread,
Jun 17, 2025, 8:03:29 PMJun 17
to Feng Dai, Reilly Grant, ningxin hu, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Feng Dai

Dwayne Robinson added 4 comments

Patchset-level comments
Dwayne Robinson . resolved

👀

File third_party/blink/web_tests/external/wpt/webnn/resources/utils.js
Line 1158, Patchset 7 (Latest): tolerance = sizes.length ?
Dwayne Robinson . unresolved

Just for clarity (so others understand what's going on), I'd name it `elementCount`. e.g.

```
const elementCount = sizes.reduce(
    (accumulator, currentValue) => accumulator * currentValue, 1);
tolerance = elementCount;
```
Line 1166, Patchset 7 (Latest): reduceL2: tolerance * 2 + 1,
Dwayne Robinson . unresolved

I think I wrote +2 last time for the wrapping sqrt.

Line 1173, Patchset 7 (Latest): reduceSum: tolerance * 2,
Dwayne Robinson . unresolved

Addition should incur no more loss than multiplication, and reduceProduct takes the elementCount directly. Did you mean to put the `* 2` onto `reduceSumSquare` instead?

Gerrit-Comment-Date: Wed, 18 Jun 2025 00:03:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Feng Dai (Gerrit)

unread,
Jun 17, 2025, 11:36:25 PMJun 17
to Reilly Grant, ningxin hu, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Dwayne Robinson, Reilly Grant and ningxin hu

Feng Dai added 5 comments

Patchset-level comments
File-level comment, Patchset 14 (Latest):
Feng Dai . resolved

Updated. Please take another look, thanks!

Commit Message
Line 8, Patchset 7:
ningxin hu . resolved

Could you please share a longer description of this change? Including why this change is made, description of previous
behavior and newly introduced differences etc., See guideline: https://chromium.googlesource.com/chromium/src/+/main/docs/contributing.md#uploading-a-change-for-review

Reilly Grant

+1, very confused why a change which claims to be fixing tolerances for the QDQ subgraph tests is updating the tolerances for a bunch of other tests, but not the QDQ subgraph one.

Feng Dai

Could you please share a longer description of this change?

@ningx...@intel.com Added this description, please take another look, thanks!

...is updating the tolerances for a bunch of other tests, but not the QDQ subgraph one

@rei...@chromium.org, The tolerance for the QDQ subgraph tests is defined in `getPrecisionTolerance()` method of utils.js.

And the updated bunch of other tests are for these operators fused in QDQ subgraph, they are using `getPrecisionTolerance()` instead which also provides tolerance for the graph of single operator.

File third_party/blink/web_tests/external/wpt/webnn/resources/utils.js
Line 1158, Patchset 7: tolerance = sizes.length ?
Dwayne Robinson . resolved

Just for clarity (so others understand what's going on), I'd name it `elementCount`. e.g.

```
const elementCount = sizes.reduce(
    (accumulator, currentValue) => accumulator * currentValue, 1);
tolerance = elementCount;
```
Feng Dai

👍

Line 1166, Patchset 7: reduceL2: tolerance * 2 + 1,
Dwayne Robinson . resolved

I think I wrote +2 last time for the wrapping sqrt.

Feng Dai

👍

Line 1173, Patchset 7: reduceSum: tolerance * 2,
Dwayne Robinson . resolved

Addition should incur no more loss than multiplication, and reduceProduct takes the elementCount directly. Did you mean to put the `* 2` onto `reduceSumSquare` instead?

Feng Dai

Good catch! 👍
Sorry, I missed put these two tolerance values for `reduceSum` and `reduceSumSquare`, they need swap each other.

Open in Gerrit

Related details

Attention is currently required from:
  • Dwayne Robinson
  • Reilly Grant
  • ningxin hu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
Gerrit-Change-Number: 6623500
Gerrit-PatchSet: 14
Gerrit-Owner: Feng Dai <feng...@intel.com>
Gerrit-Reviewer: Feng Dai <feng...@intel.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-CC: Junwei Fu <junw...@intel.com>
Gerrit-CC: Wei4 Wang <wei4...@intel.com>
Gerrit-Attention: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-Attention: ningxin hu <ningx...@intel.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Jun 2025 03:36:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dwayne Robinson <dwa...@microsoft.com>
Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>
Comment-In-Reply-To: ningxin hu <ningx...@intel.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Reilly Grant (Gerrit)

unread,
Jun 18, 2025, 8:45:01 PMJun 18
to Feng Dai, Reilly Grant, ningxin hu, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Dwayne Robinson, Feng Dai and ningxin hu

Reilly Grant voted and added 2 comments

Votes added by Reilly Grant

Code-Review+1

2 comments

Patchset-level comments
File third_party/blink/web_tests/external/wpt/webnn/resources/utils.js
Line 1138, Patchset 16 (Latest): // others reduction operators
Reilly Grant . unresolved
```suggestion
        // other reduction operators
```
Open in Gerrit

Related details

Attention is currently required from:
  • Dwayne Robinson
  • Feng Dai
  • ningxin hu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
    Gerrit-Change-Number: 6623500
    Gerrit-PatchSet: 16
    Gerrit-Owner: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Junwei Fu <junw...@intel.com>
    Gerrit-CC: Wei4 Wang <wei4...@intel.com>
    Gerrit-Attention: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-Attention: ningxin hu <ningx...@intel.com>
    Gerrit-Attention: Feng Dai <feng...@intel.com>
    Gerrit-Comment-Date: Thu, 19 Jun 2025 00:44:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    ningxin hu (Gerrit)

    unread,
    Jun 18, 2025, 9:23:06 PMJun 18
    to Feng Dai, Reilly Grant, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Dwayne Robinson and Feng Dai

    ningxin hu voted and added 4 comments

    Votes added by ningxin hu

    Code-Review+1

    4 comments

    Patchset-level comments
    ningxin hu . resolved

    lgtm with nits

    Commit Message
    Line 10, Patchset 16 (Latest):the cumulative tolerance of each operators of subgraph by modifying
    ningxin hu . unresolved

    ```suggestion
    the cumulative tolerance of each operator of a subgraph by modifying
    ```

    Line 13, Patchset 16 (Latest):And this CL is also update a bunch of other tests of these operators
    ningxin hu . unresolved

    ```suggestion
    And this CL also updates a bunch of other tests of operators that are
    ```

    Line 18, Patchset 16 (Latest):operator, with this CL the updated tolerance definitions is equal to the
    ningxin hu . unresolved

    ```suggestion
    operator. With this CL, the updated tolerance definitions is equal to the
    ```

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dwayne Robinson
    • Feng Dai
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
    Gerrit-Change-Number: 6623500
    Gerrit-PatchSet: 16
    Gerrit-Owner: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Junwei Fu <junw...@intel.com>
    Gerrit-CC: Wei4 Wang <wei4...@intel.com>
    Gerrit-Attention: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-Attention: Feng Dai <feng...@intel.com>
    Gerrit-Comment-Date: Thu, 19 Jun 2025 01:22:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    ningxin hu (Gerrit)

    unread,
    Jun 19, 2025, 2:00:10 AMJun 19
    to Feng Dai, Reilly Grant, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Dwayne Robinson, Feng Dai and Reilly Grant

    ningxin hu voted and added 5 comments

    Votes added by ningxin hu

    Code-Review+1

    5 comments

    Patchset-level comments
    ningxin hu . resolved

    lgtm

    Commit Message
    Line 10, Patchset 16:the cumulative tolerance of each operators of subgraph by modifying
    ningxin hu . resolved

    ```suggestion
    the cumulative tolerance of each operator of a subgraph by modifying
    ```

    ningxin hu

    Acknowledged

    Line 13, Patchset 16:And this CL is also update a bunch of other tests of these operators
    ningxin hu . resolved

    ```suggestion
    And this CL also updates a bunch of other tests of operators that are
    ```

    ningxin hu

    Acknowledged

    Line 18, Patchset 16:operator, with this CL the updated tolerance definitions is equal to the
    ningxin hu . resolved

    ```suggestion
    operator. With this CL, the updated tolerance definitions is equal to the
    ```

    ningxin hu

    Acknowledged

    File third_party/blink/web_tests/external/wpt/webnn/resources/utils.js
    Line 1138, Patchset 16: // others reduction operators
    Reilly Grant . resolved
    ```suggestion
            // other reduction operators
    ```
    ningxin hu

    This is done in the latest PS.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dwayne Robinson
    • Feng Dai
    • Reilly Grant
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
    Gerrit-Change-Number: 6623500
    Gerrit-PatchSet: 18
    Gerrit-Owner: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Junwei Fu <junw...@intel.com>
    Gerrit-CC: Wei4 Wang <wei4...@intel.com>
    Gerrit-Attention: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-Attention: Reilly Grant <rei...@chromium.org>
    Gerrit-Attention: Feng Dai <feng...@intel.com>
    Gerrit-Comment-Date: Thu, 19 Jun 2025 06:00:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: ningxin hu <ningx...@intel.com>
    Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Feng Dai (Gerrit)

    unread,
    Jun 20, 2025, 2:02:03 AMJun 20
    to ningxin hu, Reilly Grant, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Dwayne Robinson and Reilly Grant

    Feng Dai added 1 comment

    Patchset-level comments
    Feng Dai . resolved

    Thanks Ningxin for helping review latest changes!👍
    Current I fail to rebasline expected results after fixing conflict of rebase latest code, I meet "Access blocked: Authorization Error" when executing rebasline command.
    Any suggestions? Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dwayne Robinson
    • Reilly Grant
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
    Gerrit-Change-Number: 6623500
    Gerrit-PatchSet: 18
    Gerrit-Owner: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Junwei Fu <junw...@intel.com>
    Gerrit-CC: Wei4 Wang <wei4...@intel.com>
    Gerrit-Attention: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-Attention: Reilly Grant <rei...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Jun 2025 06:01:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dwayne Robinson (Gerrit)

    unread,
    Jun 20, 2025, 5:25:18 PMJun 20
    to Feng Dai, ningxin hu, Reilly Grant, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Feng Dai, Reilly Grant and ningxin hu

    Dwayne Robinson added 1 comment

    Patchset-level comments
    File-level comment, Patchset 21 (Latest):
    Dwayne Robinson . resolved

    👍

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Feng Dai
    • Reilly Grant
    • ningxin hu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
    Gerrit-Change-Number: 6623500
    Gerrit-PatchSet: 21
    Gerrit-Owner: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Junwei Fu <junw...@intel.com>
    Gerrit-CC: Wei4 Wang <wei4...@intel.com>
    Gerrit-Attention: ningxin hu <ningx...@intel.com>
    Gerrit-Attention: Reilly Grant <rei...@chromium.org>
    Gerrit-Attention: Feng Dai <feng...@intel.com>
    Gerrit-Comment-Date: Fri, 20 Jun 2025 21:25:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Reilly Grant (Gerrit)

    unread,
    Jun 20, 2025, 6:25:46 PMJun 20
    to Feng Dai, ningxin hu, Reilly Grant, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Feng Dai and ningxin hu

    Reilly Grant added 1 comment

    Patchset-level comments
    Feng Dai . resolved

    Thanks Ningxin for helping review latest changes!👍
    Current I fail to rebasline expected results after fixing conflict of rebase latest code, I meet "Access blocked: Authorization Error" when executing rebasline command.
    Any suggestions? Thanks!

    Reilly Grant

    Try running `git cl creds-check` to make sure you have all the necessary credentials set up.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Feng Dai
    • ningxin hu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
    Gerrit-Change-Number: 6623500
    Gerrit-PatchSet: 21
    Gerrit-Owner: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Junwei Fu <junw...@intel.com>
    Gerrit-CC: Wei4 Wang <wei4...@intel.com>
    Gerrit-Attention: ningxin hu <ningx...@intel.com>
    Gerrit-Attention: Feng Dai <feng...@intel.com>
    Gerrit-Comment-Date: Fri, 20 Jun 2025 22:25:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Feng Dai <feng...@intel.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Reilly Grant (Gerrit)

    unread,
    Jun 20, 2025, 6:26:58 PMJun 20
    to Feng Dai, Reilly Grant, ningxin hu, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Feng Dai and ningxin hu

    Reilly Grant voted and added 1 comment

    Votes added by Reilly Grant

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 21 (Latest):
    Reilly Grant . resolved

    LGTM (once the rebaseline gets added)

    Gerrit-Comment-Date: Fri, 20 Jun 2025 22:26:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Feng Dai (Gerrit)

    unread,
    Jun 23, 2025, 4:59:57 AMJun 23
    to Reilly Grant, ningxin hu, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from ningxin hu

    Feng Dai added 1 comment

    Patchset-level comments
    Feng Dai . resolved

    Thanks Ningxin for helping review latest changes!👍
    Current I fail to rebasline expected results after fixing conflict of rebase latest code, I meet "Access blocked: Authorization Error" when executing rebasline command.
    Any suggestions? Thanks!

    Reilly Grant

    Try running `git cl creds-check` to make sure you have all the necessary credentials set up.

    Feng Dai

    Thanks Reilly! 👍
    I tried this command, and I also switched to another develop machine, the problem still blocks me.
    I'm ongoing to find how to fix it.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • ningxin hu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
    Gerrit-Change-Number: 6623500
    Gerrit-PatchSet: 24
    Gerrit-Owner: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Junwei Fu <junw...@intel.com>
    Gerrit-CC: Wei4 Wang <wei4...@intel.com>
    Gerrit-Attention: ningxin hu <ningx...@intel.com>
    Gerrit-Comment-Date: Mon, 23 Jun 2025 08:59:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>
    Comment-In-Reply-To: Feng Dai <feng...@intel.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Feng Dai (Gerrit)

    unread,
    Jun 25, 2025, 3:38:12 AM (13 days ago) Jun 25
    to Reilly Grant, ningxin hu, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Reilly Grant and ningxin hu

    Feng Dai added 1 comment

    Patchset-level comments
    File-level comment, Patchset 25 (Latest):
    Feng Dai . resolved

    I've updated expected test results. Now all trybots run Pass.
    @rei...@chromium.org and @ningx...@intel.com, please take another look, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Reilly Grant
    • ningxin hu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
    Gerrit-Change-Number: 6623500
    Gerrit-PatchSet: 25
    Gerrit-Owner: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Junwei Fu <junw...@intel.com>
    Gerrit-CC: Wei4 Wang <wei4...@intel.com>
    Gerrit-Attention: Reilly Grant <rei...@chromium.org>
    Gerrit-Attention: ningxin hu <ningx...@intel.com>
    Gerrit-Comment-Date: Wed, 25 Jun 2025 07:37:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Reilly Grant (Gerrit)

    unread,
    Jun 25, 2025, 1:52:37 PM (13 days ago) Jun 25
    to Feng Dai, Reilly Grant, ningxin hu, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Feng Dai and ningxin hu

    Reilly Grant voted and added 1 comment

    Votes added by Reilly Grant

    Code-Review+1

    1 comment

    Patchset-level comments
    Reilly Grant . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Feng Dai
    • ningxin hu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
    Gerrit-Change-Number: 6623500
    Gerrit-PatchSet: 25
    Gerrit-Owner: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Feng Dai <feng...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Junwei Fu <junw...@intel.com>
    Gerrit-CC: Wei4 Wang <wei4...@intel.com>
    Gerrit-Attention: ningxin hu <ningx...@intel.com>
    Gerrit-Attention: Feng Dai <feng...@intel.com>
    Gerrit-Comment-Date: Wed, 25 Jun 2025 17:52:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    ningxin hu (Gerrit)

    unread,
    Jul 2, 2025, 4:30:40 AM (6 days ago) Jul 2
    to Feng Dai, Reilly Grant, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Feng Dai

    ningxin hu voted and added 1 comment

    Votes added by ningxin hu

    Code-Review+1

    1 comment

    Patchset-level comments
    ningxin hu . resolved

    lgtm

    Related details

    Attention is currently required from:
    • Feng Dai
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
      Gerrit-Change-Number: 6623500
      Gerrit-PatchSet: 25
      Gerrit-Owner: Feng Dai <feng...@intel.com>
      Gerrit-Reviewer: Feng Dai <feng...@intel.com>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
      Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
      Gerrit-CC: Junwei Fu <junw...@intel.com>
      Gerrit-CC: Wei4 Wang <wei4...@intel.com>
      Gerrit-Attention: Feng Dai <feng...@intel.com>
      Gerrit-Comment-Date: Wed, 02 Jul 2025 08:30:26 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Feng Dai (Gerrit)

      unread,
      Jul 2, 2025, 4:35:20 AM (6 days ago) Jul 2
      to ningxin hu, Reilly Grant, Dwayne Robinson, Junwei Fu, Wei4 Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

      Feng Dai voted and added 1 comment

      Votes added by Feng Dai

      Auto-Submit+1
      Commit-Queue+2

      1 comment

      Patchset-level comments
      Feng Dai . resolved

      Thanks all for your review! I'm going to submit this CL.

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
      Gerrit-Change-Number: 6623500
      Gerrit-PatchSet: 25
      Gerrit-Owner: Feng Dai <feng...@intel.com>
      Gerrit-Reviewer: Feng Dai <feng...@intel.com>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
      Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
      Gerrit-CC: Junwei Fu <junw...@intel.com>
      Gerrit-CC: Wei4 Wang <wei4...@intel.com>
      Gerrit-Comment-Date: Wed, 02 Jul 2025 08:35:02 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jul 2, 2025, 5:50:03 AM (6 days ago) Jul 2
      to Feng Dai, ningxin hu, Reilly Grant, Dwayne Robinson, Junwei Fu, Wei4 Wang, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      webnn: update tolerance definitions for QDQ subgraph tests

      This CL is to update tolerance definitions of QDQ subgraph tests using

      the cumulative tolerance of each operator of a subgraph by modifying
      `getPrecisionTolerance()` method of `utils.js` help file [1].


      And this CL also updates a bunch of other tests of operators that are
      fused in QDQ subgraph using `getPrecisionTolerance()` or
      `getZeroULPTolerance()` methods instead.

      For example, the previous tolerance definitions of this "quantized tanh"
      QDQ subgraph test [2] is equal to tolerance definitions of `tanh`

      operator. With this CL, the updated tolerance definitions is equal to the
      accumulated sum of tolerance of `quantizeLinear` on layer1, tolerance of
      `dequantizeLinear` on layer2, tolerance of `tanh` on layer3, tolerance
      of `quantizeLinear` on layer4, and tolerance of `dequantizeLinear` on
      layer5.

      ```
                    input
                      |
                [quantizeLinear]  // layer1
                      |
               [dequantizeLinear] // layer2
                      |
                    [tanh]        // layer3
                      |
                [quantizeLinear]  // layer4
                      |
               [dequantizeLinear] // layer5
                      |
                    output
      ```

      [1]https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/webnn/resources/utils.js;l=39
      [2]https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.js;l=1761
      Bug: 419386749
      Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
      Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
      Auto-Submit: Feng Dai <feng...@intel.com>
      Commit-Queue: Feng Dai <feng...@intel.com>
      Reviewed-by: Reilly Grant <rei...@chromium.org>
      Reviewed-by: ningxin hu <ningx...@intel.com>
      Cr-Commit-Position: refs/heads/main@{#1481483}
      Files:
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/add.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/arg_min_max.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/concat.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/equal.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/expand.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/gather.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/gatherElements.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/gatherND.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/greater.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/greater_or_equal.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/identity.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/lesser.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/lesser_or_equal.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/logical_and.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/logical_not.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/logical_or.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/logical_xor.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/max.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/min.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/mul.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/not_equal.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/pad.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/quantizeLinear.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/reduce_l1.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/reduce_l2.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/reduce_log_sum.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/reduce_log_sum_exp.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/reduce_max.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/reduce_mean.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/reduce_min.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/reduce_product.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/reduce_sum.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/reduce_sum_square.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/resample2d.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/reshape.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/reverse.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/scatterElements.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/scatterND.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/slice.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/split.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/sub.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/tanh.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/tile.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/transpose.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/resources/utils.js
      • D third_party/blink/web_tests/flag-specific/enable-skia-graphite/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.serviceworker_cpu-expected.txt
      • D third_party/blink/web_tests/flag-specific/enable-skia-graphite/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.sharedworker_cpu-expected.txt
      • D third_party/blink/web_tests/flag-specific/enable-skia-graphite/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.worker_cpu-expected.txt
      • D third_party/blink/web_tests/flag-specific/enable-skia-graphite/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any_cpu-expected.txt
      • D third_party/blink/web_tests/platform/mac-mac14-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.serviceworker_cpu-expected.txt
      • D third_party/blink/web_tests/platform/mac-mac14-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.sharedworker_cpu-expected.txt
      • D third_party/blink/web_tests/platform/mac-mac14-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.worker_cpu-expected.txt
      • D third_party/blink/web_tests/platform/mac-mac14-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any_cpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.serviceworker_cpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.sharedworker_cpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.worker_cpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any_cpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/reduce_l2.https.any_cpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-npu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.serviceworker_npu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-npu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.sharedworker_npu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-npu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.worker_npu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-npu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any_npu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-npu/external/wpt/webnn/conformance_tests/reduce_l2.https.any_npu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-with-gpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.serviceworker_gpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-with-gpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.sharedworker_gpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-with-gpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any.worker_gpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-with-gpu/external/wpt/webnn/conformance_tests/qdq_subgraph.https.any_gpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-with-gpu/external/wpt/webnn/conformance_tests/reduce_l2.https.any_gpu-expected.txt
      Change size: L
      Delta: 68 files changed, 182 insertions(+), 457 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by ningxin hu, +1 by Reilly Grant
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
      Gerrit-Change-Number: 6623500
      Gerrit-PatchSet: 26
      Gerrit-Owner: Feng Dai <feng...@intel.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Feng Dai <feng...@intel.com>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
      open
      diffy
      satisfied_requirement

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Jul 2, 2025, 4:14:31 PM (6 days ago) Jul 2
      to Feng Dai, Chromium LUCI CQ, ningxin hu, Reilly Grant, Dwayne Robinson, Junwei Fu, Wei4 Wang, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

      Message from Blink W3C Test Autoroller

      The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/53535

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie5bbbda6d0b151a7b230af1e5485e623d1211633
      Gerrit-Change-Number: 6623500
      Gerrit-PatchSet: 26
      Gerrit-Owner: Feng Dai <feng...@intel.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Feng Dai <feng...@intel.com>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
      Gerrit-CC: Junwei Fu <junw...@intel.com>
      Gerrit-CC: Wei4 Wang <wei4...@intel.com>
      Gerrit-Comment-Date: Wed, 02 Jul 2025 20:14:26 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages