Reland "Multicast support in Direct Sockets #3" [chromium/src : main]

0 views
Skip to first unread message

Andrew Rayskiy (Gerrit)

unread,
Sep 15, 2025, 5:56:24 AM9/15/25
to Vlad Krot, AyeAye, Maks Orlovich, Kinuko Yasuda, Chromium LUCI CQ, Kentaro Hara, Chromium Metrics Reviews, chromium...@chromium.org, Chromium IPC Reviews, devtools...@chromium.org, AI Code Reviewer, Simon Hangl, Raphael Kubo da Costa, ipc-securi...@chromium.org, rmcelra...@chromium.org, network-ser...@chromium.org, blink-...@chromium.org, fenced-fra...@chromium.org
Attention needed from Kinuko Yasuda, Maks Orlovich and Vlad Krot

Andrew Rayskiy voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kinuko Yasuda
  • Maks Orlovich
  • Vlad Krot
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic43edf8d7e4062f1655984d1bb38cab56208a62a
Gerrit-Change-Number: 6935875
Gerrit-PatchSet: 6
Gerrit-Owner: Vlad Krot <vk...@google.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kinuko Yasuda <kin...@chromium.org>
Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
Gerrit-Reviewer: Vlad Krot <vk...@google.com>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Maks Orlovich <morl...@chromium.org>
Gerrit-Attention: Vlad Krot <vk...@google.com>
Gerrit-Attention: Kinuko Yasuda <kin...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Sep 2025 09:56:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kinuko Yasuda (Gerrit)

unread,
Sep 15, 2025, 6:06:50 AM9/15/25
to Vlad Krot, Andrew Rayskiy, AyeAye, Maks Orlovich, Chromium LUCI CQ, Kentaro Hara, Chromium Metrics Reviews, chromium...@chromium.org, Chromium IPC Reviews, devtools...@chromium.org, AI Code Reviewer, Simon Hangl, Raphael Kubo da Costa, ipc-securi...@chromium.org, rmcelra...@chromium.org, network-ser...@chromium.org, blink-...@chromium.org, fenced-fra...@chromium.org
Attention needed from Maks Orlovich and Vlad Krot

Kinuko Yasuda voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Maks Orlovich
  • Vlad Krot
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Gerrit-Comment-Date: Mon, 15 Sep 2025 10:06:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Vlad Krot (Gerrit)

unread,
Sep 15, 2025, 6:07:03 AM9/15/25
to Kinuko Yasuda, Andrew Rayskiy, AyeAye, Maks Orlovich, Chromium LUCI CQ, Kentaro Hara, Chromium Metrics Reviews, chromium...@chromium.org, Chromium IPC Reviews, devtools...@chromium.org, AI Code Reviewer, Simon Hangl, Raphael Kubo da Costa, ipc-securi...@chromium.org, rmcelra...@chromium.org, network-ser...@chromium.org, blink-...@chromium.org, fenced-fra...@chromium.org
Attention needed from Maks Orlovich

Vlad Krot voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Maks Orlovich
Gerrit-Comment-Date: Mon, 15 Sep 2025 10:06:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 15, 2025, 6:10:23 AM9/15/25
to Vlad Krot, Kinuko Yasuda, Andrew Rayskiy, AyeAye, Maks Orlovich, Kentaro Hara, Chromium Metrics Reviews, chromium...@chromium.org, Chromium IPC Reviews, devtools...@chromium.org, AI Code Reviewer, Simon Hangl, Raphael Kubo da Costa, ipc-securi...@chromium.org, rmcelra...@chromium.org, network-ser...@chromium.org, blink-...@chromium.org, fenced-fra...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Reland "Multicast support in Direct Sockets #3"

Test tests of UDP packets exchange fail on MacOS. For now just disable
the tests, and fix it later. The bug for it -
https://buganizer.corp.google.com/issues/443716695

This is a reland of commit 933bd079d139e312c3f32bf26a013c05066ad285

Original change's description:
> Multicast support in Direct Sockets #3
>
> This CL adds mojo interfaces for MulticastController and its
> implementation with respective browser tests and unit tests.
>
> I have added Low-Coverage-Reason because the pipeline complains about
> low coverage for udp_socket.cc and network_context.cc. For udp_socket.cc
> there's no unit tests as for now. And both tests are tested with browser
> tests. I believe my change was trivial for both of those classes.
>
> Explainer
> https://github.com/explainers-by-googlers/multicast-in-direct-sockets.
> Chrome Entry https://chromestatus.com/feature/5073740211814400 Intent to
> prototype
> https://groups.google.com/a/chromium.org/g/blink-dev/c/ADV4FZtN4nE
>
> Bug: 398934282
> Low-Coverage-Reason: TRIVIAL_CHANGE
> Change-Id: I1d8236bc2f495d6c4bf09ac995d5f1ab03f78f5c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6905387
> Reviewed-by: Andrew Rayskiy <green...@google.com>
> Reviewed-by: Maks Orlovich <morl...@chromium.org>
> Reviewed-by: Kinuko Yasuda <kin...@chromium.org>
> Commit-Queue: Vlad Krot <vk...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1513631}
Bug: 398934282
Change-Id: Ic43edf8d7e4062f1655984d1bb38cab56208a62a
Include-Ci-Only-Tests: chromium.mac:mac15-x64-rel-tests|browser_tests
Reviewed-by: Andrew Rayskiy <green...@google.com>
Reviewed-by: Kinuko Yasuda <kin...@chromium.org>
Commit-Queue: Vlad Krot <vk...@google.com>
Cr-Commit-Position: refs/heads/main@{#1515406}
Files:
  • M chrome/browser/direct_sockets/direct_sockets_apitest.cc
  • M content/browser/direct_sockets/direct_sockets_service_impl.cc
  • M content/browser/direct_sockets/direct_sockets_test_utils.cc
  • M content/browser/direct_sockets/direct_sockets_test_utils.h
  • M content/browser/direct_sockets/direct_sockets_udp_browsertest.cc
  • M content/test/data/direct_sockets/udp.js
  • M services/network/network_context.cc
  • M services/network/network_context.h
  • M services/network/network_context_unittest.cc
  • M services/network/public/mojom/network_context.mojom
  • M services/network/public/mojom/restricted_udp_socket.mojom
  • M services/network/restricted_udp_socket.cc
  • M services/network/restricted_udp_socket.h
  • M services/network/socket_factory.cc
  • M services/network/socket_factory.h
  • M services/network/test/test_network_context.h
  • M services/network/test/test_restricted_udp_socket.cc
  • M services/network/test/test_restricted_udp_socket.h
  • M third_party/blink/renderer/modules/direct_sockets/BUILD.gn
  • M third_party/blink/renderer/modules/direct_sockets/multicast_controller.cc
  • M third_party/blink/renderer/modules/direct_sockets/multicast_controller.h
  • A third_party/blink/renderer/modules/direct_sockets/multicast_controller_unittest.cc
  • M third_party/blink/renderer/modules/direct_sockets/udp_readable_stream_wrapper_unittest.cc
  • M third_party/blink/renderer/modules/direct_sockets/udp_socket.cc
  • M third_party/blink/renderer/modules/direct_sockets/udp_writable_stream_wrapper_unittest.cc
Change size: XL
Delta: 25 files changed, 1028 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Andrew Rayskiy, +1 by Kinuko Yasuda
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic43edf8d7e4062f1655984d1bb38cab56208a62a
Gerrit-Change-Number: 6935875
Gerrit-PatchSet: 7
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages