Run non-integer height popup tests sequentially [chromium/src : main]
1 view
Skip to first unread message
Hyowon Kim (Gerrit)
May 20, 2026, 11:42:52 PM (5 days ago) May 20
to David Baron, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from David Baron
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
May 21, 2026, 4:00:17 PM (4 days ago) May 21
to Hyowon Kim, David Baron, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hyowon Kim
David Baron added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/html/browsers/the-window-object/open-close/open-features-non-integer-height.html
Line 56, Patchset 2 (Latest):
function sequentialPromiseTest(testFunction, name) {David Baron . unresolved
Do you need `sequentialPromiseTest`? `promise_test` is already sequential; see https://web-platform-tests.org/writing-tests/testharness-api.html#promise-tests .
Related details
Attention is currently required from:
- Hyowon Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyowon Kim (Gerrit)
May 25, 2026, 10:53:38 PM (4 hours ago) May 25
to David Baron, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from David Baron
Hyowon Kim added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/html/browsers/the-window-object/open-close/open-features-non-integer-height.html
Line 56, Patchset 2:
function sequentialPromiseTest(testFunction, name) {David Baron . unresolved
Do you need `sequentialPromiseTest`? `promise_test` is already sequential; see https://web-platform-tests.org/writing-tests/testharness-api.html#promise-tests .
Hyowon Kim
Right, using promise_test directly makes the popup open/close subtests run sequentially.
Related details
Attention is currently required from:
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages