TextOffsetMapping: skip out-of-flow descendants in InlineContents [chromium/src : main]
0 views
Skip to first unread message
Peng Zhou (Gerrit)
Sep 23, 2025, 10:10:40 AM (2 days ago) Sep 23
to Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Sep 23, 2025, 8:16:17 PM (2 days ago) Sep 23
to Peng Zhou, Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Peng Zhou
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Peng Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peng Zhou (Gerrit)
Sep 23, 2025, 10:36:02 PM (2 days ago) Sep 23
to Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Peng Zhou voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 23, 2025, 11:44:09 PM (2 days ago) Sep 23
to Peng Zhou, Kent Tamura, AyeAye, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
TextOffsetMapping: skip out-of-flow descendants in InlineContents
`CreateInlineContentsFromBlockFlow` should exclude out-of-flow objects
(floated elements or elements with `position:absolute/fixed`) that are
DOM descendants of `target`, since they do not participate in the inline
formatting context. Consider this case:
<div class="container">
<span style="position: absolute;"></span>
<span><span style="display: block"> </span></span>
</div>
<div contenteditable="true">T|est</div>
When deleting the "T", the SpellChecker is triggered. SpellChecker calls
`PreviousWordPosition`, which could lead to an infinite loop if
out-of-flow elements are included. This patch ensures they are skipped
when computing `InlineContents`.
Bug: 443752821
Change-Id: Id6724005fdfcf0d9e5b1498c8648c6516aad504d
Reviewed-by: Kent Tamura <tk...@chromium.org>
Commit-Queue: Peng Zhou <zhoupe...@bytedance.com>
Cr-Commit-Position: refs/heads/main@{#1519761}
Files:
- M third_party/blink/renderer/core/editing/text_offset_mapping.cc
- M third_party/blink/renderer/core/editing/visible_units_word_test.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: M
Delta: 3 files changed, 65 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kent Tamura
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages