[M136] Relax the COI requirement for Direct Sockets in workers [chromium/src : refs/branch-heads/7103]

0 views

Skip to first unread message

Simon Hangl (Gerrit)

unread,

Apr 14, 2025, 9:49:08 AM4/14/25

to Andrew Rayskiy, AyeAye, blink-...@chromium.org, rmcelra...@chromium.org

Attention needed from Andrew Rayskiy

Simon Hangl voted and added 1 comment

Votes added by Simon Hangl

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Simon Hangl . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Andrew Rayskiy

Submit Requirements:

Code-Review
Lint

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Andrew Rayskiy (Gerrit)

unread,

Apr 15, 2025, 5:17:58 AM4/15/25

to Simon Hangl, AyeAye, blink-...@chromium.org, rmcelra...@chromium.org

Andrew Rayskiy voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
Lint

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 15, 2025, 6:23:18 AM4/15/25

to Andrew Rayskiy, Simon Hangl, AyeAye, blink-...@chromium.org, rmcelra...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[M136] Relax the COI requirement for Direct Sockets in workers

Chrome Apps are allowed to use Direct Sockets even without specifying
cross-origin isolation in the manifest; for this reason we have to
check just the permissions-policy feature and not the entire capability.

(cherry picked from commit b4d6430bfe1dc166187fa975d3e8146f5bbc3cef)

Bug: 409051839

Change-Id: Ie1d90879d5fc954c3f749b1dcba1d11dd4bdd1f0

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6434162

Commit-Queue: Andrew Rayskiy <green...@google.com>

Auto-Submit: Andrew Rayskiy <green...@google.com>

Reviewed-by: Simon Hangl <sim...@google.com>

Cr-Original-Commit-Position: refs/heads/main@{#1443405}

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6448695

Cr-Commit-Position: refs/branch-heads/7103@{#927}

Cr-Branched-From: e09430c64983fc906f37a9f7e6806275c9b67b86-refs/heads/main@{#1440670}

Files:

M chrome/browser/direct_sockets/direct_sockets_apitest.cc
M third_party/blink/renderer/modules/direct_sockets/socket.cc

Change size: M

Delta: 2 files changed, 80 insertions(+), 7 deletions(-)

Branch: refs/branch-heads/7103

Submit Requirements:

Code-Review: +1 by Simon Hangl

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages