Ship CSSSafePrintableInset. Flip the flag to stable. [chromium/src : main]

0 views
Skip to first unread message

Morten Stenshorne (Gerrit)

unread,
5:22 AM (9 hours ago) 5:22 AM
to Ian Kilpatrick, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Ian Kilpatrick

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7cab07a906cfc6e07f7c9616bdeee3710459dd39
Gerrit-Change-Number: 7816234
Gerrit-PatchSet: 2
Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Comment-Date: Tue, 05 May 2026 09:22:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Bratell (Gerrit)

unread,
8:00 AM (6 hours ago) 8:00 AM
to Morten Stenshorne, Philip Jägenstedt, Ian Kilpatrick, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Ian Kilpatrick, Morten Stenshorne and Philip Jägenstedt

Daniel Bratell voted and added 1 comment

Votes added by Daniel Bratell

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Daniel Bratell . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
  • Morten Stenshorne
  • Philip Jägenstedt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7cab07a906cfc6e07f7c9616bdeee3710459dd39
Gerrit-Change-Number: 7816234
Gerrit-PatchSet: 2
Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Daniel Bratell <brat...@gmail.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
Gerrit-Comment-Date: Tue, 05 May 2026 11:59:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
9:25 AM (5 hours ago) 9:25 AM
to Morten Stenshorne, Daniel Bratell, Philip Jägenstedt, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Morten Stenshorne and Philip Jägenstedt

Ian Kilpatrick voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
  • Philip Jägenstedt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7cab07a906cfc6e07f7c9616bdeee3710459dd39
Gerrit-Change-Number: 7816234
Gerrit-PatchSet: 2
Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Daniel Bratell <brat...@gmail.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
Gerrit-Comment-Date: Tue, 05 May 2026 13:25:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Morten Stenshorne (Gerrit)

unread,
11:30 AM (3 hours ago) 11:30 AM
to Ian Kilpatrick, Daniel Bratell, Philip Jägenstedt, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Philip Jägenstedt

Morten Stenshorne voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Philip Jägenstedt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7cab07a906cfc6e07f7c9616bdeee3710459dd39
Gerrit-Change-Number: 7816234
Gerrit-PatchSet: 2
Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Daniel Bratell <brat...@gmail.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Comment-Date: Tue, 05 May 2026 15:29:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
1:03 PM (1 hour ago) 1:03 PM
to Morten Stenshorne, Ian Kilpatrick, Daniel Bratell, Philip Jägenstedt, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Ship CSSSafePrintableInset. Flip the flag to stable.

This enables support for the @page (and page margin boxes) descriptor
`page-margin-safety` [1].

[1] https://drafts.csswg.org/css-page-3/#page-margin-safety
Bug: 368070327
Change-Id: I7cab07a906cfc6e07f7c9616bdeee3710459dd39
Reviewed-by: Daniel Bratell <brat...@gmail.com>
Commit-Queue: Morten Stenshorne <mste...@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1625525}
Files:
  • M third_party/blink/renderer/platform/runtime_enabled_features.json5
  • M third_party/blink/web_tests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
  • M third_party/blink/web_tests/virtual/stable/webexposed/css-property-listing-expected.txt
Change size: XS
Delta: 3 files changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ian Kilpatrick, +1 by Daniel Bratell
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7cab07a906cfc6e07f7c9616bdeee3710459dd39
Gerrit-Change-Number: 7816234
Gerrit-PatchSet: 3
Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages