Editing: Allow selection to extend into open <details> content [chromium/src : main]
Vishwa Kalubowila (Gerrit)
Vishwa Kalubowila added 1 comment![]( "Open in Gerrit")
Hi, could you take a look when you get a chance?
This addresses [crbug.com/477613569](https://issues.chromium.org/477613569): text inside an open <details> couldn't be selected when the drag started outside it. The fix makes <slot> transparent for its assigned light-DOM content in IsEditingBoundary, so it's no longer treated as an editing boundary — fallback/non-slotted shadow content is unchanged. I've also added a new test and updated the existing ShadowDistributedNodesWithEditingBoundary expectations accordingly.
Happy to make any changes, thanks for reviewing!
Related details
- David Baron
- Stephen Chenney
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stephen Chenney (Gerrit)
Stephen Chenney added 1 comment![]( "Open in Gerrit")
Switching to tkent@ to review. I'm concerned that I don't know about the rules for selection across shadow boundaries, and I'm also unsure what the selection range returned in JS should contain. I would like to that tested too in a WPT.
Related details
- David Baron
- Kent Tamura
- Vishwa Kalubowila
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
David Baron added 1 comment![]( "Open in Gerrit")
I'd like to hear what tkent (or another editor expert) thinks first.
Related details
- Kent Tamura
- Vishwa Kalubowila
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Kent Tamura added 1 comment![]( "Open in Gerrit")
The behavior change sounds reasonable.
Please add a runtime flag to runtime_enabled_features.json5, and enable the new behavior only if the flag is enabled.
https://chromium.googlesource.com/chromium/src/+/main/docs/flag_guarding_guidelines.md
Related details
- Vishwa Kalubowila
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vishwa Kalubowila (Gerrit)
Vishwa Kalubowila added 1 comment![]( "Open in Gerrit")
The behavior change sounds reasonable.
Please add a runtime flag to runtime_enabled_features.json5, and enable the new behavior only if the flag is enabled.
https://chromium.googlesource.com/chromium/src/+/main/docs/flag_guarding_guidelines.md
Done.Added SelectionEditingBoundarySlottedContent flag (status: "stable") for Finch rollout/kill-switch support.
Guarded the <slot> logic behind the flag to preserve previous behavior when disabled. Added tests covering both flag-on and flag-off paths.
Related details
- Kent Tamura
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Kent Tamura voted and added 2 comments![]( "Open in Gerrit")
Votes added by Kent Tamura
| Code-Review | +1 |
2 comments
Element* host = GetDocument().getElementById(AtomicString("host"));nit: ➜ `GetElementById("host")`
Element* foo = GetDocument().getElementById(AtomicString("foo"));
Element* bar = GetDocument().getElementById(AtomicString("bar"));Ditto.
Related details
- Vishwa Kalubowila
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |