Fix type confusion in iteration accumulation and align order [chromium/src : main]
0 views
Skip to first unread message
Robert Flack (Gerrit)
Jul 3, 2026, 11:34:41 AM (3 days ago) Jul 3
to Kevin Ellis, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Ellis
Robert Flack added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Robert Flack . resolved
Kevin, can you take a look? This fixes a few issues with iteration accumulate, namely ensures that types are coerced to be compatible if possible, and otherwise we fail, and that we accumulate in the expected order (verified that it matches firefox).
Related details
Attention is currently required from:
- Kevin Ellis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Ellis (Gerrit)
8:28 AM (7 hours ago) 8:28 AM
to Robert Flack, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Robert Flack
Kevin Ellis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kevin Ellis
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Robert Flack
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
8:40 AM (7 hours ago) 8:40 AM
to Robert Flack, Kevin Ellis, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Robert Flack
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/61087.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Robert Flack
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Flack (Gerrit)
9:56 AM (6 hours ago) 9:56 AM
to Blink W3C Test Autoroller, Kevin Ellis, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Robert Flack voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:10 AM (5 hours ago) 11:10 AM
to Robert Flack, Blink W3C Test Autoroller, Kevin Ellis, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix type confusion in iteration accumulation and align order
InvalidatableInterpolation::ApplyIterationAccumulation previously
checked only that the start and end keyframes shared the same
InterpolationType. However, even within the same InterpolationType, the
underlying concrete InterpolableValue subclasses or structures can be
incompatible (e.g., clip rect lists vs. empty auto lists, or
incompatible calc-size bases).
This patch makes the following fixes and improvements:
1. Uses MaybeMergeSingles inside ApplyIterationAccumulation to deeply
verify and coerce value compatibility before accumulating.
Per Web Animations Level 2, if values cannot be merged or
accumulated, accumulation is skipped and the current iteration
value is used.
2. Computes V_final * N + V_current, aligning the left-to-right AST
operand order for complex math expressions with other
browser implementations.
Bug: 495021566
Change-Id: I272fa8ac7a7b6b627d18ad7d43553ccb306436eb
Reviewed-by: Kevin Ellis <kev...@chromium.org>
Commit-Queue: Robert Flack <fla...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1657198}
Files:
- M third_party/blink/renderer/core/animation/invalidatable_interpolation.cc
- M third_party/blink/web_tests/external/wpt/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation.html
Change size: M
Delta: 2 files changed, 108 insertions(+), 29 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kevin Ellis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
12:06 PM (4 hours ago) 12:06 PM
to Chromium LUCI CQ, Robert Flack, Kevin Ellis, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/61087
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages