[wip] Make NodeRareData fields part of the SparseVector. [chromium/src : main]

0 views
Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,
Jan 15, 2026, 4:21:01 AM (2 days ago) Jan 15
to chromium...@chromium.org, Xida Chen, Menard, Alexis, blink-re...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Steinar H Gunderson has uploaded the change for review

Commit message

[wip] Make NodeRareData fields part of the SparseVector.

Now that NodeRareData is in the same class as the SparseVector,
we can move its six plain member fields into the vector.
Reduces the size of ElementRareDataVector from 64 to 40 bytes
(although of course there will be more allocations needed when
something actually sets these fields).
Change-Id: I888bf4dcb89c1b377372a52ca5f981d34acf7074

Change diff


Change information

Files:
  • M third_party/blink/renderer/core/dom/element_rare_data_vector.cc
  • M third_party/blink/renderer/core/dom/element_rare_data_vector.h
  • M third_party/blink/renderer/core/dom/flat_tree_node_data.cc
  • M third_party/blink/renderer/core/dom/flat_tree_node_data.h
  • M third_party/blink/renderer/core/dom/node_lists_node_data.cc
  • M third_party/blink/renderer/core/dom/node_lists_node_data.h
Change size: M
Delta: 6 files changed, 81 insertions(+), 79 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I888bf4dcb89c1b377372a52ca5f981d34acf7074
Gerrit-Change-Number: 7482793
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Jan 16, 2026, 12:29:57 PM (yesterday) Jan 16
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Xida Chen, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Steinar H Gunderson

Joey Arhar voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I888bf4dcb89c1b377372a52ca5f981d34acf7074
Gerrit-Change-Number: 7482793
Gerrit-PatchSet: 3
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Fri, 16 Jan 2026 17:29:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Jan 16, 2026, 7:43:50 PM (17 hours ago) Jan 16
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Xida Chen, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Steinar H Gunderson

Joey Arhar voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I888bf4dcb89c1b377372a52ca5f981d34acf7074
Gerrit-Change-Number: 7482793
Gerrit-PatchSet: 4
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Sat, 17 Jan 2026 00:43:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages