Remove SystemFallbackEmojiVSSupport runtime enabled feature [chromium/src : main]

0 views
Skip to first unread message

Dominik Röttsches (Gerrit)

unread,
10:05 AM (4 hours ago) 10:05 AM
to Munira Tursunova, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org
Attention needed from Munira Tursunova

Dominik Röttsches voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Munira Tursunova
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibf643698034325534ac87611451353566fca735d
Gerrit-Change-Number: 8034928
Gerrit-PatchSet: 1
Gerrit-Owner: Dominik Röttsches <dr...@chromium.org>
Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
Gerrit-Reviewer: Munira Tursunova <moo...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Munira Tursunova <moo...@google.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 14:04:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Munira Tursunova (Gerrit)

unread,
10:14 AM (4 hours ago) 10:14 AM
to Dominik Röttsches, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org
Attention needed from Dominik Röttsches

Munira Tursunova added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Munira Tursunova . unresolved

What is the status of Chrome shipping it's own emoji font? If I recall correctly it's a workaround that should be removed once we ship our own emoji fonts or when we have sufficient system emoji font coverage.

Open in Gerrit

Related details

Attention is currently required from:
  • Dominik Röttsches
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibf643698034325534ac87611451353566fca735d
    Gerrit-Change-Number: 8034928
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Munira Tursunova <moo...@google.com>
    Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Comment-Date: Mon, 06 Jul 2026 14:13:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dominik Röttsches (Gerrit)

    unread,
    11:55 AM (3 hours ago) 11:55 AM
    to Chromium LUCI CQ, Munira Tursunova, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org
    Attention needed from Munira Tursunova

    Dominik Röttsches added 2 comments

    Patchset-level comments
    Munira Tursunova . unresolved

    What is the status of Chrome shipping it's own emoji font? If I recall correctly it's a workaround that should be removed once we ship our own emoji fonts or when we have sufficient system emoji font coverage.

    Dominik Röttsches

    Yes, I saw the comment in `runtime_enabled_features.json`. Bundled emoji fonts are work in progress, I hope I get to finishing it. It's true that we do not need to emulate cmap format 14 support for system emoji fonts if we had our own. Added a TODO comment in HarfBuzzFace. I suggest to remove the flag, we do not need to keep it around for reminding us of TODOs in this case, as this is the configuration we're shipping for 20+ releases.

    File third_party/blink/renderer/platform/fonts/shaping/harfbuzz_face.cc
    Line 117, Patchset 2 (Latest):
    Dominik Röttsches . unresolved

    Comment added to hopefully cover the commend removed from the `runtime_enabled_features.json` file.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Munira Tursunova
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibf643698034325534ac87611451353566fca735d
    Gerrit-Change-Number: 8034928
    Gerrit-PatchSet: 2
    Gerrit-Owner: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Munira Tursunova <moo...@google.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Munira Tursunova <moo...@google.com>
    Gerrit-Comment-Date: Mon, 06 Jul 2026 15:55:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Munira Tursunova <moo...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Munira Tursunova (Gerrit)

    unread,
    12:26 PM (2 hours ago) 12:26 PM
    to Dominik Röttsches, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org
    Attention needed from Dominik Röttsches

    Munira Tursunova voted and added 2 comments

    Votes added by Munira Tursunova

    Code-Review+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 1:
    Munira Tursunova . resolved

    What is the status of Chrome shipping it's own emoji font? If I recall correctly it's a workaround that should be removed once we ship our own emoji fonts or when we have sufficient system emoji font coverage.

    Dominik Röttsches

    Yes, I saw the comment in `runtime_enabled_features.json`. Bundled emoji fonts are work in progress, I hope I get to finishing it. It's true that we do not need to emulate cmap format 14 support for system emoji fonts if we had our own. Added a TODO comment in HarfBuzzFace. I suggest to remove the flag, we do not need to keep it around for reminding us of TODOs in this case, as this is the configuration we're shipping for 20+ releases.

    Munira Tursunova

    sounds good, thanks for adding the comment.

    File third_party/blink/renderer/platform/fonts/shaping/harfbuzz_face.cc
    Dominik Röttsches . resolved

    Comment added to hopefully cover the commend removed from the `runtime_enabled_features.json` file.

    Munira Tursunova

    👍

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dominik Röttsches
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ibf643698034325534ac87611451353566fca735d
      Gerrit-Change-Number: 8034928
      Gerrit-PatchSet: 2
      Gerrit-Owner: Dominik Röttsches <dr...@chromium.org>
      Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
      Gerrit-Reviewer: Munira Tursunova <moo...@google.com>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
      Gerrit-Comment-Date: Mon, 06 Jul 2026 16:25:52 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Dominik Röttsches <dr...@chromium.org>
      Comment-In-Reply-To: Munira Tursunova <moo...@google.com>
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages