Dai, Feng (Gerrit)

unread,

Mar 26, 2026, 5:47:05 AMMar 26

to Reilly Grant, Hu, Ningxin, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Dai, Feng

Dai, Feng voted and added 1 comment

Votes added by Dai, Feng

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Dai, Feng . resolved

@rei...@chromium.org @ningx...@intel.com PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:

Dai, Feng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hu, Ningxin (Gerrit)

unread,

Mar 30, 2026, 9:30:31 PM (14 days ago) Mar 30

to Dai, Feng, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Dai, Feng and Reilly Grant

Hu, Ningxin added 2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Hu, Ningxin . unresolved

Please update the baseline.

File third_party/blink/web_tests/external/wpt/webnn/validation_tests/no-overflow-in-convolutions.https.any.js

Line 34, Patchset 2 (Latest):

  try {
    const graph = await builder.build({output});
    assert_unreached('build should have thrown');
  } catch (e) {
    assert_equals(e.name, 'NotSupportedError');
  }

Hu, Ningxin . unresolved

Can we use `promise_rejects_dom`?

Open in Gerrit

Related details

Attention is currently required from:

Dai, Feng
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dai, Feng (Gerrit)

unread,

Apr 8, 2026, 9:33:39 PM (5 days ago) Apr 8

to AyeAye, Reilly Grant, Hu, Ningxin, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Hu, Ningxin and Reilly Grant

Dai, Feng added 2 comments

Patchset-level comments

File-level comment, Patchset 2:

Hu, Ningxin . resolved

Please update the baseline.

Dai, Feng

Done, thanks!

File third_party/blink/web_tests/external/wpt/webnn/validation_tests/no-overflow-in-convolutions.https.any.js

Line 34, Patchset 2: try {


    const graph = await builder.build({output});
    assert_unreached('build should have thrown');
  } catch (e) {
    assert_equals(e.name, 'NotSupportedError');
  }

Hu, Ningxin . resolved

Can we use `promise_rejects_dom`?

Dai, Feng

Yes.
Updated by using `promise_rejects_dom` assertion in new commit, @ningx...@intel.com please take another look, thanks!

Open in Gerrit

Related details

Attention is currently required from:

Hu, Ningxin
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hu, Ningxin (Gerrit)

unread,

Apr 9, 2026, 3:25:01 AM (4 days ago) Apr 9

to Dai, Feng, AyeAye, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Dai, Feng and Reilly Grant

Hu, Ningxin voted and added 1 comment

Votes added by Hu, Ningxin

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Hu, Ningxin . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Dai, Feng
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reilly Grant (Gerrit)

unread,

Apr 10, 2026, 5:06:53 PM (3 days ago) Apr 10

to Dai, Feng, Hu, Ningxin, android-bu...@system.gserviceaccount.com, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Dai, Feng

Reilly Grant added 2 comments

File third_party/blink/web_tests/platform/mac-mac15-arm64/external/wpt/webnn/validation_tests/no-overflow-in-convolutions.https.any_cpu-expected.txt

Line 3, Patchset 7 (Latest):

  promise_rejects_dom: function "function() { throw e; }" threw object "UnknownError: Failed to execute 'build' on 'MLGraphBuilder': Model allocation error." that is not a DOMException NotSupportedError: property "code" is equal to 0, expected 9

Reilly Grant . unresolved

Please file an issue to track this failure.

File third_party/blink/web_tests/platform/win/external/wpt/webnn/validation_tests/no-overflow-in-convolutions.https.any_cpu-expected.txt

Line 3, Patchset 7 (Latest): assert_unreached: Should have rejected: undefined Reached unreachable code

Reilly Grant . unresolved

Can you take a look at this failure? If it's expected can you improve the message so it's easier to understand the issue?

Open in Gerrit

Related details

Attention is currently required from:

Dai, Feng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dai, Feng (Gerrit)

unread,

5:26 AM (4 hours ago) 5:26 AM

to Hu, Ningxin, android-bu...@system.gserviceaccount.com, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Reilly Grant

Dai, Feng added 2 comments

File third_party/blink/web_tests/platform/mac-mac15-arm64/external/wpt/webnn/validation_tests/no-overflow-in-convolutions.https.any_cpu-expected.txt

Line 3, Patchset 7 (Latest):

  promise_rejects_dom: function "function() { throw e; }" threw object "UnknownError: Failed to execute 'build' on 'MLGraphBuilder': Model allocation error." that is not a DOMException NotSupportedError: property "code" is equal to 0, expected 9

Reilly Grant . resolved

Please file an issue to track this failure.

Dai, Feng

Done by [issue#502048284](https://issues.chromium.org/issues/502048284).

File third_party/blink/web_tests/platform/win/external/wpt/webnn/validation_tests/no-overflow-in-convolutions.https.any_cpu-expected.txt

Line 3, Patchset 7 (Latest): assert_unreached: Should have rejected: undefined Reached unreachable code

Reilly Grant . unresolved

Can you take a look at this failure? If it's expected can you improve the message so it's easier to understand the issue?

Dai, Feng

@rei...@chromium.org This error message was threw out by `promise_rejects_dom()` function of `testharness.js`.

Open in Gerrit

Related details

Attention is currently required from:

Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

webnn: add tests to ensure no overflow in convolutions graph [chromium/src : main]

Dai, Feng (Gerrit)

Dai, Feng voted and added 1 comment

Votes added by Dai, Feng

1 comment

Related details

Hu, Ningxin (Gerrit)

Hu, Ningxin added 2 comments

Related details

Dai, Feng (Gerrit)

Dai, Feng added 2 comments

Related details

Hu, Ningxin (Gerrit)

Hu, Ningxin voted and added 1 comment

Votes added by Hu, Ningxin

1 comment

Related details

Reilly Grant (Gerrit)

Reilly Grant added 2 comments

Related details

Dai, Feng (Gerrit)

Dai, Feng added 2 comments

Related details