[ServiceWorker] Add disconnect fallback mechanism for RaceNetworkRequest [chromium/src : main]
0 views
Skip to first unread message
Shunya Shishido (Gerrit)
Jul 23, 2026, 9:00:00 PM (3 days ago) Jul 23
to Yoshisato Yanagisawa, Chromium LUCI CQ, chromium...@chromium.org, Hiroki Nakagawa, blink-re...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Yoshisato Yanagisawa
Shunya Shishido added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yoshisato Yanagisawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoshisato Yanagisawa (Gerrit)
Jul 26, 2026, 7:37:57 PM (9 hours ago) Jul 26
to Shunya Shishido, Chromium LUCI CQ, chromium...@chromium.org, Hiroki Nakagawa, blink-re...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Shunya Shishido
Yoshisato Yanagisawa added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Shunya Shishido . resolved
Can you fix the bot failure?
Attention is currently required from:
- Shunya Shishido
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shunya Shishido (Gerrit)
Jul 26, 2026, 9:58:12 PM (6 hours ago) Jul 26
to Yoshisato Yanagisawa, Chromium LUCI CQ, chromium...@chromium.org, Hiroki Nakagawa, blink-re...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Yoshisato Yanagisawa
Shunya Shishido voted and added 4 comments![]( "Open in Gerrit")
Votes added by Shunya Shishido
| Code-Review | +1 |
4 comments
Patchset-level comments
Commit Message
Line 9, Patchset 16 (Latest):
Add feature flag kServiceWorkerRaceNetworkRequestFallbackOnDisconnect and
Mojo pipe disconnect handler in ServiceWorkerGlobalScope to handle
network pipe disconnections gracefully.Shunya Shishido . unresolved
Please format.
File third_party/blink/common/features.cc
Line 2242, Patchset 16 (Latest):
BASE_FEATURE(kServiceWorkerRaceNetworkRequestFallbackOnDisconnect,Shunya Shishido . unresolved
Please fix this WARNING reported by autoreview issue finding: Consider adding a brief comment here explaining what this feature flag does, similar to the other features in this file.
File third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
Line 870, Patchset 16 (Latest):
url_loader_factory_remote_.set_disconnect_handler(base::OnceClosure());Shunya Shishido . unresolved
Please fix this WARNING reported by autoreview issue finding: Nit: `Unbind()` technically clears any registered disconnect handlers, so this line is likely redundant but doesn't hurt.
Related details
Attention is currently required from:
- Yoshisato Yanagisawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoshisato Yanagisawa (Gerrit)
Jul 26, 2026, 11:22:40 PM (5 hours ago) Jul 26
to Shunya Shishido, Chromium LUCI CQ, chromium...@chromium.org, Hiroki Nakagawa, blink-re...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Yoshisato Yanagisawa voted and added 3 comments![]( "Open in Gerrit")
Votes added by Yoshisato Yanagisawa
| Commit-Queue | +2 |
3 comments
Commit Message
Line 9, Patchset 16:
Add feature flag kServiceWorkerRaceNetworkRequestFallbackOnDisconnect and
Mojo pipe disconnect handler in ServiceWorkerGlobalScope to handle
network pipe disconnections gracefully.Shunya Shishido . resolved
Yoshisato YanagisawaPlease format.
Done
File third_party/blink/common/features.cc
Line 2242, Patchset 16:
BASE_FEATURE(kServiceWorkerRaceNetworkRequestFallbackOnDisconnect,Shunya Shishido . resolved
Please fix this WARNING reported by autoreview issue finding: Consider adding a brief comment here explaining what this feature flag does, similar to the other features in this file.
Yoshisato Yanagisawa
Done
File third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
Line 870, Patchset 16:
url_loader_factory_remote_.set_disconnect_handler(base::OnceClosure());Shunya Shishido . resolved
Please fix this WARNING reported by autoreview issue finding: Nit: `Unbind()` technically clears any registered disconnect handlers, so this line is likely redundant but doesn't hurt.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages