Remove unused include in file_backed_blob_factory_dispatcher.h [chromium/src : main]

0 views
Skip to first unread message

David Sanders (Gerrit)

unread,
Sep 22, 2025, 9:38:28 PM (2 days ago) Sep 22
to AyeAye, Chromium LUCI CQ, kinuko+...@chromium.org, blink-...@chromium.org
Attention needed from David Sanders

Message from David Sanders

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6c99ee189ad50dfc2a724fd7254b16c1c68d9b30
Gerrit-Change-Number: 6975204
Gerrit-PatchSet: 4
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 01:38:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Sanders (Gerrit)

unread,
Sep 22, 2025, 9:38:59 PM (2 days ago) Sep 22
to Tsuyoshi Horo, AyeAye, Chromium LUCI CQ, kinuko+...@chromium.org, blink-...@chromium.org
Attention needed from Tsuyoshi Horo

David Sanders voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tsuyoshi Horo
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6c99ee189ad50dfc2a724fd7254b16c1c68d9b30
Gerrit-Change-Number: 6975204
Gerrit-PatchSet: 4
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>
Gerrit-Attention: Tsuyoshi Horo <ho...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Sep 2025 01:38:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tsuyoshi Horo (Gerrit)

unread,
Sep 23, 2025, 9:47:48 PM (6 hours ago) Sep 23
to David Sanders, AyeAye, Chromium LUCI CQ, kinuko+...@chromium.org, blink-...@chromium.org
Attention needed from David Sanders

Tsuyoshi Horo voted and added 1 comment

Votes added by Tsuyoshi Horo

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Tsuyoshi Horo . resolved

lgtm

Thank you.

Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6c99ee189ad50dfc2a724fd7254b16c1c68d9b30
Gerrit-Change-Number: 6975204
Gerrit-PatchSet: 4
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Wed, 24 Sep 2025 01:47:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

David Sanders (Gerrit)

unread,
12:29 AM (3 hours ago) 12:29 AM
to Tsuyoshi Horo, AyeAye, Chromium LUCI CQ, kinuko+...@chromium.org, blink-...@chromium.org

David Sanders voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6c99ee189ad50dfc2a724fd7254b16c1c68d9b30
Gerrit-Change-Number: 6975204
Gerrit-PatchSet: 4
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Sep 2025 04:29:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
1:25 AM (2 hours ago) 1:25 AM
to David Sanders, Tsuyoshi Horo, AyeAye, kinuko+...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove unused include in file_backed_blob_factory_dispatcher.h

Should save ~18 MiB of compiler input size.
Bug: 40318405
Change-Id: I6c99ee189ad50dfc2a724fd7254b16c1c68d9b30
Commit-Queue: David Sanders <dsand...@ucsbalum.com>
Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1519776}
Files:
  • M third_party/blink/renderer/core/fileapi/file_backed_blob_factory_dispatcher.h
Change size: XS
Delta: 1 file changed, 0 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Tsuyoshi Horo
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6c99ee189ad50dfc2a724fd7254b16c1c68d9b30
Gerrit-Change-Number: 6975204
Gerrit-PatchSet: 5
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages