Mason Freed (Gerrit)

unread,

Sep 5, 2024, 10:47:53 AM9/5/24

to Joey Arhar, Chromium LUCI CQ, chromium...@chromium.org, Kyra Seevers, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Attention needed from Joey Arhar

Mason Freed voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Joey Arhar

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Joey Arhar (Gerrit)

unread,

Sep 5, 2024, 3:46:20 PM9/5/24

to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, Kyra Seevers, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Attention needed from Mason Freed

Joey Arhar voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Mason Freed

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Sep 5, 2024, 3:49:13 PM9/5/24

to Mason Freed, Joey Arhar, chromium...@chromium.org, Kyra Seevers, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Enable KeyboardFocusableScrollers by default

As of this CL:

https://chromium-review.googlesource.com/c/chromium/src/+/5812197

the new behavior is to make scrollers *only* keyboard focusable,
and *not* click focusable. This matches Gecko behavior more-
closely, and should also avoid most of the breakage seen when
this feature was launched in M127/128.

This CL enables the feature, in code, by default. This is
different from the prior shipping methodology, which was slowly
via Finch. That approach did not tend to suss out problems early
in the ramp up, and instead only found problems when that Finch
config got to 100%. This is likely due to the particular sites
that are affected by this behavior. Because of this, we will
simply ship the feature by default in M130, and keep the feature
flag as a kill switch in case it is needed.

The I2S already approved shipment a while back:

https://groups.google.com/a/chromium.org/g/blink-dev/c/jzMA5vUqNDs/m/VbhNdHgQAgAJ

And the chromestatus already shows M130 as the shipping
milestone:

https://chromestatus.com/feature/5231964663578624

Fixed: 337158524

Bug: 361072782

Change-Id: I77e905fe171deedfb5479c75968ccdfd51e896bc

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5838700

Auto-Submit: Mason Freed <mas...@chromium.org>

Reviewed-by: Joey Arhar <jar...@chromium.org>

Commit-Queue: Joey Arhar <jar...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1351642}

Files:

M third_party/blink/renderer/platform/runtime_enabled_features.json5

Change size: XS

Delta: 1 file changed, 5 insertions(+), 2 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Joey Arhar

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Enable KeyboardFocusableScrollers by default [chromium/src : main]

Mason Freed (Gerrit)

Mason Freed voted Auto-Submit+1

Related details

Joey Arhar (Gerrit)

Joey Arhar voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information