inline-script-cache: Fix crash when CodeCacheHost gets unavailable during script execution [chromium/src : main]

0 views
Skip to first unread message

Kouhei Ueno (Gerrit)

unread,
5:20 AM (4 hours ago) 5:20 AM
to Takashi Nakayama, chromium...@chromium.org, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, kinuko...@chromium.org, loading...@chromium.org, blink-...@chromium.org, loading-re...@chromium.org, gavinp...@chromium.org
Attention needed from Takashi Nakayama

Kouhei Ueno voted and added 1 comment

Votes added by Kouhei Ueno

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kouhei Ueno . resolved

Would it be possible for you to come up with regression test? (not blocking landing

Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Nakayama
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icc809c215d4bd58cbd048a7d03a8476d2bd034e1
Gerrit-Change-Number: 7753807
Gerrit-PatchSet: 3
Gerrit-Owner: Takashi Nakayama <tn...@chromium.org>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-Reviewer: Takashi Nakayama <tn...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Takashi Nakayama <tn...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Apr 2026 09:19:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Takashi Nakayama (Gerrit)

unread,
6:08 AM (4 hours ago) 6:08 AM
to Kouhei Ueno, chromium...@chromium.org, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, kinuko...@chromium.org, loading...@chromium.org, blink-...@chromium.org, loading-re...@chromium.org, gavinp...@chromium.org

Takashi Nakayama voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icc809c215d4bd58cbd048a7d03a8476d2bd034e1
Gerrit-Change-Number: 7753807
Gerrit-PatchSet: 3
Gerrit-Owner: Takashi Nakayama <tn...@chromium.org>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-Reviewer: Takashi Nakayama <tn...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Apr 2026 10:08:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
6:11 AM (4 hours ago) 6:11 AM
to Takashi Nakayama, Kouhei Ueno, chromium...@chromium.org, Nate Chapin, android-bu...@system.gserviceaccount.com, kinuko...@chromium.org, loading...@chromium.org, blink-...@chromium.org, loading-re...@chromium.org, gavinp...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
inline-script-cache: Fix crash when CodeCacheHost gets unavailable during script execution

This CL fixes a crash in `SourceKeyedCachedMetadataHandler` when
`CodeCacheHost` becomes unavailable, for example, when an inline script
in a frame removes the frame containing itself from DOM. Because
`V8CodeCache::ProduceCache()` is called after the execution of
`V8ScriptRunner::RunCompiledScript()` in
`V8ScriptRunner::CompileAndRunScript()`, `CodeCacheHost` can be lost
when producing the code cache.
Bug: 488755561
Change-Id: Icc809c215d4bd58cbd048a7d03a8476d2bd034e1
Commit-Queue: Takashi Nakayama <tn...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1613600}
Files:
  • M third_party/blink/renderer/platform/loader/fetch/script_cached_metadata_handler.cc
Change size: XS
Delta: 1 file changed, 4 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kouhei Ueno
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icc809c215d4bd58cbd048a7d03a8476d2bd034e1
Gerrit-Change-Number: 7753807
Gerrit-PatchSet: 4
Gerrit-Owner: Takashi Nakayama <tn...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-Reviewer: Takashi Nakayama <tn...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages