Hi Victor,
this CL cleans up flag which we shipped in M144. Since we are already in M145 cycle, may we remove the flag already or should we wait a few more milestones?
Thanks!
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hi Victor,
this CL cleans up flag which we shipped in M144. Since we are already in M145 cycle, may we remove the flag already or should we wait a few more milestones?
Thanks!
let's just wait a few more milestones instead of removing them immediately after shipping. thanks.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor TanHi Victor,
this CL cleans up flag which we shipped in M144. Since we are already in M145 cycle, may we remove the flag already or should we wait a few more milestones?
Thanks!
let's just wait a few more milestones instead of removing them immediately after shipping. thanks.
+1 - sometimes bugs can take a few milestones to get discovered/reported.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Postponing until later milestone.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bershanskyi removed kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org and asvitki...@chromium.org from reviewers of this change.
[Client Hints] Remove flag for reduced Linux platform version
The new proposed privacy-respecting behavior was shipped in M144. Remove
now obsolete flag ReduceUserAgentDataLinuxPlatformVersion.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hi Victor,
Should we proceed with removal of Linux platform hint flag or should we wait for a bit longer?
M144 shipped the new behavior to hide kernel version number on Linux (in your CL 7134391). Since then, M144 and M145 shipped to stable and became obsolete, and M146 shipped to stable. Also, recently M148 branched from `main` and M149 dev cycle began. Is now a suitable time to move ahead with the flag removal?
Sincerely,
Anton.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hi Victor,
Should we proceed with removal of Linux platform hint flag or should we wait for a bit longer?
M144 shipped the new behavior to hide kernel version number on Linux (in your CL 7134391). Since then, M144 and M145 shipped to stable and became obsolete, and M146 shipped to stable. Also, recently M148 branched from `main` and M149 dev cycle began. Is now a suitable time to move ahead with the flag removal?
Sincerely,
Anton.
thanks for the reminder and sorry for the late reply. Currently i'm focusing on other projects.:). I already put this on the queue and have a reminder for this and will review the metrics to see any impacts by the end of April since removing such flag is very urgent.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor TanHi Victor,
Should we proceed with removal of Linux platform hint flag or should we wait for a bit longer?
M144 shipped the new behavior to hide kernel version number on Linux (in your CL 7134391). Since then, M144 and M145 shipped to stable and became obsolete, and M146 shipped to stable. Also, recently M148 branched from `main` and M149 dev cycle began. Is now a suitable time to move ahead with the flag removal?
Sincerely,
Anton.
thanks for the reminder and sorry for the late reply. Currently i'm focusing on other projects.:). I already put this on the queue and have a reminder for this and will review the metrics to see any impacts by the end of April since removing such flag is very urgent.
thanks for the reply. Of course, there is no rush, I just wanted to ensure I'm not leaving behind temporary code/flags which I introduce. Please take your time.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
I rebased the CL to avoid a merge conflict. No other changes.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hi Victor,
the flag responsible for Linux Platform Version hint has `expiry_milestone` set to `150`. The `main` branch `chrome/VERSION` was recently updated indicating M150 dev cycle start. We should consider either postponing `expiry_milestone` in case it still has any usage or removing the flag entirely. Would you like me to create a one-liner CL updating `expiry_milestone` to, say 153?
Thanks,
Anton.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hi Victor,
the flag responsible for Linux Platform Version hint has `expiry_milestone` set to `150`. The `main` branch `chrome/VERSION` was recently updated indicating M150 dev cycle start. We should consider either postponing `expiry_milestone` in case it still has any usage or removing the flag entirely. Would you like me to create a one-liner CL updating `expiry_milestone` to, say 153?
Thanks,
Anton.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hi Mike, this CL removes one flag which has been flipped since M144, would you be interested in reviewing this? Thanks!
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |