Fix dialog showModal() crash with content-visibility:auto [chromium/src : main]
0 views
Skip to first unread message
Joanmarie Diggs (Gerrit)
Mar 20, 2026, 8:54:07 AM (2 days ago) Mar 20
to Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joanmarie Diggs
Message from Joanmarie Diggs![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Joanmarie Diggs
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joanmarie Diggs (Gerrit)
Mar 20, 2026, 8:56:14 AM (2 days ago) Mar 20
to Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Vladimir Levin
Joanmarie Diggs added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Joanmarie Diggs . resolved
Vladimir: PTAL. (Some of my work-in-progress accessibility fuzz tests keep hitting this.) Thanks in advance!
Related details
Attention is currently required from:
- Vladimir Levin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joanmarie Diggs (Gerrit)
Mar 20, 2026, 9:17:46 AM (2 days ago) Mar 20
to Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Joanmarie Diggs added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Joanmarie Diggs . resolved
Actually, my first stab at the problem only fixes one instance of the crash. Need to dig into this some more. Sorry for the noise!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joanmarie Diggs (Gerrit)
Mar 21, 2026, 2:31:37 PM (10 hours ago) Mar 21
to AyeAye, Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joanmarie Diggs and Vladimir Levin
Message from Joanmarie Diggs![]( "Open in Gerrit")
Attention is currently required from:
- Joanmarie Diggs
- Vladimir Levin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joanmarie Diggs (Gerrit)
Mar 21, 2026, 2:38:42 PM (10 hours ago) Mar 21
to AyeAye, Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Vladimir Levin
Joanmarie Diggs added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Joanmarie Diggs . resolved
Vladimir: PTAL. Please note that this is unfamiliar code for me. (I'm an accessibility person.) Also using `TakeBlockedStyleRecalcChange()` feels like a not-great idea. But I didn't find another way that worked and felt less hacky. Suggestions very welcome. Thanks in advance!
Related details
Attention is currently required from:
- Vladimir Levin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages