Treat static video controls as replaced normal-flow stacking [chromium/src : main]

0 views

Skip to first unread message

jj (Gerrit)

unread,

3:58 PM (5 hours ago) 3:58 PM

to Xianzhu Wang, Alex Keng, srirama chandra sekhar, Fredrik Söderquist, Dirk Schulze, Stephen Chenney, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, steimel+watch...@chromium.org, eric.c...@apple.com, blink-rev...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, zol...@webkit.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, fmalit...@chromium.org, blink-revi...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Xianzhu Wang

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Xianzhu Wang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Xianzhu Wang (Gerrit)

unread,

7:45 PM (1 hour ago) 7:45 PM

to Mason Freed, Alex Keng, srirama chandra sekhar, Fredrik Söderquist, Dirk Schulze, Stephen Chenney, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, steimel+watch...@chromium.org, eric.c...@apple.com, blink-rev...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, zol...@webkit.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, fmalit...@chromium.org, blink-revi...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Mason Freed and jj

Xianzhu Wang added 4 comments

Patchset-level comments

File-level comment, Patchset 18 (Latest):

Xianzhu Wang . resolved

+Mason for the style and html parts of this CL.

File third_party/blink/renderer/core/layout/layout_video.cc

Line 43, Patchset 18 (Latest): if (IsStackingContext() && !IsStacked()) {

Xianzhu Wang . unresolved

Please see the comment in https://chromium-review.googlesource.com/c/chromium/src/+/7618177/4/third_party/blink/renderer/core/layout/svg/layout_svg_foreign_object.cc.

File third_party/blink/renderer/core/paint/paint_layer.cc

Line 1846, Patchset 18 (Latest): if (child_layer->GetLayoutObject().IsSVGForeignObject()) {

Xianzhu Wang . unresolved

I would like a comment here. I'm not very sure how that works. Can you create a test case with a stacked child under an SVG foreign object, and check the stack when the stacked child is hit tested? The stack will help us put correct comment here.

File third_party/blink/renderer/core/paint/paint_layer_painter.cc

Line 607, Patchset 18 (Latest): if (child->GetLayoutObject().IsSVGForeignObject()) {

Xianzhu Wang . unresolved

I would like a comment here. I'm not very sure how that works. Can you create a test case with a stacked child under an SVG foreign object, and check the stack when the stacked child is painted? The stack will help us put correct comment here.

Open in Gerrit

Related details

Attention is currently required from:

Mason Freed
jj

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages