Don't blockify scroll markers based on originating element. [chromium/src : main]
0 views
Skip to first unread message
Morten Stenshorne (Gerrit)
Nov 12, 2024, 1:22:01 PMNov 12
to Rune Lillesveen, Daniil Sakhapov, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Daniil Sakhapov and Rune Lillesveen
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Daniil Sakhapov
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniil Sakhapov (Gerrit)
Nov 12, 2024, 1:35:58 PMNov 12
to Morten Stenshorne, Rune Lillesveen, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Morten Stenshorne and Rune Lillesveen
Daniil Sakhapov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Morten Stenshorne
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
Nov 13, 2024, 4:43:14 AMNov 13
to Morten Stenshorne, Rune Lillesveen, Daniil Sakhapov, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Morten Stenshorne
Rune Lillesveen voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Morten Stenshorne
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Morten Stenshorne (Gerrit)
Nov 13, 2024, 7:00:36 AMNov 13
to Chromium LUCI CQ, Rune Lillesveen, Daniil Sakhapov, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Morten Stenshorne voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 13, 2024, 7:21:08 AMNov 13
to Morten Stenshorne, Rune Lillesveen, Daniil Sakhapov, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[carousel] Don't blockify scroll markers based on originating element.
Any blockification needed takes place when attaching the scroll marker
(which happens during layout). Avoid also doing it during style recalc,
as we don't have the correct layout parent at that point.
Bug: 376834376
Change-Id: I2e4fd3d83863d8ae94aa876663305d9d8feb9931
Commit-Queue: Morten Stenshorne <mste...@chromium.org>
Reviewed-by: Daniil Sakhapov <sakh...@chromium.org>
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1382270}
Files:
- M third_party/blink/renderer/core/css/resolver/style_adjuster.cc
- A third_party/blink/web_tests/wpt_internal/css/css-overflow/scroll-marker-012.html
Change size: S
Delta: 2 files changed, 33 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniil Sakhapov, +1 by Rune Lillesveen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages