stdc++: replace std::make_optional with assignment in history_item.cc [chromium/src : main]

0 views
Skip to first unread message

Takashi Toyoshima (Gerrit)

unread,
Jul 2, 2024, 2:15:48 AM (yesterday) Jul 2
to Lauren Liberda, Chromium LUCI CQ, Nate Chapin, chromium...@chromium.org, AyeAye, gavinp...@chromium.org, blink-...@chromium.org, loading...@chromium.org
Attention needed from Lauren Liberda and Nate Chapin

Takashi Toyoshima added 1 comment

File third_party/blink/renderer/core/loader/history_item.cc
Line 184, Patchset 1 (Latest): if (!view_state_)
Takashi Toyoshima . unresolved

Can we consider to have the HistoryItem::GetOrCreateViewState()?
Also, the recent styleguide prefers adding `{` and `}` even for one-liners.

Open in Gerrit

Related details

Attention is currently required from:
  • Lauren Liberda
  • Nate Chapin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib6ed1cd7035f264d838eb401240f59cbd5110cf8
Gerrit-Change-Number: 5658974
Gerrit-PatchSet: 1
Gerrit-Owner: Lauren Liberda <lau...@selfisekai.rocks>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Lauren Liberda <lau...@selfisekai.rocks>
Gerrit-Comment-Date: Tue, 02 Jul 2024 06:15:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lauren Liberda (Gerrit)

unread,
Jul 2, 2024, 10:11:19 AM (20 hours ago) Jul 2
to Chromium LUCI CQ, Takashi Toyoshima, Nate Chapin, chromium...@chromium.org, AyeAye, gavinp...@chromium.org, blink-...@chromium.org, loading...@chromium.org
Attention needed from Nate Chapin and Takashi Toyoshima

Lauren Liberda added 1 comment

File third_party/blink/renderer/core/loader/history_item.cc
Takashi Toyoshima . resolved

Can we consider to have the HistoryItem::GetOrCreateViewState()?
Also, the recent styleguide prefers adding `{` and `}` even for one-liners.

Lauren Liberda

Fix applied.

Open in Gerrit

Related details

Attention is currently required from:
  • Nate Chapin
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib6ed1cd7035f264d838eb401240f59cbd5110cf8
Gerrit-Change-Number: 5658974
Gerrit-PatchSet: 1
Gerrit-Owner: Lauren Liberda <lau...@selfisekai.rocks>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 14:11:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Takashi Toyoshima <toyo...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Takashi Toyoshima (Gerrit)

unread,
Jul 2, 2024, 9:32:23 PM (9 hours ago) Jul 2
to Lauren Liberda, Chromium LUCI CQ, Nate Chapin, chromium...@chromium.org, AyeAye, gavinp...@chromium.org, blink-...@chromium.org, loading...@chromium.org
Attention needed from Lauren Liberda and Nate Chapin

Takashi Toyoshima added 1 comment

File third_party/blink/renderer/core/loader/history_item.cc
Line 183, Patchset 2 (Latest):HistoryItem::ViewState& HistoryItem::GetOrCreateViewState() {
Takashi Toyoshima . unresolved

Can you update the header file too?

Open in Gerrit

Related details

Attention is currently required from:
  • Lauren Liberda
  • Nate Chapin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib6ed1cd7035f264d838eb401240f59cbd5110cf8
    Gerrit-Change-Number: 5658974
    Gerrit-PatchSet: 2
    Gerrit-Owner: Lauren Liberda <lau...@selfisekai.rocks>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Lauren Liberda <lau...@selfisekai.rocks>
    Gerrit-Comment-Date: Wed, 03 Jul 2024 01:32:13 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Lauren Liberda (Gerrit)

    unread,
    Jul 2, 2024, 9:43:23 PM (9 hours ago) Jul 2
    to Chromium LUCI CQ, Takashi Toyoshima, Nate Chapin, chromium...@chromium.org, AyeAye, gavinp...@chromium.org, blink-...@chromium.org, loading...@chromium.org
    Attention needed from Nate Chapin and Takashi Toyoshima

    Lauren Liberda added 1 comment

    File third_party/blink/renderer/core/loader/history_item.cc
    Line 183, Patchset 2:HistoryItem::ViewState& HistoryItem::GetOrCreateViewState() {
    Takashi Toyoshima . unresolved

    Can you update the header file too?

    Lauren Liberda

    like this?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nate Chapin
    • Takashi Toyoshima
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib6ed1cd7035f264d838eb401240f59cbd5110cf8
    Gerrit-Change-Number: 5658974
    Gerrit-PatchSet: 3
    Gerrit-Owner: Lauren Liberda <lau...@selfisekai.rocks>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Comment-Date: Wed, 03 Jul 2024 01:43:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Takashi Toyoshima <toyo...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Takashi Toyoshima (Gerrit)

    unread,
    1:53 AM (5 hours ago) 1:53 AM
    to Lauren Liberda, Chromium LUCI CQ, Nate Chapin, chromium...@chromium.org, AyeAye, gavinp...@chromium.org, blink-...@chromium.org, loading...@chromium.org
    Attention needed from Lauren Liberda and Nate Chapin

    Takashi Toyoshima added 1 comment

    File third_party/blink/renderer/core/loader/history_item.cc
    Line 183, Patchset 2:HistoryItem::ViewState& HistoryItem::GetOrCreateViewState() {
    Takashi Toyoshima . unresolved

    Can you update the header file too?

    Lauren Liberda

    like this?

    Takashi Toyoshima

    I think we want to have this method in the private area as we don't need to call it outside the class.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Lauren Liberda
    • Nate Chapin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib6ed1cd7035f264d838eb401240f59cbd5110cf8
    Gerrit-Change-Number: 5658974
    Gerrit-PatchSet: 3
    Gerrit-Owner: Lauren Liberda <lau...@selfisekai.rocks>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Lauren Liberda <lau...@selfisekai.rocks>
    Gerrit-Comment-Date: Wed, 03 Jul 2024 05:53:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Lauren Liberda <lau...@selfisekai.rocks>
    Comment-In-Reply-To: Takashi Toyoshima <toyo...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages