Fix single-axis overscroll fling jitter [chromium/src : main]
Gaston Rodriguez (Gerrit)
Gaston Rodriguez voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Gaston Rodriguez
- Olga Gerchikov
- Rahul Arakeri
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rahul Arakeri (Gerrit)
Rahul Arakeri added 1 comment![]( "Open in Gerrit")
Hey Gaston, can you please add a video or a gif of the before and after?
Related details
- Gaston Rodriguez
- Olga Gerchikov
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gaston Rodriguez (Gerrit)
Gaston Rodriguez added 1 comment![]( "Open in Gerrit")
Hey Gaston, can you please add a video or a gif of the before and after?
Uploaded a comparison video here:
https://drive.google.com/file/d/1kXPUmwQplAttoh9j7PxWoWblRn3eLwsK/view?usp=sharing
Will also link to it in the linked crbug and mention it in the description.
Related details
- Olga Gerchikov
- Rahul Arakeri
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rahul Arakeri (Gerrit)
Rahul Arakeri added 1 comment![]( "Open in Gerrit")
Gaston RodriguezHey Gaston, can you please add a video or a gif of the before and after?
Uploaded a comparison video here:
https://drive.google.com/file/d/1kXPUmwQplAttoh9j7PxWoWblRn3eLwsK/view?usp=sharingWill also link to it in the linked crbug and mention it in the description.
Thanks for adding the video!
I still see the jitter on the left Window. Is it because of this? https://issues.chromium.org/issues/369653186#comment3
Related details
- Gaston Rodriguez
- Olga Gerchikov
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gaston Rodriguez (Gerrit)
Gaston Rodriguez added 1 comment![]( "Open in Gerrit")
Gaston RodriguezHey Gaston, can you please add a video or a gif of the before and after?
Rahul ArakeriUploaded a comparison video here:
https://drive.google.com/file/d/1kXPUmwQplAttoh9j7PxWoWblRn3eLwsK/view?usp=sharingWill also link to it in the linked crbug and mention it in the description.
Thanks for adding the video!
I still see the jitter on the left Window. Is it because of this? https://issues.chromium.org/issues/369653186#comment3
- Olga Gerchikov
- Rahul Arakeri
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gaston Rodriguez (Gerrit)
Gaston Rodriguez added 1 comment![]( "Open in Gerrit")
Gaston RodriguezHey Gaston, can you please add a video or a gif of the before and after?
Rahul ArakeriUploaded a comparison video here:
https://drive.google.com/file/d/1kXPUmwQplAttoh9j7PxWoWblRn3eLwsK/view?usp=sharingWill also link to it in the linked crbug and mention it in the description.
Gaston RodriguezThanks for adding the video!
I still see the jitter on the left Window. Is it because of this? https://issues.chromium.org/issues/369653186#comment3
Yes, I just copy-pasted the description of this bug.
I just rewatched the video, I uploaded the wrong one 😶. The windows are inversed, the blue one is canary and red is with the fix. I'll update the link in the bug too.
https://drive.google.com/file/d/17r9yhTIuXMFpcBroNQ_lTj7EtggenJOZ/view?usp=sharing
Rahul Arakeri (Gerrit)
Rahul Arakeri voted and added 2 comments![]( "Open in Gerrit")
Votes added by Rahul Arakeri
| Code-Review | +1 |
Gaston RodriguezHey Gaston, can you please add a video or a gif of the before and after?
Rahul ArakeriUploaded a comparison video here:
https://drive.google.com/file/d/1kXPUmwQplAttoh9j7PxWoWblRn3eLwsK/view?usp=sharingWill also link to it in the linked crbug and mention it in the description.
Gaston RodriguezThanks for adding the video!
I still see the jitter on the left Window. Is it because of this? https://issues.chromium.org/issues/369653186#comment3
Gaston RodriguezYes, I just copy-pasted the description of this bug.
I just rewatched the video, I uploaded the wrong one 😶. The windows are inversed, the blue one is canary and red is with the fix. I'll update the link in the bug too.
https://drive.google.com/file/d/17r9yhTIuXMFpcBroNQ_lTj7EtggenJOZ/view?usp=sharing
Thanks. Yeah, that threw me off a bit. LGTM % nit.
if (!forward_animation.IsZero()) {nit: was this due to git cl format?
Related details
- Gaston Rodriguez
- Olga Gerchikov
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gaston Rodriguez (Gerrit)
Gaston Rodriguez added 2 comments![]( "Open in Gerrit")
Hello @sko...@chromium.org , you reviewed the previous CL on this issue and own the files. Would you mind taking a look? Thanks!
if (!forward_animation.IsZero()) {nit: was this due to git cl format?
- Olga Gerchikov
- Steve Kobes
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steve Kobes (Gerrit)
Steve Kobes voted Code-Review+1![]( "Open in Gerrit")
- Gaston Rodriguez
- Olga Gerchikov
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gaston Rodriguez (Gerrit)
Gaston Rodriguez voted Commit-Queue+2![]( "Open in Gerrit")
- Olga Gerchikov
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Fix single-axis overscroll fling jitter
This CL is a follow up to CL:5894444. It fixes a different scenario that
causes jittering when overscrolling.
To repro (in Chrome Canary):
1. Enable elastic overscroll (chrome://flags/#elastic-overscroll)
2. Open a webpage. For example, lipsum.com
3. Do a drag gesture downwards and the sidewards, but don't release your
finger from the screen.
4. Right before releasing, fling your finger exactly in one axis such
that the animation is not diagonal.
5. The Overscroll controller will "blink" in the different axis you
flinged (if you flinged sidewards, the content will blink vertically)
and then execute the rest of the bounce back animation. The correct
behavior would be to just bounce back into place.
A video showcasing the jitter vs the fix can be found in the linked
crbug.
The root cause for this issue is that the forward bounce animation has
no velocity in one of the axis and the stretch function returns zero
when this is the case, instead of the correct stretched amount.
This CL:
- Fixes this problem by removing the velocity limitation.
- Fixes an incorrect time delta subtraction that caused bounce back
animations to be shorter than they should.
- Fixes the test implemented in CL:5894444 which was not working
properly.
- M third_party/blink/renderer/platform/widget/input/elastic_overscroll_controller.h
- M third_party/blink/renderer/platform/widget/input/elastic_overscroll_controller_bezier.cc
- M third_party/blink/renderer/platform/widget/input/elastic_overscroll_controller_bezier.h
- M third_party/blink/renderer/platform/widget/input/elastic_overscroll_controller_bezier_unittest.cc
Code-Review: +1 by Rahul Arakeri, +1 by Steve Kobes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |