[Cleanup] AndroidAnimatedProgressBarInViz [chromium/src : main]

0 views
Skip to first unread message

Peilin Wang (Gerrit)

unread,
Dec 10, 2025, 11:44:47 AM (13 days ago) Dec 10
to Kyle Charbonneau, Patrick Noland, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, droger+w...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, hanxi...@chromium.org, loading...@chromium.org, peilinwa...@google.com
Attention needed from Kyle Charbonneau and Patrick Noland

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Kyle Charbonneau
  • Patrick Noland
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I119ac8664c716c9390691fcf00bac3e4af812fe3
Gerrit-Change-Number: 7242287
Gerrit-PatchSet: 4
Gerrit-Owner: Peilin Wang <peili...@google.com>
Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
Gerrit-Reviewer: Peilin Wang <peili...@google.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Attention: Patrick Noland <pno...@chromium.org>
Gerrit-Comment-Date: Wed, 10 Dec 2025 16:44:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Noland (Gerrit)

unread,
Dec 10, 2025, 12:14:19 PM (13 days ago) Dec 10
to Peilin Wang, Kyle Charbonneau, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, droger+w...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, hanxi...@chromium.org, loading...@chromium.org, peilinwa...@google.com
Attention needed from Kyle Charbonneau and Peilin Wang

Patrick Noland voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kyle Charbonneau
  • Peilin Wang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I119ac8664c716c9390691fcf00bac3e4af812fe3
    Gerrit-Change-Number: 7242287
    Gerrit-PatchSet: 4
    Gerrit-Owner: Peilin Wang <peili...@google.com>
    Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
    Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
    Gerrit-Reviewer: Peilin Wang <peili...@google.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Kyle Charbonneau <kyle...@chromium.org>
    Gerrit-Attention: Peilin Wang <peili...@google.com>
    Gerrit-Comment-Date: Wed, 10 Dec 2025 17:14:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kyle Charbonneau (Gerrit)

    unread,
    Dec 10, 2025, 4:21:32 PM (13 days ago) Dec 10
    to Peilin Wang, Patrick Noland, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, droger+w...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, hanxi...@chromium.org, loading...@chromium.org, peilinwa...@google.com
    Attention needed from Peilin Wang

    Kyle Charbonneau voted and added 1 comment

    Votes added by Kyle Charbonneau

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Kyle Charbonneau . resolved

    viz lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Peilin Wang
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I119ac8664c716c9390691fcf00bac3e4af812fe3
    Gerrit-Change-Number: 7242287
    Gerrit-PatchSet: 4
    Gerrit-Owner: Peilin Wang <peili...@google.com>
    Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
    Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
    Gerrit-Reviewer: Peilin Wang <peili...@google.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Peilin Wang <peili...@google.com>
    Gerrit-Comment-Date: Wed, 10 Dec 2025 21:21:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Peilin Wang (Gerrit)

    unread,
    Dec 10, 2025, 4:32:40 PM (13 days ago) Dec 10
    to Kyle Charbonneau, Patrick Noland, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, droger+w...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, hanxi...@chromium.org, loading...@chromium.org, peilinwa...@google.com

    Peilin Wang voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I119ac8664c716c9390691fcf00bac3e4af812fe3
    Gerrit-Change-Number: 7242287
    Gerrit-PatchSet: 4
    Gerrit-Owner: Peilin Wang <peili...@google.com>
    Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
    Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
    Gerrit-Reviewer: Peilin Wang <peili...@google.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Comment-Date: Wed, 10 Dec 2025 21:32:31 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Peilin Wang (Gerrit)

    unread,
    Dec 12, 2025, 2:05:29 PM (11 days ago) Dec 12
    to Kyle Charbonneau, Patrick Noland, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, droger+w...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, hanxi...@chromium.org, loading...@chromium.org, peilinwa...@google.com
    Gerrit-Comment-Date: Fri, 12 Dec 2025 19:05:19 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Peilin Wang (Gerrit)

    unread,
    Dec 12, 2025, 3:27:41 PM (11 days ago) Dec 12
    to Kyle Charbonneau, Patrick Noland, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, droger+w...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, hanxi...@chromium.org, loading...@chromium.org, peilinwa...@google.com
    Gerrit-Comment-Date: Fri, 12 Dec 2025 20:27:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Peilin Wang (Gerrit)

    unread,
    1:21 AM (7 hours ago) 1:21 AM
    to Kyle Charbonneau, Patrick Noland, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, droger+w...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, hanxi...@chromium.org, loading...@chromium.org, peilinwa...@google.com
    Gerrit-Comment-Date: Tue, 23 Dec 2025 06:20:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    2:01 AM (6 hours ago) 2:01 AM
    to Peilin Wang, Kyle Charbonneau, Patrick Noland, AyeAye, chromium...@chromium.org, Nate Chapin, droger+w...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, hanxi...@chromium.org, loading...@chromium.org, peilinwa...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [Cleanup] AndroidAnimatedProgressBarInViz
    Bug: 467341935
    Change-Id: I119ac8664c716c9390691fcf00bac3e4af812fe3
    Commit-Queue: Peilin Wang <peili...@google.com>
    Reviewed-by: Patrick Noland <pno...@chromium.org>
    Reviewed-by: Kyle Charbonneau <kyle...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1562101}
    Files:
    • M chrome/browser/android/compositor/layer/tab_layer.cc
    • M chrome/browser/android/compositor/layer/toolbar_layer.cc
    • M chrome/browser/android/compositor/layer/toolbar_layer.h
    • M chrome/browser/android/compositor/scene_layer/top_toolbar_scene_layer.cc
    • M chrome/browser/android/compositor/scene_layer/top_toolbar_scene_layer.h
    • M chrome/browser/flags/android/chrome_feature_list.cc
    • M chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
    • M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/ToolbarProgressBar.java
    • M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/TopToolbarOverlayMediator.java
    • M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/TopToolbarSceneLayer.java
    • M components/browser_ui/widget/android/BUILD.gn
    • M components/browser_ui/widget/android/DEPS
    • M components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/ClipDrawableProgressBar.java
    • M components/viz/common/features.cc
    • M components/viz/common/features.h
    Change size: M
    Delta: 15 files changed, 42 insertions(+), 176 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kyle Charbonneau, +1 by Patrick Noland
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I119ac8664c716c9390691fcf00bac3e4af812fe3
    Gerrit-Change-Number: 7242287
    Gerrit-PatchSet: 5
    Gerrit-Owner: Peilin Wang <peili...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
    Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
    Gerrit-Reviewer: Peilin Wang <peili...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages