Update <script> insertion & removal tests to align with spec change [chromium/src : main]

0 views
Skip to first unread message

YeongHan Kim (Gerrit)

unread,
Feb 8, 2026, 4:24:53 AMFeb 8
to Mason Freed, Dominic Farolino, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Dominic Farolino and Mason Freed

YeongHan Kim added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
YeongHan Kim . resolved

Please take a look. Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id8067e936b9fbaaa4542ada06e065719b511eac7
Gerrit-Change-Number: 7554290
Gerrit-PatchSet: 4
Gerrit-Owner: YeongHan Kim <soosu...@gmail.com>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: YeongHan Kim <soosu...@gmail.com>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Comment-Date: Sun, 08 Feb 2026 09:24:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Feb 10, 2026, 1:12:44 PMFeb 10
to YeongHan Kim, Dominic Farolino, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Dominic Farolino and YeongHan Kim

Mason Freed voted and added 2 comments

Votes added by Mason Freed

Code-Review+1

2 comments

Patchset-level comments
Mason Freed . resolved

Looks ok to me, but please do wait for dom@'s review to be sure.

Commit Message
Line 19, Patchset 4 (Latest):the new spec. 오후 3:02With this change, Chromium and Gecko pass the
Mason Freed . unresolved

This seems accidental

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
  • YeongHan Kim
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id8067e936b9fbaaa4542ada06e065719b511eac7
    Gerrit-Change-Number: 7554290
    Gerrit-PatchSet: 4
    Gerrit-Owner: YeongHan Kim <soosu...@gmail.com>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: YeongHan Kim <soosu...@gmail.com>
    Gerrit-Attention: Dominic Farolino <d...@chromium.org>
    Gerrit-Attention: YeongHan Kim <soosu...@gmail.com>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 18:12:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    YeongHan Kim (Gerrit)

    unread,
    Feb 12, 2026, 3:28:46 AMFeb 12
    to Mason Freed, Dominic Farolino, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Dominic Farolino

    YeongHan Kim added 2 comments

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    YeongHan Kim . resolved

    Thanks for the review!

    Commit Message
    Line 19, Patchset 4:the new spec. 오후 3:02With this change, Chromium and Gecko pass the
    Mason Freed . resolved

    This seems accidental

    YeongHan Kim

    Oh! Thanks for catching my mistake.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dominic Farolino
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id8067e936b9fbaaa4542ada06e065719b511eac7
      Gerrit-Change-Number: 7554290
      Gerrit-PatchSet: 5
      Gerrit-Owner: YeongHan Kim <soosu...@gmail.com>
      Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: YeongHan Kim <soosu...@gmail.com>
      Gerrit-Attention: Dominic Farolino <d...@chromium.org>
      Gerrit-Comment-Date: Thu, 12 Feb 2026 08:28:23 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Mason Freed <mas...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      YeongHan Kim (Gerrit)

      unread,
      9:15 AM (12 hours ago) 9:15 AM
      to Mason Freed, Dominic Farolino, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Dominic Farolino

      YeongHan Kim added 1 comment

      Patchset-level comments
      YeongHan Kim . resolved

      gentle ping @d...@chromium.org

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dominic Farolino
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id8067e936b9fbaaa4542ada06e065719b511eac7
      Gerrit-Change-Number: 7554290
      Gerrit-PatchSet: 5
      Gerrit-Owner: YeongHan Kim <soosu...@gmail.com>
      Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: YeongHan Kim <soosu...@gmail.com>
      Gerrit-Attention: Dominic Farolino <d...@chromium.org>
      Gerrit-Comment-Date: Sat, 28 Feb 2026 14:15:04 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages