[Sheriff] Disable flaky pointer-lock test [chromium/src : main]

1 view
Skip to first unread message

Thomas Guilbert (Gerrit)

unread,
Apr 23, 2021, 7:28:46 PM4/23/21
to Eugene Zemtsov, blink-...@chromium.org, Thomas Guilbert

Attention is currently required from: Eugene Zemtsov.

Thomas Guilbert would like Eugene Zemtsov to review this change.

View Change

[Sheriff] Disable flaky pointer-lock test

This is already disabled on Mac. Also disable it on Linux.

Bug: 1197528
Change-Id: I04965ec81e5c782ce597800d87e67b69da963f3f
---
M third_party/blink/web_tests/TestExpectations
1 file changed, 1 insertion(+), 0 deletions(-)

diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations
index 57aece63..cb246e6 100644
--- a/third_party/blink/web_tests/TestExpectations
+++ b/third_party/blink/web_tests/TestExpectations
@@ -7173,3 +7173,4 @@
crbug.com/1202051 virtual/scroll-unification/scrollbars/layout-viewport-scrollbars-hidden.html [ Pass Failure ]
crbug.com/1202051 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/layout-viewport-scrollbars-hidden.html [ Pass Failure ]
crbug.com/1200751 [ Linux ] fast/peerconnection/RTCPeerConnection-addMultipleTracks.html [ Pass Failure ]
+crbug.com/1197528 [ Linux ] pointer-lock/pointerlockchange-pointerlockerror-events.html [ Pass Failure ]

To view, visit change 2847990. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I04965ec81e5c782ce597800d87e67b69da963f3f
Gerrit-Change-Number: 2847990
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
Gerrit-MessageType: newchange

Thomas Guilbert (Gerrit)

unread,
Apr 23, 2021, 7:28:51 PM4/23/21
to Thomas Guilbert, blink-...@chromium.org, Eugene Zemtsov, chromium...@chromium.org

Attention is currently required from: Eugene Zemtsov.

Patch set 1:Owners-Override +1Auto-Submit +1Commit-Queue +1

View Change

    To view, visit change 2847990. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I04965ec81e5c782ce597800d87e67b69da963f3f
    Gerrit-Change-Number: 2847990
    Gerrit-PatchSet: 1
    Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
    Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Comment-Date: Fri, 23 Apr 2021 23:28:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Eugene Zemtsov (Gerrit)

    unread,
    Apr 23, 2021, 7:40:13 PM4/23/21
    to Thomas Guilbert, blink-...@chromium.org, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Thomas Guilbert.

    Patch set 1:Code-Review +1Commit-Queue +2

    View Change

      To view, visit change 2847990. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I04965ec81e5c782ce597800d87e67b69da963f3f
      Gerrit-Change-Number: 2847990
      Gerrit-PatchSet: 1
      Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
      Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
      Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
      Gerrit-Attention: Thomas Guilbert <tgui...@chromium.org>
      Gerrit-Comment-Date: Fri, 23 Apr 2021 23:40:04 +0000

      Chromium LUCI CQ (Gerrit)

      unread,
      Apr 23, 2021, 8:40:44 PM4/23/21
      to Thomas Guilbert, blink-...@chromium.org, Eugene Zemtsov, chromium...@chromium.org

      Chromium LUCI CQ submitted this change.

      View Change

      Approvals: Eugene Zemtsov: Looks good to me; Commit Thomas Guilbert: Dry run; Looks good to me; Send CL to CQ automatically after approval
      [Sheriff] Disable flaky pointer-lock test

      This is already disabled on Mac. Also disable it on Linux.

      Bug: 1197528
      Change-Id: I04965ec81e5c782ce597800d87e67b69da963f3f
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2847990
      Commit-Queue: Thomas Guilbert <tgui...@chromium.org>
      Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
      Owners-Override: Thomas Guilbert <tgui...@chromium.org>
      Auto-Submit: Thomas Guilbert <tgui...@chromium.org>
      Reviewed-by: Eugene Zemtsov <eug...@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#875936}

      ---
      M third_party/blink/web_tests/TestExpectations
      1 file changed, 1 insertion(+), 0 deletions(-)

      diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations
      index 8d5073c..c77a558 100644

      --- a/third_party/blink/web_tests/TestExpectations
      +++ b/third_party/blink/web_tests/TestExpectations
      @@ -7173,3 +7173,4 @@
      crbug.com/1202051 virtual/scroll-unification/scrollbars/layout-viewport-scrollbars-hidden.html [ Pass Failure ]
      crbug.com/1202051 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/layout-viewport-scrollbars-hidden.html [ Pass Failure ]
      crbug.com/1200751 [ Linux ] fast/peerconnection/RTCPeerConnection-addMultipleTracks.html [ Pass Failure ]
      +crbug.com/1197528 [ Linux ] pointer-lock/pointerlockchange-pointerlockerror-events.html [ Pass Failure ]

      To view, visit change 2847990. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I04965ec81e5c782ce597800d87e67b69da963f3f
      Gerrit-Change-Number: 2847990
      Gerrit-PatchSet: 2
      Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
      Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
      Gerrit-MessageType: merged
      Reply all
      Reply to author
      Forward
      0 new messages