[SVG] Fixed WPT svg/animations/animate-stop-currentcolor-escaped.html [chromium/src : main]

[Virali Purbey (Gerrit)]

Attention needed from Divyansh Mangal, Fredrik Söderquist, Vinay Singh and Virali Purbey

Message from Virali Purbey

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

• Divyansh Mangal
• Fredrik Söderquist
• Vinay Singh
• Virali Purbey

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I7cece83799d744e1b2e1396f1ea2801d58c44c65

Gerrit-Change-Number: 7205449

Gerrit-PatchSet: 16

Gerrit-Owner: Virali Purbey <virali...@microsoft.com>

Gerrit-Reviewer: Divyansh Mangal <dma...@microsoft.com>

Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Vinay Singh <vinay...@microsoft.com>

Gerrit-Reviewer: Virali Purbey <virali...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Vinay Singh <vinay...@microsoft.com>

Gerrit-Attention: Virali Purbey <virali...@microsoft.com>

Gerrit-Attention: Fredrik Söderquist <f...@opera.com>

Gerrit-Attention: Divyansh Mangal <dma...@microsoft.com>

Gerrit-Comment-Date: Tue, 23 Dec 2025 05:33:58 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Divyansh Mangal (Gerrit)]

Attention needed from Fredrik Söderquist, Vinay Singh and Virali Purbey

Divyansh Mangal added 1 comment

File third_party/blink/renderer/core/svg/svg_animated_color.cc

Line 88, Patchset 16 (Latest): CSSTokenizer tokenizer(trimmed_value);
const CSSParserToken token = tokenizer.TokenizeSingle();
if (!token.IsEOF() && token.GetType() == kIdentToken) {
const String identifier = token.Value().ToString();
if (EqualIgnoringASCIICase(identifier, "currentcolor")) {
style_color_ = StyleColor::CurrentColor();
return SVGParseStatus::kNoError;
}
}

Divyansh Mangal . unresolved

I think we want the `currentcolor` check after L:103 so that the color can be parsed first and then we check these fallback cases.

Open in Gerrit

Related details

Attention is currently required from:

Gerrit-Comment-Date: Tue, 23 Dec 2025 08:15:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Virali Purbey (Gerrit)]

Attention needed from Divyansh Mangal, Fredrik Söderquist and Vinay Singh

Virali Purbey added 1 comment

File third_party/blink/renderer/core/svg/svg_animated_color.cc

Line 88, Patchset 16 (Latest): CSSTokenizer tokenizer(trimmed_value);
const CSSParserToken token = tokenizer.TokenizeSingle();
if (!token.IsEOF() && token.GetType() == kIdentToken) {
const String identifier = token.Value().ToString();
if (EqualIgnoringASCIICase(identifier, "currentcolor")) {
style_color_ = StyleColor::CurrentColor();
return SVGParseStatus::kNoError;
}
}

Divyansh Mangal . unresolved

I think we want the `currentcolor` check after L:103 so that the color can be parsed first and then we check these fallback cases.

Virali Purbey

IMO, it should be placed before parsing the string as color. It would be extra effort that is not needed.

Open in Gerrit

Related details

Attention is currently required from:

• Divyansh Mangal
• Fredrik Söderquist
• Vinay Singh

Gerrit-Attention: Fredrik Söderquist <f...@opera.com>

Gerrit-Attention: Divyansh Mangal <dma...@microsoft.com>

Gerrit-Comment-Date: Tue, 23 Dec 2025 12:23:47 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Divyansh Mangal <dma...@microsoft.com>