Instantiate Rust parser in non-frame situations [chromium/src : main]
0 views
Skip to first unread message
Dominik Röttsches (Gerrit)
Dec 18, 2025, 6:24:39 PM (2 days ago) Dec 18
to Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, hiroshig...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, kouhei...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Mason Freed
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Dec 18, 2025, 7:46:31 PM (2 days ago) Dec 18
to Dominik Röttsches, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, hiroshig...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, kouhei...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dominik Röttsches
Mason Freed voted and added 3 comments![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
3 comments
Patchset-level comments
File third_party/blink/renderer/platform/runtime_enabled_features.json5
Line 6195, Patchset 12 (Latest):
name: "XMLParsingRust"
},
{
name: "XMLRustForNonXslt",Mason Freed . unresolved
It'd be good to add some comments to both of these, with bug links and a quick description of what they do.
File third_party/blink/web_tests/external/wpt/domparsing/XMLSerializer-serializeToString-expected.txt
File-level comment, Patchset 12 (Latest):
Mason Freed . unresolved
Do the changes here worry you? One new pass and one new fail, on duplicate namespace declarations. (They seem small to me, and fairly corner case, but I thought I'd ask...)
Related details
Attention is currently required from:
- Dominik Röttsches
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
Dec 19, 2025, 8:13:15 AM (21 hours ago) Dec 19
to Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, hiroshig...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, kouhei...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Dominik Röttsches voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dominik Röttsches
| Commit-Queue | +2 |
2 comments
File third_party/blink/renderer/platform/runtime_enabled_features.json5
Line 6195, Patchset 12:
name: "XMLParsingRust"
},
{
name: "XMLRustForNonXslt",Mason Freed . resolved
It'd be good to add some comments to both of these, with bug links and a quick description of what they do.
Dominik Röttsches
Yes, added descriptions and bug links now.
File third_party/blink/web_tests/external/wpt/domparsing/XMLSerializer-serializeToString-expected.txt
Do the changes here worry you? One new pass and one new fail, on duplicate namespace declarations. (They seem small to me, and fairly corner case, but I thought I'd ask...)
Dominik Röttsches
I consider them a smaller (I agree) edge case, which I started to analyze in https://crbug.com/41445936 - the old parser and the new parser behave slightly different here. I'll follow up on this separately.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 19, 2025, 9:21:44 AM (20 hours ago) Dec 19
to Dominik Röttsches, Mason Freed, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, hiroshig...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, kouhei...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
12 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/platform/runtime_enabled_features.json5
Insertions: 9, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Instantiate Rust parser in non-frame situations
XML parsing use cases through DOMParser and XMLHttpRequest do not
directly implicitly perform XSLT processing. When creating the
document for use with these APIs, the WithExecutionContext DocumentInit
constructor is used instead of the WithWindow constructor. This leads to
the distinction that GetFrame() returns false at the time of parser
construction. So we can run the non XSLT cases through XMLDocumentParser
Rs.
When the document retrieved through DOMParser or XHR is used together
with XSLTProcessor, before this change and after the parsed document is
serialized out to a string and XMLDocPtrForString or
XsltStylesheetPointer are used for re-parsing.
Bug: 466303347
Change-Id: I1c6380e8f88ec60f5eaffa2bd105cd07445d85be
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Dominik Röttsches <dr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1561112}
Files:
- M third_party/blink/renderer/core/dom/document.cc
- M third_party/blink/renderer/core/xml/parser/xml_document_parser_rs.cc
- M third_party/blink/renderer/core/xml/parser/xml_document_parser_test.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/web_tests/external/wpt/domparsing/XMLSerializer-serializeToString-expected.txt
Change size: S
Delta: 5 files changed, 33 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mason Freed
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages