Refactor SVGSMILElement::ParseClockValue [chromium/src : main]
0 views
Skip to first unread message
Fredrik Söderquist (Gerrit)
Apr 10, 2026, 8:18:58 AM (3 days ago) Apr 10
to Divyansh Mangal, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Stephen Chenney, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Divyansh Mangal
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Divyansh Mangal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Divyansh Mangal (Gerrit)
Apr 10, 2026, 1:00:57 PM (3 days ago) Apr 10
to Fredrik Söderquist, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Stephen Chenney, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Fredrik Söderquist
Divyansh Mangal voted and added 1 comment![]( "Open in Gerrit")
Votes added by Divyansh Mangal
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
5:10 AM (5 hours ago) 5:10 AM
to Divyansh Mangal, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Stephen Chenney, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Fredrik Söderquist voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
7:47 AM (2 hours ago) 7:47 AM
to Divyansh Mangal, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Stephen Chenney, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Fredrik Söderquist voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
7:50 AM (2 hours ago) 7:50 AM
to Fredrik Söderquist, Divyansh Mangal, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Stephen Chenney, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Refactor SVGSMILElement::ParseClockValue
Refactor to have a "extract fields" step and then at the end parse the
numbers and convert. Switch to using base::TimeDelta for time
conversions. This should simplify adding additional validation code.
Bug: 499073687
Change-Id: I3722f08823a4d42ac2525a8d01f53bb4bc05bbfd
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Reviewed-by: Divyansh Mangal <dma...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1613632}
Files:
- M third_party/blink/renderer/core/svg/animation/svg_smil_element.cc
Change size: M
Delta: 1 file changed, 45 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Divyansh Mangal
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages