Add blink_platform_unittests filter to Deps. [chromium/src : main]
James Shen (Gerrit)
Attention is currently required from: David Bokan, Koji Ishii.
James Shen would like Koji Ishii and David Bokan to review this change.
Add blink_platform_unittests filter to Deps.
Bug:1303439
Change-Id: Ifec9ad767ae1d054f9d1b938a811cb5d40e6f0aa
---
M third_party/blink/renderer/platform/BUILD.gn
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/third_party/blink/renderer/platform/BUILD.gn b/third_party/blink/renderer/platform/BUILD.gn
index 02aaa74..dcdb110 100644
--- a/third_party/blink/renderer/platform/BUILD.gn
+++ b/third_party/blink/renderer/platform/BUILD.gn
@@ -1952,7 +1952,10 @@
if (is_android) {
# Required because of an indirect dependency on //media/base/android via
# platform/media:unit_tests.
- deps += [ "//media/base/android:media_java" ]
+ deps += [
+ "//media/base/android:media_java",
+ "//testing/buildbot/filters:blink_platform_unittests",
+ ]
}
}
To view, visit change 3730598. To unsubscribe, or for help writing mail filters, visit settings.
James Shen (Gerrit)
Attention is currently required from: David Bokan, Koji Ishii.
Koji Ishii (Gerrit)
Attention is currently required from: David Bokan, James Shen.
Patch set 2:Code-Review +1
2 comments:
Patchset:
lgtm w/nit
File third_party/blink/renderer/platform/BUILD.gn:
# Required because of an indirect dependency on //media/base/android via
# platform/media:unit_tests.
Can you add similar comments why this is included?
To view, visit change 3730598. To unsubscribe, or for help writing mail filters, visit settings.
David Bokan (Gerrit)
Attention is currently required from: James Shen, Koji Ishii.
2 comments:
Commit Message:
Could you add a bit of context here about why this change is needed? It's not immediately clear how this relates to the linked bug.
File third_party/blink/renderer/platform/BUILD.gn:
# Required because of an indirect dependency on //media/base/android via
# platform/media:unit_tests.Can you add similar comments why this is included?
Nit: also, move this comment to be on the line directly above the media_java dependency.
To view, visit change 3730598. To unsubscribe, or for help writing mail filters, visit settings.
James Shen (Gerrit)
Attention is currently required from: James Shen, Koji Ishii.
James Shen uploaded patch set #4 to this change.
Add blink_platform_unittests filter to Deps.
This is to disable broken tests on Android Nougat. We created the filter for blink_platform_unittests, and need to add it to the test target's Deps to get compiled.
Bug:1303439
Change-Id: Ifec9ad767ae1d054f9d1b938a811cb5d40e6f0aa
---
M third_party/blink/renderer/platform/BUILD.gn
1 file changed, 20 insertions(+), 3 deletions(-)
To view, visit change 3730598. To unsubscribe, or for help writing mail filters, visit settings.
James Shen (Gerrit)
Attention is currently required from: David Bokan, Koji Ishii.
2 comments:
Commit Message:
Could you add a bit of context here about why this change is needed? It's not immediately clear how […]
Done. Sure. Add some context in the description. Thanks!
File third_party/blink/renderer/platform/BUILD.gn:
# Required because of an indirect dependency on //media/base/android via
# platform/media:unit_tests.
Nit: also, move this comment to be on the line directly above the media_java dependency.
Done
To view, visit change 3730598. To unsubscribe, or for help writing mail filters, visit settings.
David Bokan (Gerrit)
Attention is currently required from: James Shen, Koji Ishii.
Patch set 5:Code-Review +1
1 comment:
Patchset:
lgtm, thanks!
To view, visit change 3730598. To unsubscribe, or for help writing mail filters, visit settings.
James Shen (Gerrit)
Attention is currently required from: James Shen, Koji Ishii.
Patch set 5:Commit-Queue +2
James Shen (Gerrit)
Attention is currently required from: James Shen, Koji Ishii.
Patch set 6:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Add blink_platform_unittests filter to Deps.
This is to disable broken tests on Android Nougat. We created the filter for blink_platform_unittests, and need to add it to the test target's Deps to get compiled.
Bug: 1303439
Change-Id: Ifec9ad767ae1d054f9d1b938a811cb5d40e6f0aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3730598
Commit-Queue: James Shen <zhiy...@google.com>
Reviewed-by: Koji Ishii <ko...@chromium.org>
Reviewed-by: David Bokan <bo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1019301}
---
M third_party/blink/renderer/platform/BUILD.gn
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/third_party/blink/renderer/platform/BUILD.gn b/third_party/blink/renderer/platform/BUILD.gn
index 04ec73a..1bd408d 100644
--- a/third_party/blink/renderer/platform/BUILD.gn
+++ b/third_party/blink/renderer/platform/BUILD.gn
@@ -1952,9 +1952,14 @@
}
if (is_android) {
- # Required because of an indirect dependency on //media/base/android via
- # platform/media:unit_tests.
- deps += [ "//media/base/android:media_java" ]
+ deps += [
+ # Required because of an indirect dependency on //media/base/android via
+ # platform/media:unit_tests.
+ "//media/base/android:media_java",
+
+ # Required to disable broken tests.
+ "//testing/buildbot/filters:blink_platform_unittests",
+ ]
}
}
To view, visit change 3730598. To unsubscribe, or for help writing mail filters, visit settings.