[blink] feat: add devtools document.cookie performance issue [chromium/src : main]

0 views
Skip to first unread message

gwsq (Gerrit)

unread,
Dec 22, 2025, 10:46:06 AM (6 days ago) Dec 22
to Chanran Lan, Chromium IPC Reviews, Matthew Denton, Dmitry Gozman, Mason Freed, Benedikt Meurer, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Benedikt Meurer, Dmitry Gozman, Mason Freed and Matthew Denton

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mpde...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): mpde...@chromium.org


Reviewer source(s):
mpde...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Benedikt Meurer
  • Dmitry Gozman
  • Mason Freed
  • Matthew Denton
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I43c1cd93008b835393eaa8dc688659237afe1c9b
Gerrit-Change-Number: 7234194
Gerrit-PatchSet: 5
Gerrit-Owner: Chanran Lan <chanr...@gmail.com>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Matthew Denton <mpde...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Matthew Denton <mpde...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Dec 2025 15:45:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Matthew Denton (Gerrit)

unread,
Dec 23, 2025, 6:08:29 PM (5 days ago) Dec 23
to Chanran Lan, Chromium IPC Reviews, Dmitry Gozman, Mason Freed, Benedikt Meurer, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Benedikt Meurer, Chanran Lan, Dmitry Gozman and Mason Freed

Matthew Denton voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Benedikt Meurer
  • Chanran Lan
  • Dmitry Gozman
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I43c1cd93008b835393eaa8dc688659237afe1c9b
Gerrit-Change-Number: 7234194
Gerrit-PatchSet: 7
Gerrit-Owner: Chanran Lan <chanr...@gmail.com>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Matthew Denton <mpde...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
Gerrit-Attention: Chanran Lan <chanr...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 23:08:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Benedikt Meurer (Gerrit)

unread,
3:55 AM (6 hours ago) 3:55 AM
to Chanran Lan, Danil Somsikov, Matthew Denton, Chromium IPC Reviews, Dmitry Gozman, Mason Freed, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Chanran Lan, Danil Somsikov, Dmitry Gozman and Mason Freed

Benedikt Meurer added 1 comment

File third_party/blink/public/devtools_protocol/domains/Audits.pdl
Line 109, Patchset 7 (Latest):
Benedikt Meurer . unresolved

Please fix this WARNING reported by Trailing Whitespace: Please remove the trailing whitespace.

Please remove the trailing whitespace.

Open in Gerrit

Related details

Attention is currently required from:
  • Chanran Lan
  • Danil Somsikov
  • Dmitry Gozman
  • Mason Freed
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I43c1cd93008b835393eaa8dc688659237afe1c9b
    Gerrit-Change-Number: 7234194
    Gerrit-PatchSet: 7
    Gerrit-Owner: Chanran Lan <chanr...@gmail.com>
    Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Matthew Denton <mpde...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Attention: Chanran Lan <chanr...@gmail.com>
    Gerrit-Attention: Danil Somsikov <d...@chromium.org>
    Gerrit-Comment-Date: Sun, 28 Dec 2025 08:55:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages