[A11y] Repair names for tabbable elements only if focused [chromium/src : main]

0 views
Skip to first unread message

Di Zhang (Gerrit)

unread,
Oct 30, 2024, 6:04:06 PM10/30/24
to Aaron Leventhal, David Tseng, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Aaron Leventhal and David Tseng

Di Zhang added 1 comment

File third_party/blink/renderer/modules/accessibility/ax_node_object.cc
Line 1973, Patchset 9 (Latest): if (GetElement()->FastHasAttribute(html_names::kTabindexAttr)) {
Di Zhang . unresolved

This would return true even if tabindex is negative.

Maybe what you are looking for is `GetElement()->IsFocusable(Element::UpdateBehavior::kNoneForAccessibility)` if you want to skip the check for IsScrollerKeyboardFocusable().

Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Leventhal
  • David Tseng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib90f2175b74c2149109b14205bdac3ee7388972a
Gerrit-Change-Number: 5979028
Gerrit-PatchSet: 9
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: David Tseng <dts...@chromium.org>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: David Tseng <dts...@chromium.org>
Gerrit-Attention: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Comment-Date: Wed, 30 Oct 2024 22:03:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Aaron Leventhal (Gerrit)

unread,
Oct 30, 2024, 6:08:28 PM10/30/24
to Di Zhang, David Tseng, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from David Tseng and Di Zhang

Aaron Leventhal added 1 comment

File third_party/blink/renderer/modules/accessibility/ax_node_object.cc
Line 1973, Patchset 9 (Latest): if (GetElement()->FastHasAttribute(html_names::kTabindexAttr)) {
Di Zhang . resolved

This would return true even if tabindex is negative.

Maybe what you are looking for is `GetElement()->IsFocusable(Element::UpdateBehavior::kNoneForAccessibility)` if you want to skip the check for IsScrollerKeyboardFocusable().

Aaron Leventhal

We specifically want to just check for tabindex based on how the HTML-AAM spec is handling it. Other focusable elements already will have a reasonable role.

Open in Gerrit

Related details

Attention is currently required from:
  • David Tseng
  • Di Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib90f2175b74c2149109b14205bdac3ee7388972a
Gerrit-Change-Number: 5979028
Gerrit-PatchSet: 9
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: David Tseng <dts...@chromium.org>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: David Tseng <dts...@chromium.org>
Gerrit-Attention: Di Zhang <dizh...@chromium.org>
Gerrit-Comment-Date: Wed, 30 Oct 2024 22:08:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Di Zhang <dizh...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Di Zhang (Gerrit)

unread,
Oct 30, 2024, 6:26:02 PM10/30/24
to Aaron Leventhal, David Tseng, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Aaron Leventhal and David Tseng

Di Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Leventhal
  • David Tseng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib90f2175b74c2149109b14205bdac3ee7388972a
Gerrit-Change-Number: 5979028
Gerrit-PatchSet: 9
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: David Tseng <dts...@chromium.org>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: David Tseng <dts...@chromium.org>
Gerrit-Attention: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Comment-Date: Wed, 30 Oct 2024 22:25:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Aaron Leventhal (Gerrit)

unread,
Oct 30, 2024, 6:50:55 PM10/30/24
to Benjamin Beaudry, Jacob Francis, Di Zhang, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Benjamin Beaudry and Jacob Francis

Aaron Leventhal added 1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Aaron Leventhal . resolved

Ben, can you give this an overall review?
Jacob, can you review the test change for ChromeVox?

Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Beaudry
  • Jacob Francis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib90f2175b74c2149109b14205bdac3ee7388972a
Gerrit-Change-Number: 5979028
Gerrit-PatchSet: 9
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Jacob Francis <fran...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Attention: Jacob Francis <fran...@google.com>
Gerrit-Comment-Date: Wed, 30 Oct 2024 22:50:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Benjamin Beaudry (Gerrit)

unread,
Oct 30, 2024, 6:59:22 PM10/30/24
to Aaron Leventhal, Jacob Francis, Di Zhang, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Aaron Leventhal and Jacob Francis

Benjamin Beaudry voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Leventhal
  • Jacob Francis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib90f2175b74c2149109b14205bdac3ee7388972a
Gerrit-Change-Number: 5979028
Gerrit-PatchSet: 10
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Jacob Francis <fran...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Jacob Francis <fran...@google.com>
Gerrit-Attention: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Comment-Date: Wed, 30 Oct 2024 22:59:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Aaron Leventhal (Gerrit)

unread,
Oct 30, 2024, 7:00:59 PM10/30/24
to Benjamin Beaudry, Jacob Francis, Di Zhang, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Jacob Francis

Aaron Leventhal voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jacob Francis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib90f2175b74c2149109b14205bdac3ee7388972a
Gerrit-Change-Number: 5979028
Gerrit-PatchSet: 11
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Jacob Francis <fran...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Jacob Francis <fran...@google.com>
Gerrit-Comment-Date: Wed, 30 Oct 2024 23:00:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jacob Francis (Gerrit)

unread,
Oct 30, 2024, 7:02:18 PM10/30/24
to Aaron Leventhal, Benjamin Beaudry, Di Zhang, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Aaron Leventhal

Jacob Francis voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Leventhal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib90f2175b74c2149109b14205bdac3ee7388972a
Gerrit-Change-Number: 5979028
Gerrit-PatchSet: 11
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Jacob Francis <fran...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Comment-Date: Wed, 30 Oct 2024 23:02:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Aaron Leventhal (Gerrit)

unread,
Oct 30, 2024, 7:07:55 PM10/30/24
to Koji Ishii, Jacob Francis, Benjamin Beaudry, Di Zhang, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Jacob Francis and Koji Ishii

Aaron Leventhal added 1 comment

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Aaron Leventhal . resolved

Hi Koji, could you PTAL at t/b/p/a/text-changes-unignored-in-focusable-scrollable.html ? It's a new perf test. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Jacob Francis
  • Koji Ishii
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib90f2175b74c2149109b14205bdac3ee7388972a
Gerrit-Change-Number: 5979028
Gerrit-PatchSet: 11
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Jacob Francis <fran...@google.com>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Attention: Jacob Francis <fran...@google.com>
Gerrit-Comment-Date: Wed, 30 Oct 2024 23:07:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Aaron Leventhal (Gerrit)

unread,
Oct 30, 2024, 9:48:37 PM10/30/24
to Koji Ishii, Jacob Francis, Benjamin Beaudry, Di Zhang, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Benjamin Beaudry, Di Zhang, Jacob Francis and Koji Ishii

Aaron Leventhal voted and added 1 comment

Votes added by Aaron Leventhal

Auto-Submit+0

1 comment

Patchset-level comments
File-level comment, Patchset 12 (Latest):
Aaron Leventhal . resolved

Hi all, I need new +1s -- I lost it because of a test file change for Android.

Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Beaudry
  • Di Zhang
  • Jacob Francis
  • Koji Ishii
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib90f2175b74c2149109b14205bdac3ee7388972a
Gerrit-Change-Number: 5979028
Gerrit-PatchSet: 12
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Jacob Francis <fran...@google.com>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Attention: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Attention: Di Zhang <dizh...@chromium.org>
Gerrit-Attention: Jacob Francis <fran...@google.com>
Gerrit-Comment-Date: Thu, 31 Oct 2024 01:48:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Aaron Leventhal (Gerrit)

unread,
Oct 31, 2024, 11:54:30 AM10/31/24
to Nico Weber, Koji Ishii, Jacob Francis, Benjamin Beaudry, Di Zhang, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Benjamin Beaudry, Di Zhang, Jacob Francis, Koji Ishii and Nico Weber

Aaron Leventhal added 1 comment

Patchset-level comments
File-level comment, Patchset 13 (Latest):
Aaron Leventhal . resolved

Hi Nico, PTAL at the new perf test third_party/blink/perf_tests/accessibility/text-changes-unignored-in-focusable-scrollable.html

Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Beaudry
  • Di Zhang
  • Jacob Francis
  • Koji Ishii
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib90f2175b74c2149109b14205bdac3ee7388972a
Gerrit-Change-Number: 5979028
Gerrit-PatchSet: 13
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Jacob Francis <fran...@google.com>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Attention: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Attention: Di Zhang <dizh...@chromium.org>
Gerrit-Attention: Jacob Francis <fran...@google.com>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Thu, 31 Oct 2024 15:54:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jacob Francis (Gerrit)

unread,
Oct 31, 2024, 12:00:15 PM10/31/24
to Aaron Leventhal, Nico Weber, Koji Ishii, Benjamin Beaudry, Di Zhang, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Aaron Leventhal, Benjamin Beaudry, Di Zhang, Koji Ishii and Nico Weber

Jacob Francis voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Leventhal
  • Benjamin Beaudry
  • Di Zhang
  • Koji Ishii
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Gerrit-Attention: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Thu, 31 Oct 2024 16:00:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Benjamin Beaudry (Gerrit)

unread,
Oct 31, 2024, 12:25:34 PM10/31/24
to Aaron Leventhal, Jacob Francis, Nico Weber, Koji Ishii, Di Zhang, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Aaron Leventhal, Di Zhang, Koji Ishii and Nico Weber

Benjamin Beaudry voted and added 1 comment

Votes added by Benjamin Beaudry

Code-Review+1

1 comment

Patchset-level comments
Benjamin Beaudry . resolved

still lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Leventhal
Gerrit-Attention: Di Zhang <dizh...@chromium.org>
Gerrit-Attention: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Thu, 31 Oct 2024 16:25:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Koji Ishii (Gerrit)

unread,
Nov 1, 2024, 1:41:42 AM11/1/24
to Aaron Leventhal, Benjamin Beaudry, Jacob Francis, Nico Weber, Di Zhang, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Aaron Leventhal, Di Zhang and Nico Weber

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Code-Review+1

1 comment

Patchset-level comments
Koji Ishii . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Leventhal
  • Di Zhang
  • Nico Weber
Gerrit-Attention: Di Zhang <dizh...@chromium.org>
Gerrit-Attention: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Fri, 01 Nov 2024 05:41:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Aaron Leventhal (Gerrit)

unread,
Nov 1, 2024, 10:34:31 AM11/1/24
to Koji Ishii, Benjamin Beaudry, Jacob Francis, Nico Weber, Di Zhang, Zijie He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Di Zhang and Nico Weber

Aaron Leventhal voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Di Zhang
  • Nico Weber
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Fri, 01 Nov 2024 14:34:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 1, 2024, 12:38:49 PM11/1/24
to Aaron Leventhal, Koji Ishii, Benjamin Beaudry, Jacob Francis, Nico Weber, Di Zhang, Zijie He, AyeAye, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, oshima...@chromium.org, fuchsia...@chromium.org, dtseng+c...@chromium.org, chromium-a...@chromium.org, anastas...@google.com, katie...@chromium.org, hirokisa...@chromium.org, shannc...@chromium.org, extension...@chromium.org, rrsilva+wat...@google.com, abigailbk...@google.com, aleventhal...@chromium.org, biciogl...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[A11y] Repair names for tabbable elements only if focused

This fixes a performance regression that occurs with the
KeyboardFocusableScrollers feature.

In some cases we repair accessible names for elements that
are keyboard-focusable but are missing a name. That way, the user
will hear something other than silence as they tab to the object.
However, it's not actually necessary to repair the name for every
tabbable object, just the one that receives focus. In fact,
it's arguably harmful to included it for every object as a repaired
name from contents can create very large names in the case of regions,
and only serves to cause redundant announcements when visited with
the virtual buffer.

In addition, our name repairs should not depend on Element::IsKeyboardFocusable() which can be very slow, as it needs
to check whether there are keyboard-focusable descendants before
returning true for a scrollable region (if there are
keyboard-focusable descendants, it will return false). This is not
an issue where it's used for tab navigation, but if we are making
the call many times in a row in can be very slow. That was the case
when walked ancestors for every DOM change to determine whether any
ancestor has a name change. Each call to SupportsNameFromContents()
could potentially need to call the slow IsKeyboardFocusable()
method for any scrollable region.

To fix both issues, this CL removes a11y use of
Element::IsKeyboardFocusable() and instead computes the name
for scrollable regions only when they are focused.

In addition, this CL removes AXObject::IsKeyboardFocusable() which
already was not being used.
Bug: 375185771, 375937552, 375352863
Change-Id: Ib90f2175b74c2149109b14205bdac3ee7388972a
Reviewed-by: Jacob Francis <fran...@google.com>
Reviewed-by: Benjamin Beaudry <benjamin...@microsoft.com>
Commit-Queue: Aaron Leventhal <aleve...@chromium.org>
Reviewed-by: Koji Ishii <ko...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1376917}
Files:
  • M chrome/browser/resources/chromeos/accessibility/chromevox/background/output/output_test.js
  • M chrome/test/data/extensions/api_test/automation/sites/tree_change.html
  • M content/test/data/accessibility/aria/aria-hidden-expected-blink.txt
  • M content/test/data/accessibility/aria/aria-roledescription-expected-auralinux.txt
  • M content/test/data/accessibility/aria/aria-roledescription-expected-blink.txt
  • M content/test/data/accessibility/aria/aria-roledescription-expected-mac.txt
  • M content/test/data/accessibility/aria/aria-roledescription-expected-uia-win.txt
  • M content/test/data/accessibility/aria/aria-roledescription-expected-win.txt
  • M content/test/data/accessibility/aria/aria-subscript-expected-android-external.txt
  • M content/test/data/accessibility/aria/aria-subscript-expected-android.txt
  • M content/test/data/accessibility/aria/aria-subscript-expected-auralinux.txt
  • M content/test/data/accessibility/aria/aria-subscript-expected-blink.txt
  • M content/test/data/accessibility/aria/aria-subscript-expected-mac.txt
  • M content/test/data/accessibility/aria/aria-subscript-expected-uia-win.txt
  • M content/test/data/accessibility/aria/aria-subscript-expected-win.txt
  • M content/test/data/accessibility/event/menubar-show-hide-menus-expected-uia-win.txt
  • M content/test/data/accessibility/event/scroll-horizontal-scroll-percent-change-expected-uia-win.txt
  • M content/test/data/accessibility/event/scroll-horizontal-scroll-percent-change-expected-win.txt
  • M content/test/data/accessibility/event/scroll-vertical-scroll-percent-change-expected-uia-win.txt
  • M content/test/data/accessibility/event/scroll-vertical-scroll-percent-change-expected-win.txt
  • M content/test/data/accessibility/event/tabindex-added-on-aria-hidden-expected-win.txt
  • M content/test/data/accessibility/event/tabindex-removed-on-aria-hidden-expected-win.txt
  • M content/test/data/accessibility/event/text-selection-inside-hidden-element-expected-android.txt
  • M content/test/data/accessibility/event/text-selection-inside-hidden-element-expected-auralinux.txt
  • M content/test/data/accessibility/html/div-expected-auralinux.txt
  • M content/test/data/accessibility/html/div-expected-blink.txt
  • M content/test/data/accessibility/html/div-expected-fuchsia.txt
  • M content/test/data/accessibility/html/div-expected-mac.txt
  • M content/test/data/accessibility/html/div-expected-uia-win.txt
  • M content/test/data/accessibility/html/div-expected-win.txt
  • M content/test/data/accessibility/html/inert-attribute-expected-blink.txt
  • M content/test/data/accessibility/html/input-radio-checkbox-label-expected-android-external.txt
  • M content/test/data/accessibility/html/input-radio-checkbox-label-expected-android.txt
  • M content/test/data/accessibility/html/input-radio-checkbox-label-expected-auralinux.txt
  • M content/test/data/accessibility/html/input-radio-checkbox-label-expected-blink.txt
  • M content/test/data/accessibility/html/input-radio-checkbox-label-expected-mac.txt
  • M content/test/data/accessibility/html/input-radio-checkbox-label-expected-uia-win.txt
  • M content/test/data/accessibility/html/input-radio-checkbox-label-expected-win.txt
  • M content/test/data/accessibility/html/min-role-expected-blink.txt
  • M content/test/data/accessibility/html/min-role-tabbable-group-expected-blink.txt
  • M content/test/data/accessibility/html/min-role-tabbable-group.html
  • M content/test/data/accessibility/html/name-calc-focusable-expected-blink.txt
  • M content/test/data/accessibility/html/overflow-actions-expected-android-external.txt
  • M content/test/data/accessibility/html/overflow-actions-expected-android.txt
  • M content/test/data/accessibility/html/overflow-actions-expected-fuchsia.txt
  • M content/test/data/accessibility/html/overflow-scroller-expected-blink.txt
  • M content/test/data/accessibility/html/scrollable-overflow-expected-android-external.txt
  • M content/test/data/accessibility/html/scrollable-overflow-expected-android.txt
  • M content/test/data/accessibility/html/scrollable-overflow-expected-auralinux.txt
  • M content/test/data/accessibility/html/scrollable-overflow-expected-blink.txt
  • M content/test/data/accessibility/html/scrollable-overflow-expected-fuchsia.txt
  • M content/test/data/accessibility/html/scrollable-overflow-expected-uia-win.txt
  • M content/test/data/accessibility/html/sub-expected-android-external.txt
  • M content/test/data/accessibility/html/sub-expected-android.txt
  • M content/test/data/accessibility/html/sub-expected-auralinux.txt
  • M content/test/data/accessibility/html/sub-expected-blink.txt
  • M content/test/data/accessibility/html/sub-expected-fuchsia.txt
  • M content/test/data/accessibility/html/sub-expected-mac.txt
  • M content/test/data/accessibility/html/sub-expected-uia-win.txt
  • M content/test/data/accessibility/html/sub-expected-win.txt
  • M content/test/data/accessibility/html/svg-with-non-link-anchors-expected-auralinux.txt
  • M content/test/data/accessibility/html/svg-with-non-link-anchors-expected-blink.txt
  • M content/test/data/accessibility/html/svg-with-non-link-anchors-expected-fuchsia.txt
  • M content/test/data/accessibility/html/tabindex-expose-children-expected-android-external.txt
  • M content/test/data/accessibility/html/tabindex-expose-children-expected-android.txt
  • M content/test/data/accessibility/html/tabindex-expose-children-expected-auralinux.txt
  • M content/test/data/accessibility/html/tabindex-expose-children-expected-blink.txt
  • M content/test/data/accessibility/html/tabindex-expose-children-expected-fuchsia.txt
  • M content/test/data/accessibility/html/tabindex-expose-children-expected-mac.txt
  • M content/test/data/accessibility/html/tabindex-expose-children-expected-uia-win.txt
  • M content/test/data/accessibility/html/tabindex-expose-children-expected-win.txt
  • A third_party/blink/perf_tests/accessibility/text-changes-unignored-in-focusable-scrollable.html
  • M third_party/blink/renderer/modules/accessibility/ax_node_object.cc
  • M third_party/blink/renderer/modules/accessibility/ax_object.cc
  • M third_party/blink/renderer/modules/accessibility/ax_object.h
  • M third_party/blink/web_tests/accessibility/canvas-fallback-content-2.html
Change size: L
Delta: 76 files changed, 271 insertions(+), 174 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Koji Ishii, +1 by Benjamin Beaudry, +1 by Jacob Francis
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib90f2175b74c2149109b14205bdac3ee7388972a
Gerrit-Change-Number: 5979028
Gerrit-PatchSet: 14
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Jacob Francis <fran...@google.com>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages