[RouteLocation] Parse link-href correctly. [chromium/src : main]

1 view
Skip to first unread message

Morten Stenshorne (Gerrit)

unread,
Jun 12, 2026, 5:48:05 PMJun 12
to Rune Lillesveen, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Noam Rosenthal and Rune Lillesveen

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Noam Rosenthal
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5fb8a1dc2d5c21cb10d1526bc18f2c584b974e28
Gerrit-Change-Number: 7928950
Gerrit-PatchSet: 3
Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Fri, 12 Jun 2026 21:47:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Jun 15, 2026, 4:16:30 AM (13 days ago) Jun 15
to Morten Stenshorne, Rune Lillesveen, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Morten Stenshorne and Noam Rosenthal

Rune Lillesveen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
  • Noam Rosenthal
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5fb8a1dc2d5c21cb10d1526bc18f2c584b974e28
    Gerrit-Change-Number: 7928950
    Gerrit-PatchSet: 3
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
    Gerrit-Comment-Date: Mon, 15 Jun 2026 08:16:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Morten Stenshorne (Gerrit)

    unread,
    Jun 15, 2026, 5:22:39 AM (13 days ago) Jun 15
    to Rune Lillesveen, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
    Attention needed from Noam Rosenthal

    Morten Stenshorne voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Noam Rosenthal
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5fb8a1dc2d5c21cb10d1526bc18f2c584b974e28
    Gerrit-Change-Number: 7928950
    Gerrit-PatchSet: 3
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
    Gerrit-Comment-Date: Mon, 15 Jun 2026 09:22:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 15, 2026, 6:24:33 AM (13 days ago) Jun 15
    to Morten Stenshorne, Rune Lillesveen, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [RouteLocation] Parse link-href correctly.

    It actually didn't work at all. "link-href" was recognized but not
    consumed. Also make it case-insensitive, and fix serialization.
    Bug: 436805487
    Change-Id: I5fb8a1dc2d5c21cb10d1526bc18f2c584b974e28
    Reviewed-by: Rune Lillesveen <fut...@chromium.org>
    Commit-Queue: Morten Stenshorne <mste...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1646694}
    Files:
    • M third_party/blink/renderer/core/css/active_navigation_condition.cc
    • M third_party/blink/renderer/core/css/parser/css_selector_parser.cc
    • A third_party/blink/web_tests/wpt_internal/route/parsing/active-navigation-valid.html
    Change size: S
    Delta: 3 files changed, 33 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Rune Lillesveen
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5fb8a1dc2d5c21cb10d1526bc18f2c584b974e28
    Gerrit-Change-Number: 7928950
    Gerrit-PatchSet: 4
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages