Alex Rudenko (Gerrit)

unread,

Jul 1, 2026, 6:52:02 AM (5 days ago) Jul 1

to Julio Piubello, Yang Guo, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, devtools...@chromium.org

Attention needed from Julio Piubello and Yang Guo

Alex Rudenko added 4 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Alex Rudenko . resolved

The chrome/browser/devtools code looks good to me but I think someone familiar with Android implementation needs to take a look. I have only had a few questions about test expectations.

File third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/bidi/browser/get_client_windows/get_client_windows-expected.txt

Line 2, Patchset 6 (Latest):[PASS FAIL] test_activate_client_windows

Alex Rudenko . unresolved

is this test flaky now?

File third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/bidi/browsing_context/activate/activate-expected.txt

Line 2, Patchset 6 (Latest):[PASS FAIL] test_switch_between_contexts[tab]

Alex Rudenko . unresolved

is this flaky now?

Line 5, Patchset 6 (Latest): AssertionError

Alex Rudenko . unresolved

there still seems to be an error, as well as for test_multiple_activation, what is the reason for this?

Open in Gerrit

Related details

Attention is currently required from:

Julio Piubello
Yang Guo

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Julio Piubello (Gerrit)

unread,

Jul 3, 2026, 3:45:38 AM (3 days ago) Jul 3

to Peter Wen, Mei Liang, Alex Rudenko, Yang Guo, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, devtools...@chromium.org

Attention needed from Alex Rudenko, Mei Liang, Peter Wen and Yang Guo

Julio Piubello added 3 comments

File third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/bidi/browser/get_client_windows/get_client_windows-expected.txt

Line 2, Patchset 6 (Latest):[PASS FAIL] test_activate_client_windows

Alex Rudenko . resolved

is this test flaky now?

Julio Piubello

I reran this with --repeat-each 10 on Android and did not observe a pass. The test now gets past the previously broken windowState path, but still fails consistently on Android activation state

File third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/bidi/browsing_context/activate/activate-expected.txt

Line 2, Patchset 6 (Latest):[PASS FAIL] test_switch_between_contexts[tab]

Alex Rudenko . resolved

is this flaky now?

Julio Piubello

I reran the same test on the parent with --repeat-each 10 and saw both PASS and FAIL on main, the flakyness was already there, I updated to match the behavior but if u prefer to keep the CL narrower I can leave it as FAIL, but it would still have a known unexpected-pass

Line 5, Patchset 6 (Latest): AssertionError

Alex Rudenko . resolved

there still seems to be an error, as well as for test_multiple_activation, what is the reason for this?

Julio Piubello

The remaining test_switch_between_contexts[window] failure is the existing Android focus/visibility behavior. The parent shows the same failure; this CL just fixes the Browser window bounds path enough for the test to reach that assertion.

test_multiple_activation was incorrectly listed in the expectation file. It passes repeatedly on both parent and this patch, so I removed that expectation

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Mei Liang
Peter Wen
Yang Guo

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

Jul 3, 2026, 4:02:26 AM (3 days ago) Jul 3

to Julio Piubello, Peter Wen, Mei Liang, Yang Guo, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, devtools...@chromium.org

Attention needed from Julio Piubello, Mei Liang, Peter Wen and Yang Guo

Alex Rudenko voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Julio Piubello

Mei Liang
Peter Wen
Yang Guo

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Peter Wen (Gerrit)

unread,

10:10 AM (3 hours ago) 10:10 AM

to Julio Piubello, Alex Rudenko, Mei Liang, Yang Guo, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, devtools...@chromium.org

Attention needed from Julio Piubello, Mei Liang and Yang Guo

Peter Wen added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Peter Wen . resolved

Leaving review to meiliang@, please add me if needed / for other uncovered files.

Open in Gerrit

Related details

Attention is currently required from:

Julio Piubello
Mei Liang
Yang Guo

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Implement Android Browser.getWindowBounds [chromium/src : main]

Alex Rudenko (Gerrit)

Alex Rudenko added 4 comments

Related details

Julio Piubello (Gerrit)

Julio Piubello added 3 comments

Related details

Alex Rudenko (Gerrit)

Alex Rudenko voted Code-Review+1

Related details

Peter Wen (Gerrit)

Peter Wen added 1 comment

Related details