[M150] [Blink] Guard user activation against empty IME events [chromium/src : refs/branch-heads/7871]
0 views
Skip to first unread message
chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com (Gerrit)
7:34 AM (7 hours ago) 7:34 AM
to Thomas Anderson, android-bu...@system.gserviceaccount.com, blink-...@chromium.org
chrome-che...@chops-service-accounts.iam.gserviceaccount.com voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
7:35 AM (7 hours ago) 7:35 AM
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Thomas Anderson, android-bu...@system.gserviceaccount.com, blink-...@chromium.org
Message from rubber-...@appspot.gserviceaccount.com![]( "Open in Gerrit")
The change is not in the configured time window. Rubber Stamper is only allowed to review cherry-picks within 14 day(s). Learn more: go/rubber-stamper-user-guide.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Yip (Gerrit)
9:57 AM (5 hours ago) 9:57 AM
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Thomas Anderson, Ian Kilpatrick, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-...@chromium.org
Attention needed from Ian Kilpatrick and Thomas Anderson
Daniel Yip voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Ian Kilpatrick
- Thomas Anderson
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Mason (Gerrit)
10:02 AM (5 hours ago) 10:02 AM
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Thomas Anderson, Daniel Yip, Ian Kilpatrick, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-...@chromium.org
Attention needed from Daniel Yip, Ian Kilpatrick and Thomas Anderson
Ben Mason voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Yip
- Ian Kilpatrick
- Thomas Anderson
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Yip (Gerrit)
10:03 AM (4 hours ago) 10:03 AM
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Thomas Anderson, Ben Mason, Ian Kilpatrick, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-...@chromium.org
Attention needed from Ian Kilpatrick and Thomas Anderson
Daniel Yip voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Ian Kilpatrick
- Thomas Anderson
Mohamed Amir Yosef (Gerrit)
10:46 AM (4 hours ago) 10:46 AM
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Thomas Anderson, Ben Mason, Daniel Yip, Ian Kilpatrick, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-...@chromium.org
Attention needed from Ian Kilpatrick and Thomas Anderson
Mohamed Amir Yosef voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Ian Kilpatrick
- Thomas Anderson
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
11:20 AM (3 hours ago) 11:20 AM
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Mohamed Amir Yosef, Ben Mason, Daniel Yip, Ian Kilpatrick, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-...@chromium.org
Attention needed from Ian Kilpatrick
Thomas Anderson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:02 PM (2 hours ago) 12:02 PM
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Thomas Anderson, Mohamed Amir Yosef, Ben Mason, Daniel Yip, Ian Kilpatrick, android-bu...@system.gserviceaccount.com, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M150] [Blink] Guard user activation against empty IME events
Original change's description:
> [Blink] Guard user activation against empty IME events
>
> On Linux platforms, window focus events trigger the display server or
> compositor (via IME frameworks like IBus/Fcitx or zwp_text_input_v3) to
> send state-clearing preedit/reset events with an empty string.
>
> Historically, WebInputMethodControllerImpl::SetComposition and
> CommitText unconditionally triggered local frame UserActivation (with
> kInteraction), allowing window focus/creation to erroneously grant
> transient and sticky user activation. This bypassed user gesture
> security checks and enabled silent password exfiltration under XSS.
>
> This CL prevents user activation from triggering when the incoming IME
> text is empty. We also add a unit test to verify that empty IME
> composition and commit events do not elevate user activation, while
> non-empty events do.
>
> Bug: 504600482
> Change-Id: I82444a21888d4e61fe1a8cf75871ed47b18d1aef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7868631
> Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
> Auto-Submit: Thomas Anderson <thomasa...@chromium.org>
> Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1639820}
(cherry picked from commit 3be8f92c7e8368b5454a9392da0fdbbc9b39bc74)
Bug: 527774340,504600482
Change-Id: I82444a21888d4e61fe1a8cf75871ed47b18d1aef
Reviewed-by: Ben Mason <benm...@chromium.org>
Auto-Submit: chrome-che...@chops-service-accounts.iam.gserviceaccount.com <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Mohamed Amir Yosef <ma...@chromium.org>
Commit-Queue: Daniel Yip <dani...@google.com>
Reviewed-by: Daniel Yip <dani...@google.com>
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Owners-Override: Daniel Yip <dani...@google.com>
Reviewed-by: Mohamed Amir Yosef <ma...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7871@{#2888}
Cr-Branched-From: f542126b8c1b3e80104b26bb05ec830bd1206f29-refs/heads/main@{#1639810}
Files:
- M third_party/blink/renderer/core/exported/web_input_method_controller_impl.cc
- M third_party/blink/renderer/core/exported/web_view_test.cc
Change size: M
Delta: 2 files changed, 56 insertions(+), 4 deletions(-)
Branch: refs/branch-heads/7871
Submit Requirements:
Code-Review: +1 by Mohamed Amir Yosef, +1 by Daniel Yip, +1 by Thomas Anderson, +1 by Ben Mason
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages