Create SmartCardEmulation domain definition. [chromium/src : main]
Paulina Gacek (Gerrit)
Paulina Gacek voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Zgroza (Luke) Klimek
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zgroza (Luke) Klimek (Gerrit)
Zgroza (Luke) Klimek added 3 comments![]( "Open in Gerrit")
General comment: can You expand comments here with names and links to the particular native functions implemented by this those? Ideally every call that maps to PC/SC call should have adequate links to its equivalent in those 2 documentation:
- https://pcsclite.apdu.fr/api/group__API.html (PC/SC Lite)
- https://learn.microsoft.com/en-us/windows/win32/api/winscard/ (PC/SC by Microsoft)
# Reports the result of a call that returns only a result codeCan You expand this comment with a list of calls that can result with this?
Related details
- Paulina Gacek
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paulina Gacek (Gerrit)
Paulina Gacek added 2 comments![]( "Open in Gerrit")
General comment: can You expand comments here with names and links to the particular native functions implemented by this those? Ideally every call that maps to PC/SC call should have adequate links to its equivalent in those 2 documentation:
- https://pcsclite.apdu.fr/api/group__API.html (PC/SC Lite)
- https://learn.microsoft.com/en-us/windows/win32/api/winscard/ (PC/SC by Microsoft)
Done
# Reports the result of a call that returns only a result codeCan You expand this comment with a list of calls that can result with this?
- Zgroza (Luke) Klimek
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zgroza (Luke) Klimek (Gerrit)
Zgroza (Luke) Klimek added 2 comments![]( "Open in Gerrit")
Nit: maybe a wording like this one, here and elsewhere?
```suggestion
#
# This maps to:
# PC/SC Lite: https://pcsclite.apdu.fr/api/group__ErrorCodes.html
# Win32 API: https://learn.microsoft.com/en-us/windows/win32/secauthn/authentication-return-values
```
type Disposition extends stringThose also map to the values here: https://learn.microsoft.com/en-us/windows/win32/api/winscard/nf-winscard-scarddisconnect#parameters
(applies also to similar enums below)
Can You add links for those as well?
Related details
- Paulina Gacek
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paulina Gacek (Gerrit)
Paulina Gacek added 2 comments![]( "Open in Gerrit")
Nit: maybe a wording like this one, here and elsewhere?
```suggestion
#
# This maps to:
# PC/SC Lite: https://pcsclite.apdu.fr/api/group__ErrorCodes.html
# Win32 API: https://learn.microsoft.com/en-us/windows/win32/secauthn/authentication-return-values
```
Done
type Disposition extends stringThose also map to the values here: https://learn.microsoft.com/en-us/windows/win32/api/winscard/nf-winscard-scarddisconnect#parameters
(applies also to similar enums below)
Can You add links for those as well?
I also saw this, but these definitions don't have their own dedicated sections - the link you provided links to parameters of disconnect.
Related details
- Zgroza (Luke) Klimek
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zgroza (Luke) Klimek (Gerrit)
Zgroza (Luke) Klimek voted and added 1 comment![]( "Open in Gerrit")
Votes added by Zgroza (Luke) Klimek
| Code-Review | +1 |
1 comment
type Disposition extends stringPaulina GacekThose also map to the values here: https://learn.microsoft.com/en-us/windows/win32/api/winscard/nf-winscard-scarddisconnect#parameters
(applies also to similar enums below)
Can You add links for those as well?
I also saw this, but these definitions don't have their own dedicated sections - the link you provided links to parameters of disconnect.
Hm, maybe it's alright anyway, there are links to functions that use those.
Related details
- Paulina Gacek
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Nico Weber added 1 comment![]( "Open in Gerrit")
replacing myself with a third_party/blink/public/devtools_protocol/OWNER
Related details
- Alex Rudenko
- Paulina Gacek
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Jeremy Roman added 1 comment![]( "Open in Gerrit")
Is anyone in devtools_protocol/OWNERS available? I don't know this super well, so while it seems reasonable to me, I wouldn't necessarily know what to look out for here.
Related details
- Paulina Gacek
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paulina Gacek (Gerrit)
Paulina Gacek added 1 comment![]( "Open in Gerrit")
Is anyone in devtools_protocol/OWNERS available? I don't know this super well, so while it seems reasonable to me, I wouldn't necessarily know what to look out for here.
- Andrey Kosyakov
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paulina Gacek (Gerrit)
Paulina Gacek added 1 comment![]( "Open in Gerrit")
Paulina GacekIs anyone in devtools_protocol/OWNERS available? I don't know this super well, so while it seems reasonable to me, I wouldn't necessarily know what to look out for here.
I can try
I added the owner, thanks!
Andrey Kosyakov (Gerrit)
Andrey Kosyakov added 11 comments![]( "Open in Gerrit")
Mostly looks good, but here are some API suggestions.
unknownHow is this different from unknown-error?
type Protocols extends objectnit: ProtocolSet to further disambiguate from Protocol below? Or, perhaps, just pass `array of Protocol` instead?
undefinedCan we ditch this and make the argument `optional` instead? This would also make it easier to reuse this enum as suggested above.
integer currentCountcurrent count of what?
string contextIdI assume this should be `optional` to accomodate cases when resultCode is an error?
string handlemake optional in case of error? Alternatively, since this is a recurring pattern, we can let clients use `reportPlainResult` (or even a dedicated command `reportOperationFailed`) to report errors and expect `reportFoo` methods carrying specific arguments to only be invoked on success, thus ditching `resultCode` in calls like this one.
array of ReaderStateIn readerStatesnot sure I understand what's happening here. For the underlying API, this appears to be a in/out param, with only the names mattering for input. Why do we pass other fields in ReaderStateIn?
optional integer timeout`number` and document the units, e.g. seconds?
Related details
- Paulina Gacek
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |