Update mhtml saved page header to "Saved by Blink" (issue 871433008 by samahto@cisco.com)

1,136 views
Skip to first unread message

sam...@cisco.com

unread,
Feb 5, 2015, 9:24:32 PM2/5/15
to e...@chromium.org, da...@chromium.org, ese...@chromium.org, joc...@chromium.org, p...@chromium.org, blink-...@chromium.org
Reviewers: eae, darin - slow to review, eseidel, jochen (slow), pdr,

Description:
Update mhtml saved page header to "Saved by Blink"

BUG=None
TEST=NONE

Please review this at https://codereview.chromium.org/871433008/

Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Affected files (+1, -1 lines):
M Source/platform/mhtml/MHTMLArchive.cpp


Index: Source/platform/mhtml/MHTMLArchive.cpp
diff --git a/Source/platform/mhtml/MHTMLArchive.cpp
b/Source/platform/mhtml/MHTMLArchive.cpp
index
76a1e140571cd8532d64677ace77cfa47a43c67e..2661cf831784547f1740f470ae8c5ff04905ba53
100644
--- a/Source/platform/mhtml/MHTMLArchive.cpp
+++ b/Source/platform/mhtml/MHTMLArchive.cpp
@@ -132,7 +132,7 @@ PassRefPtr<SharedBuffer>
MHTMLArchive::generateMHTMLData(const Vector<Serialized
String dateString = makeRFC2822DateString(now.weekDay(),
now.monthDay(), now.month(), now.fullYear(), now.hour(), now.minute(),
now.second(), 0);

StringBuilder stringBuilder;
- stringBuilder.appendLiteral("From: <Saved by WebKit>\r\n");
+ stringBuilder.appendLiteral("From: <Saved by Blink>\r\n");
stringBuilder.appendLiteral("Subject: ");
// We replace non ASCII characters with '?' characters to match IE's
behavior.
stringBuilder.append(replaceNonPrintableCharacters(title));


e...@chromium.org

unread,
Feb 5, 2015, 10:16:34 PM2/5/15
to sam...@cisco.com, da...@chromium.org, ese...@chromium.org, joc...@chromium.org, p...@chromium.org, blink-...@chromium.org
LGTM

https://codereview.chromium.org/871433008/

commi...@chromium.org

unread,
Feb 5, 2015, 10:23:12 PM2/5/15
to sam...@cisco.com, e...@chromium.org, da...@chromium.org, ese...@chromium.org, joc...@chromium.org, p...@chromium.org, blink-...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/871433008/1


https://codereview.chromium.org/871433008/

commi...@chromium.org

unread,
Feb 5, 2015, 11:42:13 PM2/5/15
to sam...@cisco.com, e...@chromium.org, da...@chromium.org, ese...@chromium.org, joc...@chromium.org, p...@chromium.org, blink-...@chromium.org
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189613

https://codereview.chromium.org/871433008/

p...@chromium.org

unread,
Feb 6, 2015, 5:37:21 PM2/6/15
to sam...@cisco.com, e...@chromium.org, da...@chromium.org, ese...@chromium.org, joc...@chromium.org, blink-...@chromium.org
On 2015/02/06 at 04:42:12, commit-bot wrote:
> Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189613

I'm surprised we don't have any tests for this.

@samahto, this isn't something you caused but would you be up for writing a
test
so we have some coverage of this area?

https://codereview.chromium.org/871433008/
Reply all
Reply to author
Forward
0 new messages