webrtc wpt: allow 'checking' without addIceCandidate from the remote end [chromium/src : main]

0 views
Skip to first unread message

Philipp Hancke (Gerrit)

unread,
Jun 27, 2023, 5:23:05 AM6/27/23
to Harald Alvestrand, blink-revie...@chromium.org, blink-...@chromium.org

Attention is currently required from: Harald Alvestrand.

Philipp Hancke would like Harald Alvestrand to review this change.

View Change

webrtc wpt: allow 'checking' without addIceCandidate from the remote end

test for https://github.com/w3c/webrtc-pc/pull/2884

BUG=None

Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
---
M third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https.html
1 file changed, 51 insertions(+), 33 deletions(-)


To view, visit change 4649349. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
Gerrit-Change-Number: 4649349
Gerrit-PatchSet: 2
Gerrit-Owner: Philipp Hancke <pha...@microsoft.com>
Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Philipp Hancke (Gerrit)

unread,
Jun 27, 2023, 5:23:09 AM6/27/23
to blink-revie...@chromium.org, blink-...@chromium.org, Harald Alvestrand, chromium...@chromium.org

Attention is currently required from: Harald Alvestrand.

    To view, visit change 4649349. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
    Gerrit-Change-Number: 4649349
    Gerrit-PatchSet: 2
    Gerrit-Owner: Philipp Hancke <pha...@microsoft.com>
    Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
    Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
    Gerrit-Comment-Date: Tue, 27 Jun 2023 09:23:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No

    Philipp Hancke (Gerrit)

    unread,
    Jun 27, 2023, 5:26:16 AM6/27/23
    to blink-revie...@chromium.org, blink-...@chromium.org, Harald Alvestrand, chromium...@chromium.org

    Attention is currently required from: Harald Alvestrand.

    View Change

    1 comment:

    • File third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https.html:

      • Patch Set #2, Line 282: for (let bundle_policy of ['balanced', 'max-bundle', 'max-compat']) {

        just whitespace/indent fixes

    To view, visit change 4649349. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
    Gerrit-Change-Number: 4649349
    Gerrit-PatchSet: 2
    Gerrit-Owner: Philipp Hancke <pha...@microsoft.com>
    Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
    Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
    Gerrit-Comment-Date: Tue, 27 Jun 2023 09:26:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No

    Harald Alvestrand (Gerrit)

    unread,
    Jun 27, 2023, 5:37:11 AM6/27/23
    to Philipp Hancke, blink-revie...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

    Attention is currently required from: Philipp Hancke.

    Patch set 2:Code-Review +1

    View Change

      To view, visit change 4649349. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
      Gerrit-Change-Number: 4649349
      Gerrit-PatchSet: 2
      Gerrit-Owner: Philipp Hancke <pha...@microsoft.com>
      Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
      Gerrit-Attention: Philipp Hancke <pha...@microsoft.com>
      Gerrit-Comment-Date: Tue, 27 Jun 2023 09:37:04 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Jun 27, 2023, 6:22:34 AM6/27/23
      to Philipp Hancke, blink-revie...@chromium.org, blink-...@chromium.org, Harald Alvestrand, chromium...@chromium.org

      Attention is currently required from: Philipp Hancke.

      Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/40765.

      When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

      WPT Export docs:
      https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

      View Change

        To view, visit change 4649349. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
        Gerrit-Change-Number: 4649349
        Gerrit-PatchSet: 2
        Gerrit-Owner: Philipp Hancke <pha...@microsoft.com>
        Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
        Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
        Gerrit-Attention: Philipp Hancke <pha...@microsoft.com>
        Gerrit-Comment-Date: Tue, 27 Jun 2023 10:22:24 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: No

        Philipp Hancke (Gerrit)

        unread,
        Jun 29, 2023, 3:44:27 PM6/29/23
        to blink-revie...@chromium.org, blink-...@chromium.org

        Attention is currently required from: Philipp Hancke.

        Philipp Hancke uploaded patch set #3 to this change.

        View Change

        webrtc wpt: allow 'checking' without addIceCandidate from the remote end

        test for https://github.com/w3c/webrtc-pc/pull/2884

        BUG=webrtc:9086


        Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
        ---
        M third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https.html
        1 file changed, 51 insertions(+), 33 deletions(-)

        To view, visit change 4649349. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-MessageType: newpatchset
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
        Gerrit-Change-Number: 4649349
        Gerrit-PatchSet: 3

        Philipp Hancke (Gerrit)

        unread,
        Jun 29, 2023, 3:44:35 PM6/29/23
        to blink-revie...@chromium.org, blink-...@chromium.org, Blink W3C Test Autoroller, Harald Alvestrand, chromium...@chromium.org

        Attention is currently required from: Philipp Hancke.

        Patch set 3:Commit-Queue +2

        View Change

          To view, visit change 4649349. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
          Gerrit-Change-Number: 4649349
          Gerrit-PatchSet: 3
          Gerrit-Owner: Philipp Hancke <pha...@microsoft.com>
          Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
          Gerrit-Reviewer: Philipp Hancke <pha...@microsoft.com>
          Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
          Gerrit-Attention: Philipp Hancke <pha...@microsoft.com>
          Gerrit-Comment-Date: Thu, 29 Jun 2023 19:44:27 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes

          Chromium LUCI CQ (Gerrit)

          unread,
          Jun 29, 2023, 4:28:03 PM6/29/23
          to Philipp Hancke, blink-revie...@chromium.org, blink-...@chromium.org, Blink W3C Test Autoroller, Harald Alvestrand, chromium...@chromium.org

          Chromium LUCI CQ submitted this change.

          View Change



          2 is the latest approved patch-set.
          No files were changed between the latest approved patch-set and the submitted one.

          Approvals: Philipp Hancke: Commit Harald Alvestrand: Looks good to me
          webrtc wpt: allow 'checking' without addIceCandidate from the remote end

          test for https://github.com/w3c/webrtc-pc/pull/2884

          BUG=webrtc:9086

          Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
          Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4649349
          Commit-Queue: Philipp Hancke <pha...@microsoft.com>
          Reviewed-by: Harald Alvestrand <h...@chromium.org>
          Cr-Commit-Position: refs/heads/main@{#1164320}

          ---
          M third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https.html
          1 file changed, 51 insertions(+), 33 deletions(-)


          To view, visit change 4649349. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
          Gerrit-Change-Number: 4649349
          Gerrit-PatchSet: 4
          Gerrit-Owner: Philipp Hancke <pha...@microsoft.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

          Blink W3C Test Autoroller (Gerrit)

          unread,
          Jun 29, 2023, 5:05:30 PM6/29/23
          to Philipp Hancke, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, Harald Alvestrand, chromium...@chromium.org

          The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/40765

          View Change

            To view, visit change 4649349. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
            Gerrit-Change-Number: 4649349
            Gerrit-PatchSet: 4
            Gerrit-Owner: Philipp Hancke <pha...@microsoft.com>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
            Gerrit-Reviewer: Philipp Hancke <pha...@microsoft.com>
            Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
            Gerrit-Comment-Date: Thu, 29 Jun 2023 21:05:22 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: No
            Reply all
            Reply to author
            Forward
            0 new messages