Fix a few issues with WebCodecs and media internals [chromium/src : main]
0 views
Skip to first unread message
Dale Curtis (Gerrit)
Nov 13, 2025, 7:14:14 PM (yesterday) Nov 13
to Ted (Chromium) Meyer, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Ted (Chromium) Meyer
Dale Curtis voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Ted (Chromium) Meyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ted (Chromium) Meyer (Gerrit)
2:19 PM (9 hours ago) 2:19 PM
to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis
Ted (Chromium) Meyer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ted (Chromium) Meyer
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
File third_party/blink/renderer/modules/webcodecs/decoder_template.cc
Line 88, Patchset 2 (Latest):
logger_->SendPlayerNameInformation(*context, Traits::GetName());Ted (Chromium) Meyer . resolved
I assume this addresses ```
- AudioDecoder/VideoDecoder were missing labels
- ```
Otherwise I'm not sure where the labels are being applied.
Related details
Attention is currently required from:
- Dale Curtis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:23 PM (9 hours ago) 2:23 PM
to Dale Curtis, Ted (Chromium) Meyer, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix a few issues with WebCodecs and media internals
* Fixed Webcodecs prefix to match official WebCodecs spelling
* AudioDecoder/VideoDecoder were missing labels
* None of the encoders or decoders recorded destruction
* Destruction detection in chrome://media-internals was broken
* Switched last state display to say "Destroyed" w/o referring to
WebMediaPlayer for easier readability
R=tmathmeyer
Change-Id: If7f18497bbd6ecda58c01f8369f50e1533e0e4ec
Commit-Queue: Ted (Chromium) Meyer <tmath...@chromium.org>
Reviewed-by: Ted (Chromium) Meyer <tmath...@chromium.org>
Auto-Submit: Dale Curtis <dalec...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1545139}
Files:
- M content/browser/resources/media/client_renderer.js
- M third_party/blink/renderer/modules/webcodecs/codec_logger.cc
- M third_party/blink/renderer/modules/webcodecs/codec_logger.h
- M third_party/blink/renderer/modules/webcodecs/decoder_template.cc
- M third_party/blink/renderer/modules/webcodecs/encoder_base.cc
Change size: S
Delta: 5 files changed, 14 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ted (Chromium) Meyer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
4:22 PM (7 hours ago) 4:22 PM
to Chromium LUCI CQ, Ted (Chromium) Meyer, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Dale Curtis added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/webcodecs/decoder_template.cc
Line 88, Patchset 2:
logger_->SendPlayerNameInformation(*context, Traits::GetName());Ted (Chromium) Meyer . resolved
I assume this addresses ```
- AudioDecoder/VideoDecoder were missing labels
- ```
Otherwise I'm not sure where the labels are being applied.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages