Reland "geolocation: Implement visibility-aware pause and resume for position requests" [chromium/src : main]
0 views
Skip to first unread message
Alvin Ji (Gerrit)
Jul 24, 2026, 1:08:40 PM (3 days ago) Jul 24
to Chromium LUCI CQ, Matt Reynolds, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Matt Reynolds
Alvin Ji added 1 comment![]( "Open in Gerrit")
File chrome/test/data/webui/guest_view_shared/slim_webview_browsertest.cc
Line 63, Patchset 2 (Latest):
web_contents->WasShown();Alvin Ji . unresolved
Due to the visibility requirement change, the browser test now need to call web_contents->WasShown() before sending geolocation request.
Related details
Attention is currently required from:
- Matt Reynolds
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Reynolds (Gerrit)
Jul 24, 2026, 8:07:55 PM (2 days ago) Jul 24
to Alvin Ji, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Alvin Ji
Matt Reynolds voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matt Reynolds
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Alvin Ji
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alvin Ji (Gerrit)
Jul 24, 2026, 8:11:50 PM (2 days ago) Jul 24
to Matt Reynolds, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org
Alvin Ji added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Alvin Ji . resolved
Thanks for review!
File chrome/test/data/webui/guest_view_shared/slim_webview_browsertest.cc
Line 63, Patchset 2 (Latest):
web_contents->WasShown();Alvin Ji . resolved
Due to the visibility requirement change, the browser test now need to call web_contents->WasShown() before sending geolocation request.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alvin Ji (Gerrit)
Jul 24, 2026, 8:11:54 PM (2 days ago) Jul 24
to Matt Reynolds, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org
Alvin Ji voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 24, 2026, 8:16:10 PM (2 days ago) Jul 24
to Alvin Ji, Matt Reynolds, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "geolocation: Implement visibility-aware pause and resume for position requests"
This is a reland of commit e62f5b7b6ebb275abd1354914e4fd7ec82d2a2b7
Original change's description:
> geolocation: Implement visibility-aware pause and resume for position requests
>
> This CL implements pause and resume support for Blink Geolocation API
> requests, ensuring mid-flight timeout timers correctly pause while a tab
> is hidden and resume with their exact remaining time upon unhiding.
>
> Requests initiated while hidden are left in a dormant state and armed
> upon foregrounding, preventing spurious background dispatches.
>
> Bug: 534027930
> Change-Id: I9c220d781b4bd68b745762cf3ed201e2960cfa55
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8103623
> Reviewed-by: Matt Reynolds <mattre...@chromium.org>
> Commit-Queue: Alvin Ji <alv...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1667572}
Bug: 534027930
Change-Id: I7923b1df8514d070bd766f30583dfb70004d85d8
Commit-Queue: Alvin Ji <alv...@chromium.org>
Reviewed-by: Matt Reynolds <mattre...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1668225}
Files:
- M chrome/test/data/webui/guest_view_shared/slim_webview_browsertest.cc
- M third_party/blink/renderer/core/geolocation/geo_notifier.cc
- M third_party/blink/renderer/core/geolocation/geo_notifier.h
- M third_party/blink/renderer/core/geolocation/geolocation.cc
- M third_party/blink/renderer/core/geolocation/geolocation.h
- M third_party/blink/web_tests/wpt_internal/geolocation-api/getCurrentPosition_visibility.https.html
- A third_party/blink/web_tests/wpt_internal/geolocation-api/getCurrentPosition_visibility_cached.https.html
Change size: L
Delta: 7 files changed, 236 insertions(+), 25 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Matt Reynolds
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joel Hockey (Gerrit)
1:26 AM (3 hours ago) 1:26 AM
to Chromium LUCI CQ, Alvin Ji, Matt Reynolds, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, Joel Hockey
Joel Hockey has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages