Fix unsafe buffer usage in throttling_test.cc [chromium/src : main]

0 views
Skip to first unread message

Scott Haseley (Gerrit)

unread,
12:16 PM (2 hours ago) 12:16 PM
to Xiang Ji, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, web-schedulin...@chromium.org
Attention needed from Xiang Ji

Scott Haseley voted and added 1 comment

Votes added by Scott Haseley

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Scott Haseley . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Xiang Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6ab55051103090ef8e9abacf4bf0572cf16e326b
Gerrit-Change-Number: 7812241
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
Gerrit-Attention: Xiang Ji <jxi...@google.com>
Gerrit-Comment-Date: Tue, 05 May 2026 16:15:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Xiang Ji (Gerrit)

unread,
1:20 PM (1 hour ago) 1:20 PM
to Scott Haseley, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, web-schedulin...@chromium.org

Xiang Ji voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6ab55051103090ef8e9abacf4bf0572cf16e326b
Gerrit-Change-Number: 7812241
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
Gerrit-Comment-Date: Tue, 05 May 2026 17:20:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
2:13 PM (2 minutes ago) 2:13 PM
to Xiang Ji, Scott Haseley, chromium...@chromium.org, blink-...@chromium.org, web-schedulin...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Fix unsafe buffer usage in throttling_test.cc

Resolved unsafe pointer patterns and operations by transitioning to safe
structures, adhering to Chromium's modern memory safety rules.

Generated with Gemini CLI.
Bug: 435317390
Change-Id: I6ab55051103090ef8e9abacf4bf0572cf16e326b
Reviewed-by: Scott Haseley <shas...@chromium.org>
Commit-Queue: Xiang Ji <jxi...@google.com>
Cr-Commit-Position: refs/heads/main@{#1625591}
Files:
  • M third_party/blink/renderer/core/scheduler_integration_tests/throttling_test.cc
Change size: M
Delta: 1 file changed, 139 insertions(+), 95 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Scott Haseley
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6ab55051103090ef8e9abacf4bf0572cf16e326b
Gerrit-Change-Number: 7812241
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages