Fix unsafe buffer usage in layout_locale_test.cc [chromium/src : main]

0 views
Skip to first unread message

Kentaro Hara (Gerrit)

unread,
3:02 AM (11 hours ago) 3:02 AM
to Xiang Ji, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Xiang Ji

Kentaro Hara voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Xiang Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I65eafbfd1ff82d37cd5be787b2cae9d066d323a1
Gerrit-Change-Number: 7812655
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
Gerrit-Attention: Xiang Ji <jxi...@google.com>
Gerrit-Comment-Date: Tue, 05 May 2026 07:01:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Xiang Ji (Gerrit)

unread,
11:57 AM (2 hours ago) 11:57 AM
to Kentaro Hara, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Xiang Ji voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I65eafbfd1ff82d37cd5be787b2cae9d066d323a1
Gerrit-Change-Number: 7812655
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
Gerrit-Comment-Date: Tue, 05 May 2026 15:57:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
12:33 PM (2 hours ago) 12:33 PM
to Xiang Ji, Kentaro Hara, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Fix unsafe buffer usage in layout_locale_test.cc

Replaced String::Format with standard stream insertion to remove
unsafe buffer usage.

Initial patchset generated by headless gemini-cli using:
//agents/prompts/projects/spanification/run.py
Bug: 435317390
Change-Id: I65eafbfd1ff82d37cd5be787b2cae9d066d323a1
Reviewed-by: Kentaro Hara <har...@chromium.org>
Commit-Queue: Xiang Ji <jxi...@google.com>
Cr-Commit-Position: refs/heads/main@{#1625503}
Files:
  • M third_party/blink/renderer/platform/text/layout_locale_test.cc
Change size: XS
Delta: 1 file changed, 4 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kentaro Hara
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I65eafbfd1ff82d37cd5be787b2cae9d066d323a1
Gerrit-Change-Number: 7812655
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages