Switch blink feature KeyboardFocusableScrollers to status experimental [chromium/src : main]
Di Zhang (Gerrit)
Attention is currently required from: Mason Freed.
Di Zhang would like Mason Freed to review this change.
Switch blink feature KeyboardFocusableScrollers to status experimental
We are switching feature KeyboardFocusableScrollers to experimental.
Change-Id: Ie1a1bc830ae51c5d0d6e474d4b43ac67e0a601b9
Bug: 1040141
---
M third_party/blink/renderer/platform/runtime_enabled_features.json5
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
index 3a12d3cc..f729fe4 100644
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
@@ -2279,7 +2279,7 @@
},
{
name: "KeyboardFocusableScrollers",
- status: "test",
+ status: "experimental",
},
{
name: "LangAttributeAwareFormControlUI",
To view, visit change 5010925. To unsubscribe, or for help writing mail filters, visit settings.
Di Zhang (Gerrit)
Attention is currently required from: Mason Freed.
1 comment:
Patchset:
The first step to enabling KeyboardFocusableScrollers is to enable it in canary/dev and see what are the crashes it might cause.
We will restart a Finch experiment.
To view, visit change 5010925. To unsubscribe, or for help writing mail filters, visit settings.
Chris Harrelson (Gerrit)
Attention is currently required from: Di Zhang, Mason Freed.
1 comment:
Patchset:
I don't think we can make this change until we fix the code not to be called from a11y.
To view, visit change 5010925. To unsubscribe, or for help writing mail filters, visit settings.
Di Zhang (Gerrit)
I don't think we can make this change until we fix the code not to be called from a11y.
Which code is it, do you have a crbug link? Thanks
To view, visit change 5010925. To unsubscribe, or for help writing mail filters, visit settings.
Chris Harrelson (Gerrit)
Attention is currently required from: Di Zhang.
1 comment:
Patchset:
Which code is it, do you have a crbug link? Thanks
There were accessibility crash bug, some of which were due to forcing layout during a11y because of KeyboardFocusableScrollers by calling IsScrollableContainerThatShouldBeKeyboardFocusable from a11y. Is this code path gone now?
To view, visit change 5010925. To unsubscribe, or for help writing mail filters, visit settings.
Di Zhang (Gerrit)
Attention is currently required from: Chris Harrelson.
1 comment:
Patchset:
There were accessibility crash bug, some of which were due to forcing layout during a11y because of […]
No, that is still present. It is hard to avoid since we need a clean layout to check if an element is a scroller node.
I see, will try to think of a way around that.
To view, visit change 5010925. To unsubscribe, or for help writing mail filters, visit settings.
Chris Harrelson (Gerrit)
Attention is currently required from: Di Zhang.
1 comment:
Patchset:
No, that is still present. […]
I think you'll just need to not call your code from a11y by refactoring. You could build on top of this CL from Mason: https://chromium-review.googlesource.com/c/chromium/src/+/5008754
Currently it still calls SupportsFocus, but that needs to change, maybe by passing a parameter to SupportsFocus to skip keyboard focusable scrollers.
To view, visit change 5010925. To unsubscribe, or for help writing mail filters, visit settings.
Di Zhang (Gerrit)
Attention is currently required from: Chris Harrelson.
1 comment:
Patchset:
I think you'll just need to not call your code from a11y by refactoring. […]
We have done some more refactoring to include an argument UpdateBehavior that will not update style/layout if coming for A11Y code:
https://chromium-review.googlesource.com/c/chromium/src/+/5028713
https://chromium-review.googlesource.com/c/chromium/src/+/5101833Next, I will enable the feature on Finch and see how it performs.
To view, visit change 5010925. To unsubscribe, or for help writing mail filters, visit settings.
Chris Harrelson (Gerrit)
Di Zhang (Gerrit)
Patch set 1:Commit-Queue +2
1 comment:
Patchset:
We have done some more refactoring to include an argument UpdateBehavior that will not update style/ […]
Done
To view, visit change 5010925. To unsubscribe, or for help writing mail filters, visit settings.
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
Switch blink feature KeyboardFocusableScrollers to status experimental
We are switching feature KeyboardFocusableScrollers to experimental.
Change-Id: Ie1a1bc830ae51c5d0d6e474d4b43ac67e0a601b9
Bug: 1040141
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5010925
Reviewed-by: Chris Harrelson <chri...@chromium.org>
Commit-Queue: Di Zhang <dizh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1236545}
---
M third_party/blink/renderer/platform/runtime_enabled_features.json5
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
index 492b4b9..4c4bd9e 100644
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
@@ -2183,7 +2183,7 @@
},
{
name: "KeyboardFocusableScrollers",
- status: "test",
+ status: "experimental",
},
{
name: "LangAttributeAwareFormControlUI",
To view, visit change 5010925. To unsubscribe, or for help writing mail filters, visit settings.