Revert "Deduplicate RunInfoPart::run_ in ShapeResultView" [chromium/src : main]

0 views
Skip to first unread message

Chrome Crash (Prod) (Gerrit)

unread,
Jul 4, 2026, 12:23:20 AM (3 days ago) Jul 4
to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Kurt Catti-Schmidt, Koji Ishii, Stephen Chenney, Ian Kilpatrick, chromium...@chromium.org, chrom...@appspot.gserviceaccount.com, Dirk Schulze, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, fserb...@chromium.org
Attention needed from Koji Ishii and Kurt Catti-Schmidt

Chrome Crash (Prod) voted Commit-Queue+1

Trigger the CQ Dryrun through the Set Review API to save waiting time.

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Koji Ishii
  • Kurt Catti-Schmidt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6dc1153288e546d8d351686dc4e377b06df37ae4
Gerrit-Change-Number: 8040804
Gerrit-PatchSet: 2
Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
Gerrit-Reviewer: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Comment-Date: Sat, 04 Jul 2026 04:23:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 4, 2026, 12:24:36 AM (3 days ago) Jul 4
to Chrome Crash (Prod), android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Kurt Catti-Schmidt, Koji Ishii, Stephen Chenney, Ian Kilpatrick, chromium...@chromium.org, chrom...@appspot.gserviceaccount.com, Dirk Schulze, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, fserb...@chromium.org
Attention needed from Koji Ishii and Kurt Catti-Schmidt

Related details

Attention is currently required from:
  • Koji Ishii
  • Kurt Catti-Schmidt
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6dc1153288e546d8d351686dc4e377b06df37ae4
    Gerrit-Change-Number: 8040804
    Gerrit-PatchSet: 3
    Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
    Gerrit-Reviewer: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Attention: Koji Ishii <ko...@chromium.org>
    Gerrit-Comment-Date: Sat, 04 Jul 2026 04:24:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Koji Ishii (Gerrit)

    unread,
    9:44 AM (5 hours ago) 9:44 AM
    to Chrome Crash (Prod), rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Kurt Catti-Schmidt, Stephen Chenney, Ian Kilpatrick, chromium...@chromium.org, chrom...@appspot.gserviceaccount.com, Dirk Schulze, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, fserb...@chromium.org
    Attention needed from Kurt Catti-Schmidt

    Koji Ishii voted and added 1 comment

    Votes added by Koji Ishii

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Koji Ishii . resolved

    lgtm, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kurt Catti-Schmidt
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6dc1153288e546d8d351686dc4e377b06df37ae4
    Gerrit-Change-Number: 8040804
    Gerrit-PatchSet: 3
    Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
    Gerrit-Reviewer: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Comment-Date: Mon, 06 Jul 2026 13:44:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Koji Ishii (Gerrit)

    unread,
    10:26 AM (4 hours ago) 10:26 AM
    to Chrome Crash (Prod), rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Kurt Catti-Schmidt, Stephen Chenney, Ian Kilpatrick, chromium...@chromium.org, chrom...@appspot.gserviceaccount.com, Dirk Schulze, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, fserb...@chromium.org
    Attention needed from Kurt Catti-Schmidt

    Koji Ishii voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Mon, 06 Jul 2026 14:25:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    11:31 AM (3 hours ago) 11:31 AM
    to Chrome Crash (Prod), Koji Ishii, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Kurt Catti-Schmidt, Stephen Chenney, Ian Kilpatrick, chromium...@chromium.org, chrom...@appspot.gserviceaccount.com, Dirk Schulze, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, fserb...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "Deduplicate RunInfoPart::run_ in ShapeResultView"

    This reverts commit bc6ef8af863723a00d5eba4131f7ca4e3606d0a6.

    Reason for revert: 
    The Suspect CL https://chromium-review.googlesource.com/q/Id04c37fb92a9328032ac368673f7e12eba6008d1 is highly likely the cause of the crash. Please see the crash report http://crash/6e9030bfc91176ea.
    Rebase the Revert CL on top of main branch with conflicts allowed option to prevent false positive merge conflicts.

    If you agree with the revert CL, please approve it and mark as Commit-Queue +2 to submit it.

    More details can be found in the go/crash-revert-cls-creation.

    Original change's description:
    > Deduplicate RunInfoPart::run_ in ShapeResultView
    > 
    > ShapeResultView contains a member for `run_`, but this is unnecessary
    > since it can be queried from range_. Removing this results in very
    > slight memory and perf improvements.
    > 
    > Bug: 523940241
    > Change-Id: Id04c37fb92a9328032ac368673f7e12eba6008d1
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7955904
    > Reviewed-by: Koji Ishii <ko...@chromium.org>
    > Commit-Queue: Kurt Catti-Schmidt <ksc...@microsoft.com>
    > Cr-Commit-Position: refs/heads/main@{#1656096}
    >
    Bug: 531062336
    Change-Id: I6dc1153288e546d8d351686dc4e377b06df37ae4
    Commit-Queue: Koji Ishii <ko...@chromium.org>
    Reviewed-by: Koji Ishii <ko...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1657213}
    Files:
    • M third_party/blink/renderer/platform/fonts/shaping/glyph_data_range.h
    • M third_party/blink/renderer/platform/fonts/shaping/shape_result_view.cc
    • M third_party/blink/renderer/platform/fonts/shaping/shape_result_view.h
    Change size: M
    Delta: 3 files changed, 26 insertions(+), 24 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6dc1153288e546d8d351686dc4e377b06df37ae4
    Gerrit-Change-Number: 8040804
    Gerrit-PatchSet: 4
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages