text-fit: Rename FitTextScale and FitTextBlockScale [chromium/src : main]

1 view
Skip to first unread message

Kent Tamura (Gerrit)

unread,
May 25, 2026, 9:51:39 PM (5 hours ago) May 25
to Kent Tamura, Koji Ishii, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Koji Ishii

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kent Tamura . resolved

kojii@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Koji Ishii
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I20e5c4ac584e0c12e222b75e595e8c0a6dd1bfae
Gerrit-Change-Number: 7866735
Gerrit-PatchSet: 2
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Comment-Date: Tue, 26 May 2026 01:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Koji Ishii (Gerrit)

unread,
May 25, 2026, 11:17:11 PM (4 hours ago) May 25
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kent Tamura

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Koji Ishii . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I20e5c4ac584e0c12e222b75e595e8c0a6dd1bfae
    Gerrit-Change-Number: 7866735
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Tue, 26 May 2026 03:16:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 25, 2026, 11:21:25 PM (4 hours ago) May 25
    to Kent Tamura, Koji Ishii, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    text-fit: Rename FitTextScale and FitTextBlockScale

    This CL replaces 'FitText' in them with 'TextFit' for consistency with
    `text-fit` CSS property.

    This CL has no behavior changes.
    Bug: 417306102
    Change-Id: I20e5c4ac584e0c12e222b75e595e8c0a6dd1bfae
    Reviewed-by: Koji Ishii <ko...@chromium.org>
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Commit-Queue: Koji Ishii <ko...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1635908}
    Files:
    • M third_party/blink/renderer/core/layout/block_layout_algorithm.cc
    • M third_party/blink/renderer/core/layout/inline/fragment_item.cc
    • M third_party/blink/renderer/core/layout/inline/fragment_item.h
    • M third_party/blink/renderer/core/layout/inline/inline_box_state.cc
    • M third_party/blink/renderer/core/layout/inline/inline_box_state.h
    • M third_party/blink/renderer/core/layout/inline/inline_child_layout_context.h
    • M third_party/blink/renderer/core/layout/inline/inline_cursor.cc
    • M third_party/blink/renderer/core/layout/inline/inline_item_result.cc
    • M third_party/blink/renderer/core/layout/inline/inline_item_result.h
    • M third_party/blink/renderer/core/layout/inline/inline_layout_algorithm.cc
    • M third_party/blink/renderer/core/layout/inline/inline_layout_algorithm.h
    • M third_party/blink/renderer/core/layout/inline/inline_layout_algorithm_test.cc
    • M third_party/blink/renderer/core/layout/inline/line_widths.cc
    • M third_party/blink/renderer/core/layout/inline/logical_line_builder.cc
    • M third_party/blink/renderer/core/layout/inline/logical_line_builder.h
    • M third_party/blink/renderer/core/layout/inline/logical_line_item.cc
    • M third_party/blink/renderer/core/layout/inline/logical_line_item.h
    • M third_party/blink/renderer/core/layout/inline/ruby_utils.cc
    • M third_party/blink/renderer/core/layout/inline/text_fit_scale.h
    • M third_party/blink/renderer/core/layout/inline/text_fit_utils.cc
    • M third_party/blink/renderer/core/layout/inline/text_fit_utils.h
    • M third_party/blink/renderer/core/paint/text_fragment_painter.cc
    Change size: M
    Delta: 22 files changed, 119 insertions(+), 119 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Koji Ishii
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I20e5c4ac584e0c12e222b75e595e8c0a6dd1bfae
    Gerrit-Change-Number: 7866735
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages