Revert "Reapply "Use typed promises/resolvers for ReadableStream and related classes"" [chromium/src : main]
0 views
Skip to first unread message
Blink W3C Test Autoroller (Gerrit)
Apr 5, 2024, 2:15:17 PMApr 5
to Nate Chapin, AyeAye, Rubber Stamper, Nidhi Jaju, Adam Rice, Chromium LUCI CQ, Alexis Menard, Tricium, Kentaro Hara, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, jshin...@chromium.org, blink-...@chromium.org, ricea...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org
Attention needed from Adam Rice and Nidhi Jaju
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/45579.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Adam Rice
- Nidhi Jaju
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Chapin (Gerrit)
Apr 5, 2024, 2:21:19 PMApr 5
to AyeAye, Rubber Stamper, Nidhi Jaju, Adam Rice, Chromium LUCI CQ, Alexis Menard, Tricium, Kentaro Hara, chromium...@chromium.org, Olga Gerchikov, Blink W3C Test Autoroller, blink-revie...@chromium.org, blink-revie...@chromium.org, jshin...@chromium.org, blink-...@chromium.org, ricea...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org
Attention needed from Adam Rice and Nidhi Jaju
Nate Chapin voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Adam Rice
- Nidhi Jaju
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 5, 2024, 3:30:09 PMApr 5
to Nate Chapin, AyeAye, Rubber Stamper, Nidhi Jaju, Adam Rice, Alexis Menard, Tricium, Kentaro Hara, chromium...@chromium.org, Olga Gerchikov, Blink W3C Test Autoroller, blink-revie...@chromium.org, blink-revie...@chromium.org, jshin...@chromium.org, blink-...@chromium.org, ricea...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "Reapply "Use typed promises/resolvers for ReadableStream and related classes""
This reverts commit 39adf0544a3fbfcce710b0490d3825174c0c6e12.
Reason for revert: Crashes in the wild: crbug.com/332806529
Original change's description:
> Reapply "Use typed promises/resolvers for ReadableStream and related classes"
>
> This converts IDL-exposed promises in ReadableStream,
> ReadableStreamBYOBReader, ReadableStreamDefaultReader, and
> ReadableStreamGenericReader to use typed ScriptPromiseResolver
> instead of StreamPromiseResolver and to return typed
> ScriptPromises.
>
> Bug: 329702363
> Change-Id: I6dad0ce6902c2dd5411185800bdd5a6dd8585df8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410703
> Reviewed-by: Nidhi Jaju <nidh...@chromium.org>
> Commit-Queue: Nate Chapin <jap...@chromium.org>
> Reviewed-by: Adam Rice <ri...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1281906}
Bug: 329702363
Change-Id: I2a70811f87d844a1686fc082d67c8dbc473f91c2
Commit-Queue: Nate Chapin <jap...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1283318}
Files:
- M third_party/blink/renderer/bindings/core/v8/script_promise.h
- M third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h
- M third_party/blink/renderer/bindings/generated_in_core.gni
- M third_party/blink/renderer/bindings/idl_in_core.gni
- M third_party/blink/renderer/core/streams/byte_stream_tee_engine.cc
- M third_party/blink/renderer/core/streams/pipe_to_engine.cc
- M third_party/blink/renderer/core/streams/pipe_to_engine.h
- M third_party/blink/renderer/core/streams/readable_stream.cc
- M third_party/blink/renderer/core/streams/readable_stream.h
- M third_party/blink/renderer/core/streams/readable_stream.idl
- A third_party/blink/renderer/core/streams/readable_stream_byob_read_result.idl
- M third_party/blink/renderer/core/streams/readable_stream_byob_reader.cc
- M third_party/blink/renderer/core/streams/readable_stream_byob_reader.h
- M third_party/blink/renderer/core/streams/readable_stream_byob_reader.idl
- M third_party/blink/renderer/core/streams/readable_stream_default_reader.cc
- M third_party/blink/renderer/core/streams/readable_stream_default_reader.h
- M third_party/blink/renderer/core/streams/readable_stream_generic_reader.cc
- M third_party/blink/renderer/core/streams/readable_stream_generic_reader.h
- M third_party/blink/renderer/core/streams/readable_stream_generic_reader.idl
- M third_party/blink/renderer/core/streams/tee_engine.cc
- M third_party/blink/renderer/modules/webtransport/incoming_stream_test.cc
- M third_party/blink/web_tests/external/wpt/long-animation-frame/tentative/loaf-stream-source-location.html
- M third_party/blink/web_tests/external/wpt/long-animation-frame/tentative/loaf-stream.html
- D third_party/blink/web_tests/external/wpt/streams/piping/detached-context-crash.html
- M third_party/blink/web_tests/wpt_internal/encoding/streams/invalid-realm.window.js
- M third_party/blink/web_tests/wpt_internal/streams/transform-streams/invalid-realm.window.js
Change size: L
Delta: 26 files changed, 225 insertions(+), 280 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 5, 2024, 4:18:01 PMApr 5
to Nate Chapin, Chromium LUCI CQ, AyeAye, Rubber Stamper, Nidhi Jaju, Adam Rice, Alexis Menard, Tricium, Kentaro Hara, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, jshin...@chromium.org, blink-...@chromium.org, ricea...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/45579
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 24, 2024, 11:15:09 AMApr 24
to Nate Chapin, Chromium LUCI CQ, AyeAye, Rubber Stamper, Nidhi Jaju, Adam Rice, Alexis Menard, Tricium, Kentaro Hara, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, jshin...@chromium.org, blink-...@chromium.org, ricea...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/45878
Reply all
Reply to author
Forward
0 new messages